Files
renovate/lib/modules/manager/gradle/parser/handlers.ts
Sebastian Poxhofer 3412de84ce refactor(linters): enable oxlint rule prefer-named-capture-group (#44714)
* refactor(lint): enable oxlint prefer-named-capture-group at error

Numbered capture groups (m[1], $1) break silently when a regex is
edited and group order shifts. Named groups (?<name>...) make intent
explicit and accesses (m.groups.name) resilient to reordering.

This enables the built-in eslint rule prefer-named-capture-group,
surfacing 321 pre-existing unnamed-group violations across ~121
files to be burned down incrementally in follow-up commits.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(versioning): name capture groups for prefer-named-capture-group

Burns down all prefer-named-capture-group violations in
lib/modules/versioning/. Unused capture groups (only reachable via
.test() or whole-match) become non-capturing (?:...); groups whose
value is read become named (?<name>...), with accesses rewritten to
match.groups!.<name> (or destructured from .groups!) instead of
positional match[n]/$n so a future edit that reorders groups cannot
silently break the reader.

Two cases needed extra care to preserve behavior:
- semver/common.ts and poetry/patterns.ts split() on a regex whose
  capture group is relied upon by String.prototype.split to keep the
  separator in the output array; the group is kept capturing and
  named, not converted to non-capturing.
- hashicorp/convertor.ts's semverRegex is only ever embedded via
  .source into a named `(?<version>...)` group elsewhere and never
  matched directly, so its internal groups are safe to make
  non-capturing.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(datasource): name capture groups for prefer-named-capture-group

Burns down all prefer-named-capture-group violations under
lib/modules/datasource/. Same treatment as the versioning module:
unused groups become non-capturing, used groups get names, and
positional match[n] reads move to match.groups!.<name>.

docker/ecr.ts and pypi/common.ts keep their positional destructuring
(`const [, region] = ...`, `!!m &&`) working unchanged since a named
capture group is still addressable by its numeric index in
JavaScript — only pypi/common.ts's access was rewritten to
m.groups!.owner for clarity since it read a single group directly.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(platform): name capture groups for prefer-named-capture-group

Burns down all prefer-named-capture-group violations under
lib/modules/platform/. Uses the repo's established idiom of
`match.groups?.<name>` after an optional-chained exec()/match() (see
bitbucket/index.ts hostnameWithoutApiPrefix, gerrit/utils.ts
extractSourceBranch) and `$<name>` in String.replace replacement
strings. Unused groups (markdown/HTML massaging regexes matched only
to be stripped) become non-capturing.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(manager): name capture groups in ansible-galaxy for prefer-named-capture-group

Burns down prefer-named-capture-group violations in
lib/modules/manager/ansible-galaxy/. newBlockRegEx and blockLineRegEx
dropped their unused outer wrapping group (only the inner key/value
groups were ever read) and named the key/value groups; nameMatchRegex's
remaining unused groups (protocol/user-info/port alternatives) become
non-capturing since only source/hostname/depName/version are read via
.groups. Accesses in collections.ts and roles.ts move from
lineMatch[2]/lineMatch[3] to lineMatch.groups!.key/value.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(manager): name capture groups for prefer-named-capture-group (batch 1)

Burns down prefer-named-capture-group violations across the first
alphabetical slice of lib/modules/manager/ (ansible through mix).
Used groups get names with accesses rewritten to match.groups!.<name>
(or $<name> in replacement strings); groups whose value is never read
become non-capturing (?:...). Two String.split() call sites
(git-submodules/extract.ts, meteor/extract.ts) keep the established
"named group still readable positionally from the split() result
array" idiom instead of restructuring the destructuring.

bazel/rules/go.ts and buildpacks/extract.ts dockerRef verified
byte-for-byte equivalent before/after via a quick node script since
several nested groups collapsed to non-capturing at once.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(manager): name capture groups for prefer-named-capture-group (batch 2)

Burns down prefer-named-capture-group violations across the remaining
alphabetical slice of lib/modules/manager/ (npm through terragrunt).
Same treatment as batch 1: used groups get names with accesses moved
to match.groups!.<name> or $<name> replacement strings; unused groups
(wrapping alternations, quantifier repetition groups only consumed via
.test(), or values never read from a match) become non-capturing.

terraform/extractors/others/modules.ts and terragrunt/modules.ts share
near-identical URL-parsing regexes (github/bitbucket/git/azure-devops
ref matchers) — the same set of always-unused `depth=`/`&depth=`
query-string groups is converted to non-capturing in both files.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(config): name capture groups for prefer-named-capture-group

Burns down prefer-named-capture-group violations in lib/config/.
Used groups get names with replacement strings switched from $1/$2 to
$<name>; the unused separator group in schedule-migration.ts's
afterBeforeRegex becomes non-capturing. presets/parse.ts keeps
assigning through the already-declared `repo` variable rather than
array-destructuring the exec() result, matching this file's existing
style for the other named-group regexes just above it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(util): name capture groups for prefer-named-capture-group

Burns down prefer-named-capture-group violations across lib/util/ and
lib/logger/. Same treatment as previous batches: named groups for
values that are read (via $<name> replacement strings, .groups!.<name>,
or destructured from .groups), non-capturing groups where nothing reads
the captured value (e.g. semantic.ts's angular-commit .test()-only
regex). www-authenticate.ts's tokenizer entries each get their own
named group but keep accessing the match generically via match[1],
since a positionally-indexed named group is still readable by index.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(workers): name capture groups for prefer-named-capture-group

Burns down prefer-named-capture-group violations in lib/workers/.
Used groups get names with $<name> replacement strings; unused
wrapper/alternation groups (e.g. semantic-commit-message.ts's optional
scope/issue wrappers, release-notes.ts's date-heading and
horizontal-rule matchers that are only probed with .search()/replaced
wholesale) become non-capturing.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(test,tools): name capture groups for prefer-named-capture-group

Finishes the prefer-named-capture-group burndown: test/, tools/, and
vitest.config.mts. Groups whose value is read get names ($<name>
replacement strings or .groups.<name> access); groups only used via
.test()/.search() or that feed a .match(/…/g) call (whose return value
is the array of whole matches, not captured groups) become
non-capturing.

This is the last remaining slice of pre-existing violations, so the
rule (already enabled at error repo-wide) now passes with zero
findings across the whole codebase.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* fix prettier failure

* refactor(lint): use a named capture group in `v8-ignore-no-count`

New rule from main trips the newly enabled `prefer-named-capture-group` oxlint rule.

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-09-03 09:54:40 +00:00

544 lines
15 KiB
TypeScript

import upath from 'upath';
import { logger } from '../../../../logger/index.ts';
import { getSiblingFileName } from '../../../../util/fs/index.ts';
import { regEx } from '../../../../util/regex.ts';
import { parseUrl } from '../../../../util/url.ts';
import type { PackageDependency } from '../../types.ts';
import type { parseGradle as parseGradleCallback } from '../parser.ts';
import type {
ContentDescriptorMatcher,
ContentDescriptorSpec,
Ctx,
GradleManagerData,
} from '../types.ts';
import { isDependencyString, parseDependencyString } from '../utils.ts';
import {
GRADLE_PLUGINS,
GRADLE_TEST_SUITES,
findVariable,
interpolateString,
loadFromTokenMap,
} from './common.ts';
// needed to break circular dependency
let parseGradle: typeof parseGradleCallback;
export function setParseGradleFunc(func: typeof parseGradleCallback): void {
parseGradle = func;
}
export function handleAssignment(ctx: Ctx): Ctx {
const key = loadFromTokenMap(ctx, 'keyToken')[0].value;
const valTokens = loadFromTokenMap(ctx, 'valToken');
if (valTokens.length > 1) {
// = template string with multiple variables
ctx.tokenMap.templateStringTokens = valTokens;
handleDepString(ctx);
delete ctx.tokenMap.templateStringTokens;
} else if (valTokens[0].type === 'symbol') {
// foo = bar || foo = "${bar}"
const varData = findVariable(valTokens[0].value, ctx);
if (varData) {
ctx.globalVars[key] = { ...varData };
}
} else {
// = string value
const dep = parseDependencyString(valTokens[0].value);
if (dep) {
dep.sharedVariableName = key;
dep.managerData = {
fileReplacePosition: valTokens[0].offset + dep.depName!.length + 1,
packageFile: ctx.packageFile,
};
ctx.deps.push(dep);
}
ctx.globalVars[key] = {
key,
value: valTokens[0].value,
fileReplacePosition: valTokens[0].offset,
packageFile: ctx.packageFile,
};
}
return ctx;
}
export function handleDepString(ctx: Ctx): Ctx {
const stringTokens = loadFromTokenMap(ctx, 'templateStringTokens');
const templateString = interpolateString(stringTokens, ctx);
if (!templateString) {
return ctx;
}
const dep = parseDependencyString(templateString);
if (!dep) {
return ctx;
}
let packageFile: string | undefined;
let fileReplacePosition: number | undefined;
for (const token of stringTokens) {
if (token.type === 'symbol') {
const varData = findVariable(token.value, ctx);
if (varData) {
packageFile = varData.packageFile;
fileReplacePosition = varData.fileReplacePosition;
if (varData.value === dep.currentValue) {
dep.managerData = { fileReplacePosition, packageFile };
dep.sharedVariableName = varData.key;
}
}
}
}
if (!dep.managerData) {
const lastToken = stringTokens.at(-1);
if (
lastToken?.type === 'string-value' &&
dep.currentValue &&
lastToken.value.includes(dep.currentValue)
) {
packageFile = ctx.packageFile;
if (stringTokens.length === 1) {
fileReplacePosition = lastToken.offset + dep.depName!.length + 1;
} else {
fileReplacePosition =
lastToken.offset + lastToken.value.lastIndexOf(dep.currentValue);
}
delete dep.sharedVariableName;
} else {
dep.skipReason = 'contains-variable';
}
dep.managerData = { fileReplacePosition, packageFile };
}
ctx.deps.push(dep);
return ctx;
}
export function handleKotlinShortNotationDep(ctx: Ctx): Ctx {
const moduleNameTokens = loadFromTokenMap(ctx, 'artifactId');
const versionTokens = loadFromTokenMap(ctx, 'version');
const moduleName = interpolateString(moduleNameTokens, ctx);
const versionValue = interpolateString(versionTokens, ctx);
if (!moduleName || !versionValue) {
return ctx;
}
const groupIdArtifactId = `org.jetbrains.kotlin:kotlin-${moduleName}`;
const dep = parseDependencyString(`${groupIdArtifactId}:${versionValue}`);
if (!dep) {
return ctx;
}
dep.depName = moduleName;
dep.packageName = groupIdArtifactId;
dep.managerData = {
fileReplacePosition: versionTokens[0].offset,
packageFile: ctx.packageFile,
};
if (versionTokens.length > 1) {
// = template string with multiple variables
dep.skipReason = 'unspecified-version';
} else if (versionTokens[0].type === 'symbol') {
const varData = findVariable(versionTokens[0].value, ctx);
if (varData) {
dep.sharedVariableName = varData.key;
dep.currentValue = varData.value;
dep.managerData = {
fileReplacePosition: varData.fileReplacePosition,
packageFile: varData.packageFile,
};
}
}
ctx.deps.push(dep);
return ctx;
}
export function handleLongFormDep(ctx: Ctx): Ctx {
const groupIdTokens = loadFromTokenMap(ctx, 'groupId');
const artifactIdTokens = loadFromTokenMap(ctx, 'artifactId');
const versionTokens = loadFromTokenMap(ctx, 'version');
const groupId = interpolateString(groupIdTokens, ctx);
const artifactId = interpolateString(artifactIdTokens, ctx);
const version = interpolateString(versionTokens, ctx);
if (!groupId || !artifactId || !version) {
return ctx;
}
// Special handling: 3 independent dependencies mismatched as groupId, artifactId, version
if (
isDependencyString(groupId) &&
isDependencyString(artifactId) &&
isDependencyString(version)
) {
ctx.tokenMap.templateStringTokens = groupIdTokens;
handleDepString(ctx);
ctx.tokenMap.templateStringTokens = artifactIdTokens;
handleDepString(ctx);
ctx.tokenMap.templateStringTokens = versionTokens;
handleDepString(ctx);
return ctx;
}
const dep = parseDependencyString([groupId, artifactId, version].join(':'));
if (!dep) {
return ctx;
}
const methodName = ctx.tokenMap.methodName ?? null;
if (versionTokens.length > 1) {
// = template string with multiple variables
dep.skipReason = 'unspecified-version';
} else if (versionTokens[0].type === 'symbol') {
const varData = findVariable(versionTokens[0].value, ctx);
if (varData) {
dep.sharedVariableName = varData.key;
dep.managerData = {
fileReplacePosition: varData.fileReplacePosition,
packageFile: varData.packageFile,
};
}
} else {
// = string value
if (methodName?.[0]?.value === 'dependencySet') {
dep.sharedVariableName = `${groupId}:${version}`;
}
dep.managerData = {
fileReplacePosition: versionTokens[0].offset,
packageFile: ctx.packageFile,
};
}
ctx.deps.push(dep);
return ctx;
}
export function handlePlugin(ctx: Ctx): Ctx {
const methodName = loadFromTokenMap(ctx, 'methodName')[0];
const pluginNameTokens = loadFromTokenMap(ctx, 'pluginName');
const pluginVersion = loadFromTokenMap(ctx, 'version');
const plugin = interpolateString(pluginNameTokens, ctx);
if (!plugin) {
return ctx;
}
const depName =
methodName.value === 'kotlin' ? `org.jetbrains.kotlin.${plugin}` : plugin;
const packageName = `${depName}:${depName}.gradle.plugin`;
const dep: PackageDependency<GradleManagerData> = {
depType: 'plugin',
depName,
packageName,
commitMessageTopic: `plugin ${depName}`,
currentValue: pluginVersion[0].value,
managerData: {
fileReplacePosition: pluginVersion[0].offset,
packageFile: ctx.packageFile,
},
};
if (pluginVersion.length > 1) {
// = template string with multiple variables
dep.skipReason = 'unspecified-version';
} else if (pluginVersion[0].type === 'symbol') {
const varData = findVariable(pluginVersion[0].value, ctx);
if (varData) {
dep.sharedVariableName = varData.key;
dep.currentValue = varData.value;
dep.managerData = {
fileReplacePosition: varData.fileReplacePosition,
packageFile: varData.packageFile,
};
} else {
dep.skipReason = 'unspecified-version';
}
}
ctx.deps.push(dep);
return ctx;
}
function isValidContentDescriptorRegex(
fieldName: string,
pattern: string,
): boolean {
try {
regEx(pattern);
} catch {
logger.debug(
`Skipping content descriptor with unsupported regExp pattern for ${fieldName}: ${pattern}`,
);
return false;
}
return true;
}
export function handleRegistryContent(ctx: Ctx): Ctx {
const methodName = loadFromTokenMap(ctx, 'methodName')[0].value;
let groupId = loadFromTokenMap(ctx, 'groupId')[0].value;
let matcher: ContentDescriptorMatcher = 'simple';
if (methodName.includes('Regex')) {
matcher = 'regex';
groupId = `^${groupId}$`.replaceAll('\\\\', '\\');
if (!isValidContentDescriptorRegex('group', groupId)) {
return ctx;
}
} else if (methodName.includes('AndSubgroups')) {
matcher = 'subgroup';
}
const mode = methodName.startsWith('include') ? 'include' : 'exclude';
const spec: ContentDescriptorSpec = { mode, matcher, groupId };
if (methodName.includes('Module') || methodName.includes('Version')) {
spec.artifactId = loadFromTokenMap(ctx, 'artifactId')[0].value;
if (matcher === 'regex') {
spec.artifactId = `^${spec.artifactId}$`.replaceAll('\\\\', '\\');
if (!isValidContentDescriptorRegex('module', spec.artifactId)) {
return ctx;
}
}
}
if (methodName.includes('Version')) {
spec.version = loadFromTokenMap(ctx, 'version')[0].value;
if (matcher === 'regex') {
spec.version = `^${spec.version}$`.replaceAll('\\\\', '\\');
if (!isValidContentDescriptorRegex('version', spec.version)) {
return ctx;
}
}
}
ctx.tmpRegistryContent.push(spec);
return ctx;
}
function isPluginRegistry(ctx: Ctx): boolean {
if (ctx.tokenMap.registryScope) {
const registryScope = loadFromTokenMap(ctx, 'registryScope')[0].value;
return registryScope === 'pluginManagement';
}
return false;
}
function isExclusiveRegistry(ctx: Ctx): boolean {
if (ctx.tokenMap.registryType) {
const registryType = loadFromTokenMap(ctx, 'registryType')[0].value;
return registryType === 'exclusiveContent';
}
return false;
}
export function handleRegistryUrl(ctx: Ctx): Ctx {
let localVariables = ctx.globalVars;
if (!ctx.tokenMap.registryUrl) {
return ctx;
}
if (ctx.tokenMap.name) {
const nameTokens = loadFromTokenMap(ctx, 'name');
const nameValue = interpolateString(nameTokens, ctx, localVariables);
if (nameValue) {
localVariables = {
...localVariables,
name: {
key: 'name',
value: nameValue,
},
};
}
}
let registryUrl = interpolateString(
loadFromTokenMap(ctx, 'registryUrl'),
ctx,
localVariables,
);
if (registryUrl) {
registryUrl = registryUrl.replace(regEx(/\\/g), '');
const url = parseUrl(registryUrl);
if (url?.host && url.protocol) {
const registryType = isExclusiveRegistry(ctx) ? 'exclusive' : 'regular';
if (registryType === 'exclusive' && !ctx.tmpRegistryContent.length) {
logger.debug(
`Skipping exclusive registry ${registryUrl} with unsupported content descriptors`,
);
return ctx;
}
ctx.registryUrls.push({
registryUrl,
registryType,
scope: isPluginRegistry(ctx) ? 'plugin' : 'dep',
content: ctx.tmpRegistryContent,
});
}
}
return ctx;
}
export function handleCatalogLongFormDep(ctx: Ctx): Ctx {
const groupIdTokens = loadFromTokenMap(ctx, 'groupId');
const artifactIdTokens = loadFromTokenMap(ctx, 'artifactId');
const groupId = interpolateString(groupIdTokens, ctx);
const artifactId = interpolateString(artifactIdTokens, ctx);
if (!groupId || !artifactId) {
return ctx;
}
const aliasToken = loadFromTokenMap(ctx, 'alias')[0];
const key = `libs.${aliasToken.value.replace(regEx(/[-_]/g), '.')}`;
ctx.globalVars[key] = {
key,
value: `${groupId}:${artifactId}`,
fileReplacePosition: aliasToken.offset,
packageFile: ctx.packageFile,
};
if (ctx.tokenMap.version) {
const version = interpolateString(loadFromTokenMap(ctx, 'version'), ctx);
if (version) {
handleLongFormDep(ctx);
}
}
return ctx;
}
export function handleCatalogDepString(ctx: Ctx): Ctx {
const templateStringTokens = loadFromTokenMap(ctx, 'templateStringTokens');
const templateString = interpolateString(templateStringTokens, ctx);
if (!templateString) {
return ctx;
}
const aliasToken = loadFromTokenMap(ctx, 'alias')[0];
const key = `libs.${aliasToken.value.replace(regEx(/[-_]/g), '.')}`;
ctx.globalVars[key] = {
key,
value: templateString,
fileReplacePosition: aliasToken.offset,
packageFile: ctx.packageFile,
};
return handleDepString(ctx);
}
export function handleApplyFrom(ctx: Ctx): Ctx {
let scriptFile = interpolateString(loadFromTokenMap(ctx, 'scriptFile'), ctx);
if (!scriptFile) {
return ctx;
}
if (ctx.tokenMap.parentPath) {
const parentPath = interpolateString(
loadFromTokenMap(ctx, 'parentPath'),
ctx,
);
if (parentPath && scriptFile) {
scriptFile = upath.join(parentPath, scriptFile);
}
}
if (ctx.recursionDepth > 2) {
logger.debug(`Max recursion depth reached in script file: ${scriptFile}`);
return ctx;
}
if (!regEx(/\.gradle(?:\.kts)?$/).test(scriptFile)) {
logger.debug({ scriptFile }, `Only Gradle files can be included`);
return ctx;
}
const scriptFilePath = getSiblingFileName(ctx.packageFile, scriptFile);
if (!ctx.fileContents[scriptFilePath]) {
logger.debug(`Failed to process included Gradle file ${scriptFilePath}`);
return ctx;
}
const matchResult = parseGradle(
// TODO #22198
ctx.fileContents[scriptFilePath],
ctx.globalVars,
scriptFilePath,
ctx.fileContents,
ctx.recursionDepth + 1,
);
ctx.deps.push(...matchResult.deps);
ctx.globalVars = { ...ctx.globalVars, ...matchResult.vars };
ctx.registryUrls.push(...matchResult.urls);
return ctx;
}
export function handleImplicitDep(ctx: Ctx): Ctx {
const implicitDepName = loadFromTokenMap(ctx, 'implicitDepName')[0].value;
const versionTokens = loadFromTokenMap(ctx, 'version');
const versionValue = interpolateString(versionTokens, ctx);
if (!versionValue) {
return ctx;
}
const isImplicitGradlePlugin = implicitDepName in GRADLE_PLUGINS;
const groupIdArtifactId = isImplicitGradlePlugin
? GRADLE_PLUGINS[implicitDepName as keyof typeof GRADLE_PLUGINS][1]
: GRADLE_TEST_SUITES[implicitDepName as keyof typeof GRADLE_TEST_SUITES];
const dep = parseDependencyString(`${groupIdArtifactId}:${versionValue}`);
if (!dep) {
return ctx;
}
dep.depName = implicitDepName;
dep.packageName = groupIdArtifactId;
dep.managerData = {
fileReplacePosition: versionTokens[0].offset,
packageFile: ctx.packageFile,
};
if (versionTokens.length > 1) {
// = template string with multiple variables
dep.skipReason = 'unspecified-version';
} else if (versionTokens[0].type === 'symbol') {
const varData = findVariable(versionTokens[0].value, ctx);
if (varData) {
dep.sharedVariableName = varData.key;
dep.currentValue = varData.value;
dep.managerData = {
fileReplacePosition: varData.fileReplacePosition,
packageFile: varData.packageFile,
};
}
}
ctx.deps.push(dep);
return ctx;
}