mirror of
https://github.com/renovatebot/renovate.git
synced 2026-10-31 01:37:24 +00:00
3412de84ce
* refactor(lint): enable oxlint prefer-named-capture-group at error Numbered capture groups (m[1], $1) break silently when a regex is edited and group order shifts. Named groups (?<name>...) make intent explicit and accesses (m.groups.name) resilient to reordering. This enables the built-in eslint rule prefer-named-capture-group, surfacing 321 pre-existing unnamed-group violations across ~121 files to be burned down incrementally in follow-up commits. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(versioning): name capture groups for prefer-named-capture-group Burns down all prefer-named-capture-group violations in lib/modules/versioning/. Unused capture groups (only reachable via .test() or whole-match) become non-capturing (?:...); groups whose value is read become named (?<name>...), with accesses rewritten to match.groups!.<name> (or destructured from .groups!) instead of positional match[n]/$n so a future edit that reorders groups cannot silently break the reader. Two cases needed extra care to preserve behavior: - semver/common.ts and poetry/patterns.ts split() on a regex whose capture group is relied upon by String.prototype.split to keep the separator in the output array; the group is kept capturing and named, not converted to non-capturing. - hashicorp/convertor.ts's semverRegex is only ever embedded via .source into a named `(?<version>...)` group elsewhere and never matched directly, so its internal groups are safe to make non-capturing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(datasource): name capture groups for prefer-named-capture-group Burns down all prefer-named-capture-group violations under lib/modules/datasource/. Same treatment as the versioning module: unused groups become non-capturing, used groups get names, and positional match[n] reads move to match.groups!.<name>. docker/ecr.ts and pypi/common.ts keep their positional destructuring (`const [, region] = ...`, `!!m &&`) working unchanged since a named capture group is still addressable by its numeric index in JavaScript — only pypi/common.ts's access was rewritten to m.groups!.owner for clarity since it read a single group directly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(platform): name capture groups for prefer-named-capture-group Burns down all prefer-named-capture-group violations under lib/modules/platform/. Uses the repo's established idiom of `match.groups?.<name>` after an optional-chained exec()/match() (see bitbucket/index.ts hostnameWithoutApiPrefix, gerrit/utils.ts extractSourceBranch) and `$<name>` in String.replace replacement strings. Unused groups (markdown/HTML massaging regexes matched only to be stripped) become non-capturing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(manager): name capture groups in ansible-galaxy for prefer-named-capture-group Burns down prefer-named-capture-group violations in lib/modules/manager/ansible-galaxy/. newBlockRegEx and blockLineRegEx dropped their unused outer wrapping group (only the inner key/value groups were ever read) and named the key/value groups; nameMatchRegex's remaining unused groups (protocol/user-info/port alternatives) become non-capturing since only source/hostname/depName/version are read via .groups. Accesses in collections.ts and roles.ts move from lineMatch[2]/lineMatch[3] to lineMatch.groups!.key/value. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(manager): name capture groups for prefer-named-capture-group (batch 1) Burns down prefer-named-capture-group violations across the first alphabetical slice of lib/modules/manager/ (ansible through mix). Used groups get names with accesses rewritten to match.groups!.<name> (or $<name> in replacement strings); groups whose value is never read become non-capturing (?:...). Two String.split() call sites (git-submodules/extract.ts, meteor/extract.ts) keep the established "named group still readable positionally from the split() result array" idiom instead of restructuring the destructuring. bazel/rules/go.ts and buildpacks/extract.ts dockerRef verified byte-for-byte equivalent before/after via a quick node script since several nested groups collapsed to non-capturing at once. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(manager): name capture groups for prefer-named-capture-group (batch 2) Burns down prefer-named-capture-group violations across the remaining alphabetical slice of lib/modules/manager/ (npm through terragrunt). Same treatment as batch 1: used groups get names with accesses moved to match.groups!.<name> or $<name> replacement strings; unused groups (wrapping alternations, quantifier repetition groups only consumed via .test(), or values never read from a match) become non-capturing. terraform/extractors/others/modules.ts and terragrunt/modules.ts share near-identical URL-parsing regexes (github/bitbucket/git/azure-devops ref matchers) — the same set of always-unused `depth=`/`&depth=` query-string groups is converted to non-capturing in both files. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(config): name capture groups for prefer-named-capture-group Burns down prefer-named-capture-group violations in lib/config/. Used groups get names with replacement strings switched from $1/$2 to $<name>; the unused separator group in schedule-migration.ts's afterBeforeRegex becomes non-capturing. presets/parse.ts keeps assigning through the already-declared `repo` variable rather than array-destructuring the exec() result, matching this file's existing style for the other named-group regexes just above it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(util): name capture groups for prefer-named-capture-group Burns down prefer-named-capture-group violations across lib/util/ and lib/logger/. Same treatment as previous batches: named groups for values that are read (via $<name> replacement strings, .groups!.<name>, or destructured from .groups), non-capturing groups where nothing reads the captured value (e.g. semantic.ts's angular-commit .test()-only regex). www-authenticate.ts's tokenizer entries each get their own named group but keep accessing the match generically via match[1], since a positionally-indexed named group is still readable by index. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(workers): name capture groups for prefer-named-capture-group Burns down prefer-named-capture-group violations in lib/workers/. Used groups get names with $<name> replacement strings; unused wrapper/alternation groups (e.g. semantic-commit-message.ts's optional scope/issue wrappers, release-notes.ts's date-heading and horizontal-rule matchers that are only probed with .search()/replaced wholesale) become non-capturing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(test,tools): name capture groups for prefer-named-capture-group Finishes the prefer-named-capture-group burndown: test/, tools/, and vitest.config.mts. Groups whose value is read get names ($<name> replacement strings or .groups.<name> access); groups only used via .test()/.search() or that feed a .match(/…/g) call (whose return value is the array of whole matches, not captured groups) become non-capturing. This is the last remaining slice of pre-existing violations, so the rule (already enabled at error repo-wide) now passes with zero findings across the whole codebase. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * fix prettier failure * refactor(lint): use a named capture group in `v8-ignore-no-count` New rule from main trips the newly enabled `prefer-named-capture-group` oxlint rule. --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
604 lines
19 KiB
TypeScript
604 lines
19 KiB
TypeScript
import { isString } from '@sindresorhus/is';
|
|
import semver from 'semver';
|
|
import { quote } from 'shlex';
|
|
import upath from 'upath';
|
|
import { GlobalConfig } from '../../../config/global.ts';
|
|
import { TEMPORARY_ERROR } from '../../../constants/error-messages.ts';
|
|
import { logger } from '../../../logger/index.ts';
|
|
import { coerceArray } from '../../../util/array.ts';
|
|
import { getEnv } from '../../../util/env.ts';
|
|
import type { ExecOptions } from '../../../util/exec/types.ts';
|
|
import { filterMap } from '../../../util/filter-map.ts';
|
|
import {
|
|
ensureCacheDir,
|
|
findLocalSiblingOrParent,
|
|
isValidLocalPath,
|
|
readLocalFile,
|
|
writeLocalFile,
|
|
} from '../../../util/fs/index.ts';
|
|
import { withGitEnvironment } from '../../../util/git/exec.ts';
|
|
import { getRepoStatus } from '../../../util/git/index.ts';
|
|
import { regEx } from '../../../util/regex.ts';
|
|
import { isValid } from '../../versioning/semver/index.ts';
|
|
import type {
|
|
PackageDependency,
|
|
UpdateArtifact,
|
|
UpdateArtifactsConfig,
|
|
UpdateArtifactsResult,
|
|
} from '../types.ts';
|
|
import { getExtraDepsNotice } from './artifacts-extra.ts';
|
|
import { getGoModulesInTidyOrder } from './package-tree.ts';
|
|
|
|
const { major, valid } = semver;
|
|
const gitExec = withGitEnvironment(['go']);
|
|
|
|
function getUpdateImportPathCmds(
|
|
updatedDeps: PackageDependency[],
|
|
{ constraints }: UpdateArtifactsConfig,
|
|
): string[] {
|
|
// Check if we fail to parse any major versions and log that they're skipped
|
|
const invalidMajorDeps = updatedDeps.filter(
|
|
({ newVersion }) => !valid(newVersion),
|
|
);
|
|
if (invalidMajorDeps.length > 0) {
|
|
invalidMajorDeps.forEach(({ depName }) =>
|
|
logger.warn(
|
|
{ depName },
|
|
'Ignoring dependency: Could not get major version',
|
|
),
|
|
);
|
|
}
|
|
|
|
const updateImportCommands = updatedDeps
|
|
.filter(
|
|
({ newVersion }) =>
|
|
valid(newVersion) && !newVersion!.endsWith('+incompatible'),
|
|
)
|
|
.map(({ depName, newVersion }) => ({
|
|
depName: depName!,
|
|
newMajor: major(newVersion!),
|
|
}))
|
|
// Skip path updates going from v0 to v1
|
|
.filter(
|
|
({ depName, newMajor }) =>
|
|
depName.startsWith('gopkg.in/') || newMajor > 1,
|
|
)
|
|
|
|
.map(
|
|
({ depName, newMajor }) =>
|
|
`mod upgrade --mod-name=${quote(depName)} -t=${newMajor}`,
|
|
);
|
|
|
|
if (updateImportCommands.length > 0) {
|
|
let installMarwanModArgs =
|
|
'install github.com/marwan-at-work/mod/cmd/mod@latest';
|
|
const gomodModCompatibility = constraints?.gomodMod;
|
|
if (gomodModCompatibility) {
|
|
if (
|
|
gomodModCompatibility.startsWith('v') &&
|
|
isValid(gomodModCompatibility.replace(regEx(/^v/), ''))
|
|
) {
|
|
installMarwanModArgs = installMarwanModArgs.replace(
|
|
regEx(/@latest$/),
|
|
`@${gomodModCompatibility}`,
|
|
);
|
|
} else {
|
|
logger.debug(
|
|
{ gomodModCompatibility },
|
|
'marwan-at-work/mod compatibility range is not valid - skipping',
|
|
);
|
|
}
|
|
} else {
|
|
logger.debug(
|
|
'No marwan-at-work/mod compatibility range found - installing marwan-at-work/mod latest',
|
|
);
|
|
}
|
|
updateImportCommands.unshift(`go ${installMarwanModArgs}`);
|
|
}
|
|
|
|
return updateImportCommands;
|
|
}
|
|
|
|
function useModcacherw(goVersion: string | undefined): boolean {
|
|
if (!isString(goVersion)) {
|
|
return true;
|
|
}
|
|
|
|
return semver.intersects(goVersion, `>=1.14`);
|
|
}
|
|
|
|
export async function updateArtifacts({
|
|
packageFileName: goModFileName,
|
|
updatedDeps,
|
|
newPackageFileContent: newGoModContent,
|
|
config,
|
|
}: UpdateArtifact): Promise<UpdateArtifactsResult[] | null> {
|
|
logger.debug(`gomod.updateArtifacts(${goModFileName})`);
|
|
|
|
const sumFileName = goModFileName.replace(regEx(/\.mod$/), '.sum');
|
|
const existingGoSumContent = await readLocalFile(sumFileName);
|
|
if (!existingGoSumContent) {
|
|
logger.debug('No go.sum found');
|
|
return null;
|
|
}
|
|
const goModDir = upath.dirname(goModFileName);
|
|
const goModFileBaseName = upath.basename(goModFileName);
|
|
const modFileFlag =
|
|
goModFileBaseName === 'go.mod'
|
|
? ''
|
|
: ` -modfile=${quote(goModFileBaseName)}`;
|
|
|
|
// The "vendor" directory can be next to the go.mod, but also in the parent directory in case
|
|
// the go workspaces are used.
|
|
const vendorDir = await findLocalSiblingOrParent(goModFileName, 'vendor');
|
|
const vendorModulesFileName = upath.join(vendorDir ?? '', 'modules.txt');
|
|
const useVendor =
|
|
!!config.postUpdateOptions?.includes('gomodVendor') ||
|
|
(!config.postUpdateOptions?.includes('gomodSkipVendor') &&
|
|
vendorDir &&
|
|
(await readLocalFile(vendorModulesFileName)) !== null);
|
|
let massagedGoMod = newGoModContent;
|
|
const useGoGenerate = !!config.postUpdateOptions?.includes('goGenerate');
|
|
const allowedUnsafeExecutions = GlobalConfig.get('allowedUnsafeExecutions');
|
|
const goGenerateAllowed = allowedUnsafeExecutions?.includes('goGenerate');
|
|
|
|
if (config.postUpdateOptions?.includes('gomodMassage')) {
|
|
// Regex match inline replace directive, example:
|
|
// replace golang.org/x/net v1.2.3 => example.com/fork/net v1.4.5
|
|
// https://go.dev/ref/mod#go-mod-file-replace
|
|
|
|
// replace bracket after comments, so it doesn't break the regex, doing a complex regex causes problems
|
|
// when there's a comment and ")" after it, the regex will read replace block until comment.. and stop.
|
|
massagedGoMod = massagedGoMod
|
|
.split('\n')
|
|
.map((line) => {
|
|
if (line.trim().startsWith('//')) {
|
|
return line.replace(')', 'renovate-replace-bracket');
|
|
}
|
|
return line;
|
|
})
|
|
.join('\n');
|
|
|
|
const inlineReplaceRegEx = regEx(
|
|
/(?<newline>\r?\n)(?<directive>replace\s+[^\s]+\s+=>\s+\.\.\/.*)/g,
|
|
);
|
|
|
|
// $<newline> will be matched with the (\r?\n) group
|
|
// $<directive> will be matched with the inline replace match, example
|
|
// "// renovate-replace replace golang.org/x/net v1.2.3 => example.com/fork/net v1.4.5"
|
|
const inlineCommentOut = '$<newline>// renovate-replace $<directive>';
|
|
|
|
// Regex match replace directive block, example:
|
|
// replace (
|
|
// golang.org/x/net v1.2.3 => example.com/fork/net v1.4.5
|
|
// )
|
|
const blockReplaceRegEx = regEx(/(?:\r?\n)replace\s*\([^)]+\s*\)/g);
|
|
|
|
/**
|
|
* replacerFunction for commenting out replace blocks
|
|
* @param match A string representing a golang replace directive block
|
|
* @returns A commented out block with // renovate-replace
|
|
*/
|
|
function blockCommentOut(match: string): string {
|
|
return match.replace(
|
|
regEx(/(?<newline>\r?\n)/g),
|
|
'$<newline>// renovate-replace ',
|
|
);
|
|
}
|
|
|
|
// Comment out golang replace directives
|
|
massagedGoMod = massagedGoMod
|
|
.replace(inlineReplaceRegEx, inlineCommentOut)
|
|
.replace(blockReplaceRegEx, blockCommentOut);
|
|
|
|
if (massagedGoMod !== newGoModContent) {
|
|
logger.debug(
|
|
'Removed some relative replace statements and comments from go.mod',
|
|
);
|
|
}
|
|
}
|
|
const goConstraints = deriveGoToolchainConstraints(config, newGoModContent);
|
|
|
|
try {
|
|
await writeLocalFile(goModFileName, massagedGoMod);
|
|
|
|
const cmd = 'go';
|
|
const env = getEnv();
|
|
const execOptions: ExecOptions = {
|
|
cwdFile: goModFileName,
|
|
extraEnv: {
|
|
GOPATH: await ensureCacheDir('go'),
|
|
GOPROXY: env.GOPROXY,
|
|
GOPRIVATE: env.GOPRIVATE,
|
|
GONOPROXY: env.GONOPROXY,
|
|
GONOSUMDB: env.GONOSUMDB,
|
|
GOSUMDB: env.GOSUMDB,
|
|
GOINSECURE: env.GOINSECURE,
|
|
/* v8 ignore next -- TODO: add test */
|
|
GOFLAGS: useModcacherw(goConstraints) ? '-modcacherw' : null,
|
|
CGO_ENABLED: GlobalConfig.get('binarySource') === 'docker' ? '0' : null,
|
|
},
|
|
docker: {},
|
|
toolConstraints: [
|
|
{
|
|
toolName: 'golang',
|
|
constraint: goConstraints,
|
|
},
|
|
],
|
|
};
|
|
|
|
const execCommands: string[] = [];
|
|
|
|
let goGetDirs: string | undefined;
|
|
if (config.goGetDirs) {
|
|
goGetDirs = config.goGetDirs
|
|
.filter((dir) => {
|
|
const isValid = isValidLocalPath(dir);
|
|
if (!isValid) {
|
|
logger.warn({ dir }, 'Invalid path in goGetDirs');
|
|
}
|
|
return isValid;
|
|
})
|
|
.map(quote)
|
|
.join(' ');
|
|
|
|
if (goGetDirs === '') {
|
|
throw new Error('Invalid goGetDirs');
|
|
}
|
|
}
|
|
|
|
let args = `get${modFileFlag} `;
|
|
|
|
if (goConstraints && !semver.intersects(goConstraints, `>=1.18`)) {
|
|
// For Go versions < 1.18, we need to use the -d flag to avoid builds or installs
|
|
// https://go.dev/doc/go1.18#go-get
|
|
args += `-d `;
|
|
}
|
|
|
|
args += `-t ${goGetDirs ?? './...'}`;
|
|
logger.trace({ cmd, args }, 'go get command included');
|
|
execCommands.push(`${cmd} ${args}`);
|
|
|
|
// Update import paths on major updates
|
|
const isImportPathUpdateRequired =
|
|
config.postUpdateOptions?.includes('gomodUpdateImportPaths') &&
|
|
config.updateType === 'major';
|
|
|
|
if (isImportPathUpdateRequired) {
|
|
const updateImportCmds = getUpdateImportPathCmds(updatedDeps, config);
|
|
if (updateImportCmds.length > 0) {
|
|
logger.debug(updateImportCmds, 'update import path commands included');
|
|
// The updates
|
|
execCommands.push(...updateImportCmds);
|
|
}
|
|
}
|
|
|
|
const mustSkipGoModTidy =
|
|
!config.postUpdateOptions?.includes('gomodUpdateImportPaths') &&
|
|
config.updateType === 'major';
|
|
if (mustSkipGoModTidy) {
|
|
logger.debug('go mod tidy command skipped');
|
|
}
|
|
|
|
let tidyOpts = '';
|
|
if (config.postUpdateOptions?.includes('gomodTidy1.17')) {
|
|
tidyOpts += ' -compat=1.17';
|
|
}
|
|
if (config.postUpdateOptions?.includes('gomodTidyE')) {
|
|
tidyOpts += ' -e';
|
|
}
|
|
|
|
// dependent modules can only be tidied once the updated module is settled
|
|
const isGoModTidyAllRequired =
|
|
config.postUpdateOptions?.includes('gomodTidyAll') === true;
|
|
const isGoModTidyRequired =
|
|
!mustSkipGoModTidy &&
|
|
(config.postUpdateOptions?.includes('gomodTidy') === true ||
|
|
config.postUpdateOptions?.includes('gomodTidy1.17') === true ||
|
|
config.postUpdateOptions?.includes('gomodTidyE') === true ||
|
|
isGoModTidyAllRequired ||
|
|
(config.updateType === 'major' && isImportPathUpdateRequired));
|
|
if (isGoModTidyRequired) {
|
|
args = `mod tidy${modFileFlag}${tidyOpts}`;
|
|
logger.debug('go mod tidy command included');
|
|
execCommands.push(`${cmd} ${args}`);
|
|
}
|
|
|
|
let goWorkSumFileName = upath.join(goModDir, 'go.work.sum');
|
|
if (useVendor) {
|
|
// If we find a go.work, then use go workspace vendoring.
|
|
const goWorkFile = await findLocalSiblingOrParent(
|
|
goModFileName,
|
|
'go.work',
|
|
);
|
|
|
|
if (goWorkFile) {
|
|
goWorkSumFileName = upath.join(
|
|
upath.dirname(goWorkFile),
|
|
'go.work.sum',
|
|
);
|
|
|
|
args = 'work vendor';
|
|
logger.debug('using go work vendor');
|
|
execCommands.push(`${cmd} ${args}`);
|
|
|
|
args = 'work sync';
|
|
logger.debug('using go work sync');
|
|
execCommands.push(`${cmd} ${args}`);
|
|
} else {
|
|
args = `mod vendor${modFileFlag}`;
|
|
logger.debug('using go mod vendor');
|
|
execCommands.push(`${cmd} ${args}`);
|
|
}
|
|
|
|
if (isGoModTidyRequired) {
|
|
args = `mod tidy${modFileFlag}${tidyOpts}`;
|
|
logger.debug('go mod tidy command included');
|
|
execCommands.push(`${cmd} ${args}`);
|
|
}
|
|
}
|
|
|
|
// We tidy one more time as a solution for #6795
|
|
if (isGoModTidyRequired) {
|
|
args = `mod tidy${modFileFlag}${tidyOpts}`;
|
|
logger.debug('go mod tidy command included');
|
|
execCommands.push(`${cmd} ${args}`);
|
|
}
|
|
|
|
let dependentModules: string[] = [];
|
|
if (isGoModTidyAllRequired) {
|
|
try {
|
|
dependentModules = await getGoModulesInTidyOrder(goModFileName);
|
|
for (const dependent of dependentModules) {
|
|
const dir = upath.relative(goModDir, upath.dirname(dependent));
|
|
execCommands.push(`${cmd} -C ${quote(dir)} mod tidy${tidyOpts}`);
|
|
}
|
|
logger.debug({ dependentModules }, 'go mod tidy commands included');
|
|
} catch (err) {
|
|
logger.warn({ err }, 'Failed to find dependent Go modules');
|
|
}
|
|
}
|
|
|
|
if (useGoGenerate) {
|
|
if (goGenerateAllowed) {
|
|
logger.debug('go generate command included');
|
|
execCommands.push(`${cmd} generate ./...`);
|
|
} else {
|
|
logger.once.warn(
|
|
`go generate command requested as a post update action, but goGenerate is not permitted in the allowedUnsafeExecutions`,
|
|
);
|
|
}
|
|
}
|
|
|
|
await gitExec(execCommands, execOptions);
|
|
|
|
const status = await getRepoStatus();
|
|
const dependentFiles = dependentModules.flatMap((f) => [
|
|
f,
|
|
f.replace(regEx(/\.mod$/), '.sum'),
|
|
]);
|
|
|
|
if (
|
|
!status.modified.includes(sumFileName) &&
|
|
!status.modified.includes(goModFileName) &&
|
|
!status.modified.includes(goWorkSumFileName) &&
|
|
!dependentFiles.some((f) => status.modified.includes(f))
|
|
) {
|
|
return null;
|
|
}
|
|
|
|
const res: UpdateArtifactsResult[] = [];
|
|
if (status.modified.includes(sumFileName)) {
|
|
logger.debug('Returning updated go.sum');
|
|
res.push({
|
|
file: {
|
|
type: 'addition',
|
|
path: sumFileName,
|
|
contents: await readLocalFile(sumFileName),
|
|
},
|
|
});
|
|
}
|
|
|
|
if (status.modified.includes(goWorkSumFileName)) {
|
|
logger.debug('Returning updated go.work.sum');
|
|
res.push({
|
|
file: {
|
|
type: 'addition',
|
|
path: goWorkSumFileName,
|
|
contents: await readLocalFile(goWorkSumFileName),
|
|
},
|
|
});
|
|
}
|
|
|
|
for (const f of dependentFiles) {
|
|
if (status.modified.includes(f)) {
|
|
logger.trace(`Returning updated ${f}`);
|
|
res.push({
|
|
file: {
|
|
type: 'addition',
|
|
path: f,
|
|
contents: await readLocalFile(f),
|
|
},
|
|
});
|
|
}
|
|
}
|
|
|
|
// Include all the .go file import changes
|
|
if (isImportPathUpdateRequired) {
|
|
logger.debug('Returning updated go source files for import path changes');
|
|
for (const f of status.modified) {
|
|
if (f.endsWith('.go')) {
|
|
res.push({
|
|
file: {
|
|
type: 'addition',
|
|
path: f,
|
|
contents: await readLocalFile(f),
|
|
},
|
|
});
|
|
}
|
|
}
|
|
}
|
|
|
|
const alreadyAdded = new Set<string>();
|
|
const alreadyDeleted = new Set<string>();
|
|
if (useVendor) {
|
|
for (const f of status.modified.concat(status.not_added)) {
|
|
if (vendorDir && f.startsWith(vendorDir)) {
|
|
alreadyAdded.add(f);
|
|
res.push({
|
|
file: {
|
|
type: 'addition',
|
|
path: f,
|
|
contents: await readLocalFile(f),
|
|
},
|
|
});
|
|
}
|
|
}
|
|
for (const f of coerceArray(status.deleted)) {
|
|
if (vendorDir && f.startsWith(vendorDir)) {
|
|
alreadyDeleted.add(f);
|
|
res.push({
|
|
file: {
|
|
type: 'deletion',
|
|
path: f,
|
|
},
|
|
});
|
|
}
|
|
}
|
|
}
|
|
|
|
// TODO: throws in tests (#22198)
|
|
const finalGoModContent = (await readLocalFile(goModFileName, 'utf8'))!
|
|
.replace(regEx(/\/\/ renovate-replace /g), '')
|
|
.replace(regEx(/renovate-replace-bracket/g), ')');
|
|
if (finalGoModContent !== newGoModContent) {
|
|
const artifactResult: UpdateArtifactsResult = {
|
|
file: {
|
|
type: 'addition',
|
|
path: goModFileName,
|
|
contents: finalGoModContent,
|
|
},
|
|
};
|
|
|
|
const updatedDepNames = filterMap(updatedDeps, (dep) => dep?.depName);
|
|
const extraDepsNotice = getExtraDepsNotice(
|
|
newGoModContent,
|
|
finalGoModContent,
|
|
updatedDepNames,
|
|
config,
|
|
);
|
|
|
|
if (extraDepsNotice) {
|
|
artifactResult.notice = {
|
|
file: goModFileName,
|
|
message: extraDepsNotice,
|
|
};
|
|
}
|
|
|
|
logger.debug('Found updated go.mod after go.sum update');
|
|
res.push(artifactResult);
|
|
alreadyAdded.add(goModFileName);
|
|
}
|
|
|
|
// add all files added when in `go generate` mode.
|
|
// unfortunately there is not a good way as there is with vendoring or go import path updates to detect this.
|
|
// Do this at the very very end to ensure we only capture files which would have been explicitly
|
|
// modified, added, or deleted from a `go generate` invocation
|
|
if (useGoGenerate && goGenerateAllowed) {
|
|
logger.debug(
|
|
'Updating all modified files since generated files were added',
|
|
);
|
|
for (const f of status.modified.concat(status.created)) {
|
|
if (!alreadyAdded.has(f)) {
|
|
res.push({
|
|
file: {
|
|
type: 'addition',
|
|
path: f,
|
|
contents: await readLocalFile(f),
|
|
},
|
|
});
|
|
}
|
|
}
|
|
for (const f of coerceArray(status.deleted)) {
|
|
if (!alreadyDeleted.has(f)) {
|
|
res.push({
|
|
file: {
|
|
type: 'deletion',
|
|
path: f,
|
|
},
|
|
});
|
|
}
|
|
}
|
|
}
|
|
return res;
|
|
} catch (err) {
|
|
if (err.message === TEMPORARY_ERROR) {
|
|
throw err;
|
|
}
|
|
logger.debug({ err }, 'Failed to update go.sum');
|
|
return [
|
|
{
|
|
artifactError: {
|
|
fileName: sumFileName,
|
|
stderr: err.message,
|
|
},
|
|
},
|
|
];
|
|
}
|
|
}
|
|
|
|
function getGoConstraints(content: string): string | undefined {
|
|
// prefer toolchain directive when go.mod has one
|
|
const toolchainMatch = regEx(/^toolchain\s*go(?<gover>\d+\.\d+\.\d+)$/m).exec(
|
|
content,
|
|
);
|
|
const toolchainVer = toolchainMatch?.groups?.gover;
|
|
if (toolchainVer) {
|
|
logger.debug(
|
|
`Using go version ${toolchainVer} found in toolchain directive`,
|
|
);
|
|
return toolchainVer;
|
|
}
|
|
|
|
// If go.mod doesn't have toolchain directive and has a full go version spec,
|
|
// for example `go 1.23.6`, pick this version, this doesn't match major.minor version spec.
|
|
//
|
|
// This is because when go.mod have same version defined in go directive and toolchain directive,
|
|
// go will remove toolchain directive from go.mod.
|
|
//
|
|
// For example, go will rewrite `go 1.23.5\ntoolchain go1.23.5` to `go 1.23.5` by default,
|
|
// in this case, the go directive is the toolchain directive.
|
|
const goFullVersion = regEx(/^go\s*(?<gover>\d+\.\d+\.\d+)$/m).exec(content)
|
|
?.groups?.gover;
|
|
if (goFullVersion) {
|
|
return goFullVersion;
|
|
}
|
|
|
|
const re = regEx(/^go\s*(?<gover>\d+\.\d+)$/m);
|
|
const match = re.exec(content);
|
|
if (!match?.groups?.gover) {
|
|
return undefined;
|
|
}
|
|
return `^${match.groups.gover}`;
|
|
}
|
|
|
|
/**
|
|
* Derive the version of the Go toolchain needed to run this project.
|
|
*
|
|
* This matches with the `golang` Containerbase tool.
|
|
*
|
|
* In precedence order:
|
|
*
|
|
* 1. config: \`constraints.go\`
|
|
* 1. \`go.mod\`: \`toolchain\` directive
|
|
* 1. \`go.mod\`: \`go\` directive
|
|
*
|
|
* NOTE that the \`constraints.golang\` is not used (TODO #42601)
|
|
*/
|
|
export function deriveGoToolchainConstraints(
|
|
config: UpdateArtifactsConfig,
|
|
newGoModContent: string,
|
|
): string | undefined {
|
|
return config.constraints?.go ?? getGoConstraints(newGoModContent);
|
|
}
|