mirror of
https://github.com/renovatebot/renovate.git
synced 2026-10-31 17:51:49 +00:00
58771bb183
* refactor(oxlint): enable func-style Enable the built-in func-style rule as ["warn", "declaration"] so that named functions are written as function declarations instead of arrow or function expressions assigned to variables, matching the convention in docs/development/best-practices.md (Functions section). Inline arrow callbacks are unaffected; prefer-arrow-callback continues to cover the callback direction. Severity is "warn" instead of "error" as a fallback: a repo-wide run found 196 pre-existing violations (70 in spec files, 126 in production code), exceeding the 80-violation fix threshold for this change, so no violations were fixed here. Follow-up work can convert the offenders (largest clusters: lib/modules/versioning/ruby, lib/util/cache/package, lib/modules/versioning/maven, lib/modules/versioning/gradle) and then raise the rule to "error". Note oxlint 1.72 also supports an allowTypeAnnotation option if typed consts should remain arrows. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * ci(linter): enforce func-style at error * refactor(func-style): convert const-arrow functions to declarations in with-cache spec and ruby versioning * refactor(func-style): convert const-arrow functions to declarations in maven/gradle modules * refactor(func-style): convert const-arrow functions to declarations in remaining versioning modules * refactor(func-style): convert const-arrow functions to declarations in platform modules Discriminated-union closures (ensureCommentRemoval byTopic/byContent helpers in github, gitlab, bitbucket, bitbucket-server) needed the narrowed field passed explicitly as a parameter, since function declarations are hoisted and lose the outer if-narrowing that inline arrow-function closures previously relied on. * refactor(func-style): convert const-arrow functions to declarations across util/manager/datasource modules One case (logger/renovate-logger.ts logOnceFn) is kept as an arrow function with a documented oxlint-disable: it is stored on this.logger.once[level] and relies on lexically-bound this, which a hoisted function declaration would not preserve. * refactor(func-style): convert remaining const-arrow test helpers to declarations get-updated.spec.ts: hoisted expectPipCompilePackageAndLockFile to module scope (it only closes over the module-level pipCompile mock) and added a documented oxlint-disable for vitest/expect-expect on its caller test, since oxlint's expect-expect check does not trace assertions through an externally-defined helper function. --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
353 lines
10 KiB
TypeScript
353 lines
10 KiB
TypeScript
import { isNonEmptyArray, isObject, isString } from '@sindresorhus/is';
|
|
import { dequal } from 'dequal';
|
|
import upath from 'upath';
|
|
import { logger } from '../../../logger/index.ts';
|
|
import { parseJsonc } from '../../../util/common.ts';
|
|
import { matchAt, replaceAt } from '../../../util/string.ts';
|
|
import { updateDependency as npmUpdateDependency } from '../npm/index.ts';
|
|
import type { UpdateDependencyConfig } from '../types.ts';
|
|
import { UpdateDenoJsonFile, UpdateImportMapJsonFile } from './schema.ts';
|
|
import type { DenoManagerData } from './types.ts';
|
|
|
|
function getValueByDatasource(
|
|
datasource: string,
|
|
depName: string,
|
|
currentValue?: string | null,
|
|
): string | null {
|
|
if (datasource === 'deno') {
|
|
return currentValue ? `${depName}@${currentValue}` : depName;
|
|
}
|
|
if (datasource === 'jsr' || datasource === 'npm') {
|
|
return currentValue
|
|
? `${datasource}:${depName}@${currentValue}`
|
|
: `${datasource}:${depName}`;
|
|
}
|
|
return null;
|
|
}
|
|
|
|
// ported from lib/modules/manager/npm/update/dependency/index.ts
|
|
function replaceAsString(
|
|
parsedContents: UpdateDenoJsonFile,
|
|
fileContent: string,
|
|
depType: string,
|
|
searchString: string,
|
|
newString: string,
|
|
): string {
|
|
// Skip ahead to depType section
|
|
let searchIndex = fileContent.indexOf(`"${depType}"`) + depType.length;
|
|
logger.trace(`Starting search at index ${searchIndex}`);
|
|
// Iterate through the rest of the file
|
|
for (; searchIndex < fileContent.length; searchIndex += 1) {
|
|
// First check if we have a hit for the old version
|
|
if (matchAt(fileContent, searchIndex, searchString)) {
|
|
logger.trace(`Found match at index ${searchIndex}`);
|
|
// Now test if the result matches
|
|
const testContent = replaceAt(
|
|
fileContent,
|
|
searchIndex,
|
|
searchString,
|
|
newString,
|
|
);
|
|
// Compare the parsed JSON/JSONC structure of old and new
|
|
if (dequal(parsedContents, parseJsonc(testContent))) {
|
|
return testContent;
|
|
}
|
|
}
|
|
}
|
|
throw new Error();
|
|
}
|
|
|
|
function updateImportMapLikeDepTypes(
|
|
parsedContents: UpdateDenoJsonFile,
|
|
fileContent: string,
|
|
depType: string,
|
|
searchString: string,
|
|
newString: string,
|
|
): string | null {
|
|
let newFileContent: string | null = null;
|
|
|
|
if (depType === 'imports' && parsedContents.imports) {
|
|
const matches = Object.entries(parsedContents.imports).filter(([, value]) =>
|
|
value.includes(searchString),
|
|
);
|
|
for (const [key] of matches) {
|
|
parsedContents.imports[key] = parsedContents.imports[key].replace(
|
|
searchString,
|
|
newString,
|
|
);
|
|
newFileContent = replaceAsString(
|
|
parsedContents,
|
|
fileContent,
|
|
depType,
|
|
searchString,
|
|
newString,
|
|
);
|
|
}
|
|
}
|
|
|
|
if (depType === 'scopes' && parsedContents.scopes) {
|
|
for (const scopeName of Object.keys(parsedContents.scopes)) {
|
|
const scope = parsedContents.scopes[scopeName];
|
|
const matches = Object.entries(scope).filter(([, value]) =>
|
|
value.includes(searchString),
|
|
);
|
|
for (const [key] of matches) {
|
|
parsedContents.scopes[scopeName][key] = parsedContents.scopes[
|
|
scopeName
|
|
][key].replace(searchString, newString);
|
|
newFileContent = replaceAsString(
|
|
parsedContents,
|
|
newFileContent ?? fileContent,
|
|
depType,
|
|
searchString,
|
|
newString,
|
|
);
|
|
}
|
|
}
|
|
}
|
|
|
|
return newFileContent;
|
|
}
|
|
|
|
export function updateDependency(
|
|
config: UpdateDependencyConfig<DenoManagerData>,
|
|
): string | null {
|
|
const { fileContent, packageFile, upgrade } = config;
|
|
const { depName, currentValue, newValue, datasource, managerData } = upgrade;
|
|
if (!packageFile) {
|
|
logger.debug('deno.updateDependency(): No package file found');
|
|
return null;
|
|
}
|
|
|
|
// <importMap>.json
|
|
if (managerData?.importMapReferrer) {
|
|
if (!depName || !newValue || !datasource || !upgrade.depType) {
|
|
logger.debug({ depName, currentValue, newValue }, 'Unknown value');
|
|
return null;
|
|
}
|
|
const depType = upgrade.depType;
|
|
logger.debug(
|
|
`deno.updateDependency(): ${packageFile}:${depType}.${depName} = ${newValue}`,
|
|
);
|
|
|
|
const parsedResult = UpdateImportMapJsonFile.safeParse(fileContent);
|
|
if (!parsedResult.success) {
|
|
logger.debug(
|
|
{ err: parsedResult.error },
|
|
`Invalid packageFile: ${packageFile} detected`,
|
|
);
|
|
return null;
|
|
}
|
|
const parsedContents = parsedResult.data;
|
|
|
|
const searchCurrentValue = getValueByDatasource(
|
|
datasource,
|
|
depName,
|
|
currentValue,
|
|
);
|
|
const newString = getValueByDatasource(datasource, depName, newValue);
|
|
if (!searchCurrentValue || !newString) {
|
|
logger.debug(
|
|
`deno.updateDependency(): "${datasource}" is not supported datasource`,
|
|
);
|
|
return null;
|
|
}
|
|
|
|
return updateImportMapLikeDepTypes(
|
|
parsedContents,
|
|
fileContent,
|
|
depType,
|
|
searchCurrentValue,
|
|
newString,
|
|
);
|
|
}
|
|
|
|
// deno.json/jsonc
|
|
if (upath.basename(packageFile).startsWith('deno.json')) {
|
|
if (!depName || !newValue || !datasource || !upgrade.depType) {
|
|
logger.debug({ depName, currentValue, newValue }, 'Unknown value');
|
|
return null;
|
|
}
|
|
const depType = upgrade.depType;
|
|
logger.debug(
|
|
`deno.updateDependency(): ${packageFile}:${depType}.${depName} = ${newValue}`,
|
|
);
|
|
|
|
const parsedResult = UpdateDenoJsonFile.safeParse(fileContent);
|
|
if (!parsedResult.success) {
|
|
logger.debug(
|
|
{ err: parsedResult.error },
|
|
`Invalid packageFile: ${packageFile} detected`,
|
|
);
|
|
return null;
|
|
}
|
|
const parsedContents = parsedResult.data;
|
|
|
|
let newFileContent: string | null = null;
|
|
|
|
const searchCurrentValue = getValueByDatasource(
|
|
datasource,
|
|
depName,
|
|
currentValue,
|
|
);
|
|
const newString = getValueByDatasource(datasource, depName, newValue);
|
|
if (!searchCurrentValue || !newString) {
|
|
logger.debug(
|
|
`deno.updateDependency(): "${datasource}" is not supported datasource`,
|
|
);
|
|
return null;
|
|
}
|
|
|
|
newFileContent = updateImportMapLikeDepTypes(
|
|
parsedContents,
|
|
fileContent,
|
|
depType,
|
|
searchCurrentValue,
|
|
newString,
|
|
);
|
|
|
|
if (depType === 'tasks' && parsedContents.tasks) {
|
|
const matches = Object.entries(parsedContents.tasks).flatMap(
|
|
([key, value]) =>
|
|
isString(value) && value.includes(searchCurrentValue)
|
|
? [[key, value]]
|
|
: [],
|
|
);
|
|
for (const [key, value] of matches) {
|
|
parsedContents.tasks[key] = value.replace(
|
|
searchCurrentValue,
|
|
newString,
|
|
);
|
|
newFileContent = replaceAsString(
|
|
parsedContents,
|
|
newFileContent ?? fileContent,
|
|
depType,
|
|
searchCurrentValue,
|
|
newString,
|
|
);
|
|
}
|
|
}
|
|
|
|
if (depType === 'tasks.command' && parsedContents.tasks) {
|
|
function hasCommandMatch(
|
|
value: unknown,
|
|
currentValue: string,
|
|
): value is { command: string } {
|
|
return (
|
|
isObject(value) &&
|
|
'command' in value &&
|
|
isString(value.command) &&
|
|
value.command.includes(currentValue)
|
|
);
|
|
}
|
|
|
|
const matches = Object.entries(parsedContents.tasks).filter(
|
|
(entry): entry is [string, { command: string }] =>
|
|
hasCommandMatch(entry[1], searchCurrentValue),
|
|
);
|
|
for (const [key, task] of matches) {
|
|
task.command = task.command.replace(searchCurrentValue, newString);
|
|
parsedContents.tasks[key] = task;
|
|
newFileContent = replaceAsString(
|
|
parsedContents,
|
|
newFileContent ?? fileContent,
|
|
depType,
|
|
searchCurrentValue,
|
|
newString,
|
|
);
|
|
}
|
|
}
|
|
|
|
if (
|
|
depType === 'compilerOptions.types' &&
|
|
isNonEmptyArray(parsedContents.compilerOptions?.types)
|
|
) {
|
|
const index = parsedContents.compilerOptions.types.findIndex(
|
|
(value: string) => value === searchCurrentValue,
|
|
);
|
|
if (index !== -1) {
|
|
parsedContents.compilerOptions.types[index] =
|
|
// prettier-ignore
|
|
parsedContents.compilerOptions.types[index].replace(searchCurrentValue, newString);
|
|
newFileContent = replaceAsString(
|
|
parsedContents,
|
|
newFileContent ?? fileContent,
|
|
depType,
|
|
searchCurrentValue,
|
|
newString,
|
|
);
|
|
}
|
|
}
|
|
|
|
if (
|
|
depType === 'compilerOptions.jsxImportSource' &&
|
|
parsedContents.compilerOptions?.jsxImportSource
|
|
) {
|
|
parsedContents.compilerOptions.jsxImportSource =
|
|
parsedContents.compilerOptions.jsxImportSource.replace(
|
|
searchCurrentValue,
|
|
newString,
|
|
);
|
|
newFileContent = replaceAsString(
|
|
parsedContents,
|
|
newFileContent ?? fileContent,
|
|
depType,
|
|
searchCurrentValue,
|
|
newString,
|
|
);
|
|
}
|
|
|
|
if (
|
|
depType === 'compilerOptions.jsxImportSourceTypes' &&
|
|
parsedContents.compilerOptions?.jsxImportSourceTypes
|
|
) {
|
|
parsedContents.compilerOptions.jsxImportSourceTypes =
|
|
parsedContents.compilerOptions.jsxImportSourceTypes.replace(
|
|
searchCurrentValue,
|
|
newString,
|
|
);
|
|
newFileContent = replaceAsString(
|
|
parsedContents,
|
|
newFileContent ?? fileContent,
|
|
depType,
|
|
searchCurrentValue,
|
|
newString,
|
|
);
|
|
}
|
|
|
|
if (
|
|
depType === 'lint.plugins' &&
|
|
isNonEmptyArray(parsedContents.lint?.plugins)
|
|
) {
|
|
const index = parsedContents.lint.plugins.findIndex(
|
|
(value: string) => value === searchCurrentValue,
|
|
);
|
|
if (index !== -1) {
|
|
parsedContents.lint.plugins[index] = parsedContents.lint.plugins[
|
|
index
|
|
].replace(searchCurrentValue, newString);
|
|
newFileContent = replaceAsString(
|
|
parsedContents,
|
|
newFileContent ?? fileContent,
|
|
depType,
|
|
searchCurrentValue,
|
|
newString,
|
|
);
|
|
}
|
|
}
|
|
|
|
if (newFileContent === fileContent) {
|
|
return fileContent;
|
|
}
|
|
return newFileContent;
|
|
}
|
|
|
|
// node-compat
|
|
if (upath.basename(packageFile) === 'package.json') {
|
|
return npmUpdateDependency(config);
|
|
}
|
|
|
|
logger.debug(`${packageFile} is not supported`);
|
|
return null;
|
|
}
|