mirror of
https://github.com/renovatebot/renovate.git
synced 2026-10-31 09:41:46 +00:00
16ef1715e9
* feat(lint): add renovate/prefer-is-helpers and renovate/prefer-is-object rules Flag ad-hoc type checks that have @sindresorhus/is equivalents: - .filter(Boolean) -> .filter(isTruthy) - typeof x === 'string' -> isString(x) - x === null || x === undefined -> isNullOrUndefined(x) (and negation) The typeof x === 'object' shape lives in a separate suggestion-only rule (renovate/prefer-is-object, kept at warn) because isObject()/isPlainObject() are not drop-in equivalents: null, arrays and functions behave differently. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor: fix renovate/prefer-is-helpers violations Replace ad-hoc type checks with @sindresorhus/is helpers across lib/: - 13x .filter(Boolean) -> .filter(isTruthy) - 36x typeof x ==/!== 'string' -> isString(x) / !isString(x) - 6x x === null || x === undefined -> isNullOrUndefined(x) (and negation) Promote renovate/prefer-is-helpers to error now that the codebase is clean. renovate/prefer-is-object stays at warn: its 15 remaining sites guard parsed YAML/JSON or unknown values where isObject()/isPlainObject() are not provably equivalent (null/array/function semantics). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor: enforce renovate/prefer-is-object at error level Resolve the 15 remaining warnings and raise the rule from warn to error: - Migrate 10 sites to isObject() where the guarded value provably cannot be a function (parsed YAML/JSON, typed exec command arguments, or test-controlled fixtures): helm-values, woodpecker, bun, pre-commit managers, exec utils, file package cache, and the github http spec. In the bun manager this also fixes a latent crash where a null `workspaces` value would throw on the `in` operator. - Keep 5 sites as reasoned oxlint-disable comments where excluding functions is load-bearing: the byte-exact fingerprint canonicalizer (2), the circularity walker, the zod result guard, and the generic hasKey helper. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
106 lines
3.2 KiB
TypeScript
106 lines
3.2 KiB
TypeScript
import { isArray, isObject, isString } from '@sindresorhus/is';
|
|
import { logger } from '../../../logger/index.ts';
|
|
import {
|
|
getParentDir,
|
|
getSiblingFileName,
|
|
readLocalFile,
|
|
} from '../../../util/fs/index.ts';
|
|
|
|
import { extractPackageJson } from '../npm/extract/common/package-file.ts';
|
|
import type { NpmPackage } from '../npm/extract/types.ts';
|
|
import { resolveNpmrc } from '../npm/npmrc.ts';
|
|
import type { NpmManagerData } from '../npm/types.ts';
|
|
import type { ExtractConfig, PackageFile } from '../types.ts';
|
|
import { filesMatchingWorkspaces } from './utils.ts';
|
|
|
|
function matchesFileName(fileNameWithPath: string, fileName: string): boolean {
|
|
return (
|
|
fileNameWithPath === fileName || fileNameWithPath.endsWith(`/${fileName}`)
|
|
);
|
|
}
|
|
|
|
export async function processPackageFile(
|
|
packageFile: string,
|
|
config: ExtractConfig,
|
|
): Promise<PackageFile | null> {
|
|
const fileContent = await readLocalFile(packageFile, 'utf8');
|
|
if (!fileContent) {
|
|
logger.warn({ fileName: packageFile }, 'Could not read file content');
|
|
return null;
|
|
}
|
|
let packageJson: NpmPackage;
|
|
try {
|
|
packageJson = JSON.parse(fileContent);
|
|
} catch (err) {
|
|
logger.debug({ err }, 'Error parsing package.json');
|
|
return null;
|
|
}
|
|
const result = extractPackageJson(packageJson, packageFile);
|
|
if (!result) {
|
|
logger.debug({ packageFile }, 'No dependencies found');
|
|
return null;
|
|
}
|
|
|
|
const { npmrc } = await resolveNpmrc(packageFile, config);
|
|
|
|
return {
|
|
...result,
|
|
packageFile,
|
|
npmrc,
|
|
};
|
|
}
|
|
export async function extractAllPackageFiles(
|
|
config: ExtractConfig,
|
|
matchedFiles: string[],
|
|
): Promise<PackageFile[]> {
|
|
const packageFiles: PackageFile<NpmManagerData>[] = [];
|
|
const allLockFiles = matchedFiles.filter(
|
|
(file) =>
|
|
matchesFileName(file, 'bun.lock') || matchesFileName(file, 'bun.lockb'),
|
|
);
|
|
if (allLockFiles.length === 0) {
|
|
logger.debug('No bun lockfiles found');
|
|
return packageFiles;
|
|
}
|
|
const allPackageJson = matchedFiles.filter((file) =>
|
|
matchesFileName(file, 'package.json'),
|
|
);
|
|
for (const lockFile of allLockFiles) {
|
|
const packageFile = getSiblingFileName(lockFile, 'package.json');
|
|
const res = await processPackageFile(packageFile, config);
|
|
if (res) {
|
|
packageFiles.push({ ...res, lockFiles: [lockFile] });
|
|
}
|
|
// Check if package.json contains workspaces
|
|
let workspaces = res?.managerData?.workspaces;
|
|
|
|
// Check for nested packages property https://bun.com/docs/pm/catalogs#1-define-catalogs-in-root-package-json
|
|
if (isObject(workspaces) && 'packages' in workspaces) {
|
|
workspaces = workspaces.packages;
|
|
}
|
|
|
|
if (!isArray(workspaces, isString)) {
|
|
continue;
|
|
}
|
|
|
|
logger.debug(`Found bun workspaces in ${packageFile}`);
|
|
const pwd = getParentDir(packageFile);
|
|
const workspacePackageFiles = filesMatchingWorkspaces(
|
|
pwd,
|
|
allPackageJson,
|
|
workspaces,
|
|
);
|
|
if (workspacePackageFiles.length) {
|
|
logger.debug({ workspacePackageFiles }, 'Found bun workspace files');
|
|
for (const workspaceFile of workspacePackageFiles) {
|
|
const res = await processPackageFile(workspaceFile, config);
|
|
if (res) {
|
|
packageFiles.push({ ...res, lockFiles: [lockFile] });
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
return packageFiles;
|
|
}
|