mirror of
https://github.com/renovatebot/renovate.git
synced 2026-10-31 09:41:46 +00:00
Sebastian Poxhofer
e0cec3dc95
feat(lint): add `types-location` rule and enable it for `lib/modules`
Reviewers consistently ask for exported types to be moved into a
colocated `types.ts`. Add a `renovate/types-location` oxlint rule that
reports `export interface` / `export type` declarations outside such a
file, and turn it on across `lib/modules`.
Re-exports (`export type { X }`, `export type *`), file-local types, and
values (enums, classes, functions) are left alone. `schema.ts` files and
`schema/` directories are excluded via config, matching how
`zod-schema-location` is configured — inferred types belong next to the
schema they are derived from.
Relocating the 87 existing violations means:
- new `types.ts` files for the modules that had none
- `terragrunt/common.ts` folded into its `types.ts`, as it held nothing
else
- `RangeBound` in `versioning/gradle/compare.ts` un-exported, since only
a file-local interface referenced it
- `bazel-module/parser/fragments.ts` split from its inferred types, which
now live in `parser/types.ts` and infer through a namespace import so
each schema keeps its merged name
31 lines
966 B
TypeScript
31 lines
966 B
TypeScript
import { codeBlock } from 'common-tags';
|
|
import { extractPackageFile, supportedDatasources } from './index.ts';
|
|
import type { StaticTooling } from './types.ts';
|
|
import { upgradeableTooling } from './upgradeable-tooling.ts';
|
|
|
|
describe('modules/manager/asdf/index', () => {
|
|
describe('supportedDatasources', () => {
|
|
const toolConfigs = [
|
|
...Object.values(upgradeableTooling)
|
|
.map((definition) => definition.config)
|
|
.filter((config): config is StaticTooling => 'datasource' in config),
|
|
...extractPackageFile(codeBlock`
|
|
java adoptopenjdk-16.0.0+36
|
|
java adoptopenjdk-jre-16.0.0+36
|
|
scala 2.0.0
|
|
scala 3.0.0
|
|
`)!.deps,
|
|
];
|
|
|
|
const usedDatasources = new Set(
|
|
toolConfigs.map((config) => config.datasource!),
|
|
);
|
|
|
|
for (const datasource of usedDatasources) {
|
|
it(`contains ${datasource}`, () => {
|
|
expect(supportedDatasources).toContain(datasource);
|
|
});
|
|
}
|
|
});
|
|
});
|