mirror of
https://github.com/renovatebot/renovate.git
synced 2026-11-01 02:00:10 +00:00
Sebastian Poxhofer
be13c9f5f7
* feat(manager): share OCI Helm chart resolution across managers Add getOciChartDep() to helmv3/oci.ts and use it in argocd, fleet, flux, helmfile, helmsman, helmv3, kustomize, sveltos, terraform and vendir. - set pinDigests: false for OCI charts in all of them - apply registryAliases to OCI charts in argocd, helmfile and helmsman - keep the registry port in terraform helm_release repositories - skip fleet OCI charts without a version instead of using 'undefined' * docs(manager/helmv3): correct the OCI chart pinDigests rationale * refactor(manager/helmfile): drop redundant OCI repository url guard The repository schema already requires url to be a string, so the falsy branch could not be reached by parsed input and left the patch partially covered.
328 lines
10 KiB
TypeScript
328 lines
10 KiB
TypeScript
import { codeBlock } from 'common-tags';
|
|
import { Fixtures } from '~test/fixtures.ts';
|
|
import { extractPackageFile } from './index.ts';
|
|
|
|
const validApplication = Fixtures.get('validApplication.yml');
|
|
const malformedApplication = Fixtures.get('malformedApplications.yml');
|
|
const randomManifest = Fixtures.get('randomManifest.yml');
|
|
const validApplicationSet = Fixtures.get('validApplicationSet.yml');
|
|
|
|
describe('modules/manager/argocd/extract', () => {
|
|
describe('extractPackageFile()', () => {
|
|
it('returns null for empty', () => {
|
|
expect(extractPackageFile('nothing here', 'applications.yml')).toBeNull();
|
|
});
|
|
|
|
it('returns null for invalid', () => {
|
|
expect(
|
|
extractPackageFile(`${malformedApplication}\n123`, 'applications.yml'),
|
|
).toBeNull();
|
|
});
|
|
|
|
it('return null for kubernetes manifest', () => {
|
|
const result = extractPackageFile(randomManifest, 'applications.yml');
|
|
expect(result).toBeNull();
|
|
});
|
|
|
|
it('return null if deps array would be empty', () => {
|
|
const result = extractPackageFile(
|
|
malformedApplication,
|
|
'applications.yml',
|
|
);
|
|
expect(result).toBeNull();
|
|
});
|
|
|
|
it('return result for double quoted argoproj.io apiVersion reference', () => {
|
|
const result = extractPackageFile(
|
|
`
|
|
apiVersion: "argoproj.io/v1alpha1"
|
|
kind: Application
|
|
spec:
|
|
source:
|
|
chart: kube-state-metrics
|
|
repoURL: https://prometheus-community.github.io/helm-charts
|
|
targetRevision: 2.4.1
|
|
`,
|
|
'applications.yml',
|
|
);
|
|
expect(result).toMatchObject({
|
|
deps: [
|
|
{
|
|
currentValue: '2.4.1',
|
|
datasource: 'helm',
|
|
depName: 'kube-state-metrics',
|
|
registryUrls: [
|
|
'https://prometheus-community.github.io/helm-charts',
|
|
],
|
|
},
|
|
],
|
|
});
|
|
});
|
|
|
|
it('return result for single quoted argoproj.io apiVersion reference', () => {
|
|
const result = extractPackageFile(
|
|
`
|
|
apiVersion: 'argoproj.io/v1alpha1'
|
|
kind: Application
|
|
spec:
|
|
source:
|
|
chart: kube-state-metrics
|
|
repoURL: https://prometheus-community.github.io/helm-charts
|
|
targetRevision: 2.4.1
|
|
`,
|
|
'applications.yml',
|
|
);
|
|
expect(result).toMatchObject({
|
|
deps: [
|
|
{
|
|
currentValue: '2.4.1',
|
|
datasource: 'helm',
|
|
depName: 'kube-state-metrics',
|
|
registryUrls: [
|
|
'https://prometheus-community.github.io/helm-charts',
|
|
],
|
|
},
|
|
],
|
|
});
|
|
});
|
|
|
|
it('resolves registryAliases for OCI charts', () => {
|
|
const result = extractPackageFile(
|
|
codeBlock`
|
|
apiVersion: argoproj.io/v1alpha1
|
|
kind: Application
|
|
metadata:
|
|
name: test
|
|
spec:
|
|
source:
|
|
chart: some/chart
|
|
repoURL: oci://registry.example.com/charts
|
|
targetRevision: 1.0.0
|
|
sources:
|
|
- repoURL: oci://registry.example.com/charts/other
|
|
targetRevision: 2.0.0
|
|
`,
|
|
'applications.yml',
|
|
{
|
|
registryAliases: {
|
|
'registry.example.com': 'registry-1.docker.io',
|
|
},
|
|
},
|
|
);
|
|
expect(result).toEqual({
|
|
deps: [
|
|
{
|
|
currentValue: '1.0.0',
|
|
datasource: 'docker',
|
|
depName: 'registry.example.com/charts/some/chart',
|
|
packageName: 'registry-1.docker.io/charts/some/chart',
|
|
pinDigests: false,
|
|
},
|
|
{
|
|
currentValue: '2.0.0',
|
|
datasource: 'docker',
|
|
depName: 'registry.example.com/charts/other',
|
|
packageName: 'registry-1.docker.io/charts/other',
|
|
pinDigests: false,
|
|
},
|
|
],
|
|
});
|
|
});
|
|
|
|
it('full test', () => {
|
|
const result = extractPackageFile(validApplication, 'applications.yml');
|
|
expect(result).toEqual({
|
|
deps: [
|
|
{
|
|
currentValue: '2.4.1',
|
|
datasource: 'helm',
|
|
depName: 'kube-state-metrics',
|
|
registryUrls: [
|
|
'https://prometheus-community.github.io/helm-charts',
|
|
],
|
|
},
|
|
{
|
|
currentValue: '0.0.2',
|
|
datasource: 'helm',
|
|
depName: 'traefik',
|
|
registryUrls: ['gs://helm-charts-internal'],
|
|
},
|
|
{
|
|
currentValue: 'v1.2.0',
|
|
datasource: 'git-tags',
|
|
depName: 'https://git.example.com/foo/bar.git',
|
|
},
|
|
{
|
|
autoReplaceStringTemplate:
|
|
'{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}',
|
|
currentValue: 'v2.3.4',
|
|
datasource: 'docker',
|
|
depName: 'somecontainer.registry.io/someContainer',
|
|
packageName: 'somecontainer.registry.io/someContainer',
|
|
replaceString: 'somecontainer.registry.io/someContainer:v2.3.4',
|
|
},
|
|
{
|
|
autoReplaceStringTemplate:
|
|
'{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}',
|
|
currentDigest:
|
|
'sha256:8be5de38826b494a8ad1565b8d1eb49183d736d0277a89191bd1100d78479a42',
|
|
datasource: 'docker',
|
|
depName: 'othercontainer.registry.io/other/container',
|
|
packageName: 'othercontainer.registry.io/other/container',
|
|
replaceString:
|
|
'othercontainer.registry.io/other/container@sha256:8be5de38826b494a8ad1565b8d1eb49183d736d0277a89191bd1100d78479a42',
|
|
},
|
|
{
|
|
currentValue: '1.2.0',
|
|
datasource: 'docker',
|
|
depName: 'somecontainer.registry.io/some/image',
|
|
packageName: 'somecontainer.registry.io/some/image',
|
|
pinDigests: false,
|
|
},
|
|
{
|
|
currentValue: '1.3.0',
|
|
datasource: 'docker',
|
|
depName: 'somecontainer.registry.io/some/image2',
|
|
packageName: 'somecontainer.registry.io/some/image2',
|
|
pinDigests: false,
|
|
},
|
|
{
|
|
currentValue: '1.3.0',
|
|
datasource: 'docker',
|
|
depName: 'somecontainer.registry.io:443/some/image2',
|
|
packageName: 'somecontainer.registry.io:443/some/image2',
|
|
pinDigests: false,
|
|
},
|
|
{
|
|
currentValue: '1.0.0',
|
|
datasource: 'docker',
|
|
depName: 'somecontainer.registry.io:443/some/image3',
|
|
packageName: 'somecontainer.registry.io:443/some/image3',
|
|
pinDigests: false,
|
|
},
|
|
{
|
|
currentValue: '1.0.0',
|
|
datasource: 'docker',
|
|
depName: 'somecontainer.registry.io:443/some/image3',
|
|
packageName: 'somecontainer.registry.io:443/some/image3',
|
|
pinDigests: false,
|
|
},
|
|
{
|
|
currentValue: 'v1.2.0',
|
|
datasource: 'git-tags',
|
|
depName: 'https://git.example.com/foo/bar.git',
|
|
},
|
|
{
|
|
currentValue: '1.0.0',
|
|
datasource: 'docker',
|
|
depName: 'somecontainer.registry.io:443/some/image3',
|
|
packageName: 'somecontainer.registry.io:443/some/image3',
|
|
pinDigests: false,
|
|
},
|
|
{
|
|
currentValue: 'v1.2.0',
|
|
datasource: 'git-tags',
|
|
depName: 'https://git.example.com/foo/bar.git',
|
|
},
|
|
{
|
|
currentValue: '0.0.2',
|
|
datasource: 'helm',
|
|
depName: 'traefik',
|
|
registryUrls: ['gs://helm-charts-internal'],
|
|
},
|
|
{
|
|
currentValue: 'v1.2.0',
|
|
datasource: 'git-tags',
|
|
depName: 'https://git.example.com/foo/bar.git',
|
|
},
|
|
{
|
|
currentValue: '0.0.2',
|
|
datasource: 'helm',
|
|
depName: 'somechart',
|
|
registryUrls: ['https://foo.io/repo'],
|
|
},
|
|
{
|
|
currentValue: '3.2.1',
|
|
datasource: 'helm',
|
|
depName: 'somechart',
|
|
registryUrls: ['https://git.example.com/foo/bar.git'],
|
|
},
|
|
{
|
|
currentValue: '0.4.0',
|
|
datasource: 'docker',
|
|
depName: 'somecontainer.registry.io/org/chart',
|
|
packageName: 'somecontainer.registry.io/org/chart',
|
|
pinDigests: false,
|
|
},
|
|
],
|
|
});
|
|
});
|
|
|
|
it('supports applicationsets', () => {
|
|
const result = extractPackageFile(
|
|
validApplicationSet,
|
|
'applicationsets.yml',
|
|
);
|
|
expect(result).toEqual({
|
|
deps: [
|
|
{
|
|
currentValue: '2.4.1',
|
|
datasource: 'helm',
|
|
depName: 'kube-state-metrics',
|
|
registryUrls: [
|
|
'https://prometheus-community.github.io/helm-charts',
|
|
],
|
|
},
|
|
{
|
|
currentValue: '10.14.2',
|
|
datasource: 'helm',
|
|
depName: 'traefik',
|
|
registryUrls: ['https://helm.traefik.io/traefik'],
|
|
},
|
|
{
|
|
currentValue: 'v1.2.0',
|
|
datasource: 'git-tags',
|
|
depName: 'https://git.example.com/foo/bar.git',
|
|
},
|
|
{
|
|
currentValue: '6.0.0',
|
|
datasource: 'helm',
|
|
depName: 'podinfo',
|
|
registryUrls: ['https://stefanprodan.github.io/podinfo'],
|
|
},
|
|
{
|
|
currentValue: '1.0.0',
|
|
datasource: 'docker',
|
|
depName: 'somecontainer.registry.io:443/some/image3',
|
|
packageName: 'somecontainer.registry.io:443/some/image3',
|
|
pinDigests: false,
|
|
},
|
|
{
|
|
currentValue: 'v1.2.0',
|
|
datasource: 'git-tags',
|
|
depName: 'https://git.example.com/foo/bar.git',
|
|
},
|
|
{
|
|
currentValue: '1.0.0',
|
|
datasource: 'docker',
|
|
depName: 'somecontainer.registry.io:443/some/image3',
|
|
packageName: 'somecontainer.registry.io:443/some/image3',
|
|
pinDigests: false,
|
|
},
|
|
{
|
|
currentValue: 'v1.2.0',
|
|
datasource: 'git-tags',
|
|
depName: 'https://git.example.com/foo/bar.git',
|
|
},
|
|
{
|
|
currentValue: '0.0.2',
|
|
datasource: 'helm',
|
|
depName: 'somechart',
|
|
registryUrls: ['https://foo.io/repo'],
|
|
},
|
|
],
|
|
});
|
|
});
|
|
});
|
|
});
|