Files
Sebastian Poxhofer 97327c3d28 refactor(linters): add prefer-coerce-array rule (#45492)
* refactor(linters): add prefer-coerce-array rule

Refs #45217

`x ?? []` and `coerceArray(x)` say the same thing, but only the second
one is searchable and consistent. The rule flags a `??` whose default is
a bare `[]` literal; a non-empty default or an asserted `([] as Foo[])`
still passes.

Applying it across `lib/` surfaced three spots the helper cannot cover,
which keep `?? []` with a disable comment or a narrower fix:

- `package-files.ts` destructures a tuple, which `coerceArray()` widens
- `generate.spec.ts` defaults `matchAll()`, an iterator rather than an array
- `mise/upgradeable-tooling.ts` declares a `Record` return, so its
  `?? []` fallback was wrong to begin with and becomes `coerceObject()`

* refactor(platform/github): hoist the GHE version header lookup

`Object.entries(...).find()` returns a tuple, and defaulting it with
`?? []` only to destructure the second element reads as an array
default when it is not one. Name the found entry instead, which drops
the `?? []` rather than routing a tuple through `coerceArray()`.
2026-08-28 09:27:58 +00:00

89 lines
2.5 KiB
TypeScript

import { coerceArray } from '../../../util/array.ts';
import { withCache } from '../../../util/cache/package/with-cache.ts';
import { joinUrlParts } from '../../../util/url.ts';
import * as glasskubeVersioning from '../../versioning/glasskube/index.ts';
import { Datasource } from '../datasource.ts';
import type { GetReleasesConfig, ReleaseResult } from '../types.ts';
import {
GlasskubePackageManifest,
GlasskubePackageVersions,
} from './schema.ts';
export class GlasskubePackagesDatasource extends Datasource {
static readonly id = 'glasskube-packages';
static readonly defaultRegistryUrl =
'https://packages.dl.glasskube.dev/packages';
override readonly customRegistrySupport = true;
override defaultVersioning = glasskubeVersioning.id;
override defaultRegistryUrls = [
GlasskubePackagesDatasource.defaultRegistryUrl,
];
constructor() {
super(GlasskubePackagesDatasource.id);
}
private async _getReleases({
packageName,
registryUrl,
}: GetReleasesConfig): Promise<ReleaseResult | null> {
const result: ReleaseResult = { releases: [] };
const { val: versions, err: versionsErr } = await this.http
.getYamlSafe(
joinUrlParts(registryUrl!, packageName, 'versions.yaml'),
GlasskubePackageVersions,
)
.unwrap();
if (versionsErr) {
this.handleGenericErrors(versionsErr);
}
result.releases = versions.versions.map((it) => ({
version: it.version,
}));
result.tags = { latest: versions.latestVersion };
const { val: latestManifest, err: latestManifestErr } = await this.http
.getYamlSafe(
joinUrlParts(
registryUrl!,
packageName,
versions.latestVersion,
'package.yaml',
),
GlasskubePackageManifest,
)
.unwrap();
if (latestManifestErr) {
this.handleGenericErrors(latestManifestErr);
}
for (const ref of coerceArray(latestManifest?.references)) {
if (ref.label.toLowerCase() === 'github') {
result.sourceUrl = ref.url;
} else if (ref.label.toLowerCase() === 'website') {
result.homepage = ref.url;
}
}
return result;
}
override getReleases(
config: GetReleasesConfig,
): Promise<ReleaseResult | null> {
return withCache(
{
namespace: `datasource-${GlasskubePackagesDatasource.id}`,
key: `${config.registryUrl}:${config.packageName}`,
fallback: true,
},
() => this._getReleases(config),
);
}
}