mirror of
https://github.com/renovatebot/renovate.git
synced 2026-11-02 02:29:51 +00:00
3412de84ce
* refactor(lint): enable oxlint prefer-named-capture-group at error Numbered capture groups (m[1], $1) break silently when a regex is edited and group order shifts. Named groups (?<name>...) make intent explicit and accesses (m.groups.name) resilient to reordering. This enables the built-in eslint rule prefer-named-capture-group, surfacing 321 pre-existing unnamed-group violations across ~121 files to be burned down incrementally in follow-up commits. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(versioning): name capture groups for prefer-named-capture-group Burns down all prefer-named-capture-group violations in lib/modules/versioning/. Unused capture groups (only reachable via .test() or whole-match) become non-capturing (?:...); groups whose value is read become named (?<name>...), with accesses rewritten to match.groups!.<name> (or destructured from .groups!) instead of positional match[n]/$n so a future edit that reorders groups cannot silently break the reader. Two cases needed extra care to preserve behavior: - semver/common.ts and poetry/patterns.ts split() on a regex whose capture group is relied upon by String.prototype.split to keep the separator in the output array; the group is kept capturing and named, not converted to non-capturing. - hashicorp/convertor.ts's semverRegex is only ever embedded via .source into a named `(?<version>...)` group elsewhere and never matched directly, so its internal groups are safe to make non-capturing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(datasource): name capture groups for prefer-named-capture-group Burns down all prefer-named-capture-group violations under lib/modules/datasource/. Same treatment as the versioning module: unused groups become non-capturing, used groups get names, and positional match[n] reads move to match.groups!.<name>. docker/ecr.ts and pypi/common.ts keep their positional destructuring (`const [, region] = ...`, `!!m &&`) working unchanged since a named capture group is still addressable by its numeric index in JavaScript — only pypi/common.ts's access was rewritten to m.groups!.owner for clarity since it read a single group directly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(platform): name capture groups for prefer-named-capture-group Burns down all prefer-named-capture-group violations under lib/modules/platform/. Uses the repo's established idiom of `match.groups?.<name>` after an optional-chained exec()/match() (see bitbucket/index.ts hostnameWithoutApiPrefix, gerrit/utils.ts extractSourceBranch) and `$<name>` in String.replace replacement strings. Unused groups (markdown/HTML massaging regexes matched only to be stripped) become non-capturing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(manager): name capture groups in ansible-galaxy for prefer-named-capture-group Burns down prefer-named-capture-group violations in lib/modules/manager/ansible-galaxy/. newBlockRegEx and blockLineRegEx dropped their unused outer wrapping group (only the inner key/value groups were ever read) and named the key/value groups; nameMatchRegex's remaining unused groups (protocol/user-info/port alternatives) become non-capturing since only source/hostname/depName/version are read via .groups. Accesses in collections.ts and roles.ts move from lineMatch[2]/lineMatch[3] to lineMatch.groups!.key/value. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(manager): name capture groups for prefer-named-capture-group (batch 1) Burns down prefer-named-capture-group violations across the first alphabetical slice of lib/modules/manager/ (ansible through mix). Used groups get names with accesses rewritten to match.groups!.<name> (or $<name> in replacement strings); groups whose value is never read become non-capturing (?:...). Two String.split() call sites (git-submodules/extract.ts, meteor/extract.ts) keep the established "named group still readable positionally from the split() result array" idiom instead of restructuring the destructuring. bazel/rules/go.ts and buildpacks/extract.ts dockerRef verified byte-for-byte equivalent before/after via a quick node script since several nested groups collapsed to non-capturing at once. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(manager): name capture groups for prefer-named-capture-group (batch 2) Burns down prefer-named-capture-group violations across the remaining alphabetical slice of lib/modules/manager/ (npm through terragrunt). Same treatment as batch 1: used groups get names with accesses moved to match.groups!.<name> or $<name> replacement strings; unused groups (wrapping alternations, quantifier repetition groups only consumed via .test(), or values never read from a match) become non-capturing. terraform/extractors/others/modules.ts and terragrunt/modules.ts share near-identical URL-parsing regexes (github/bitbucket/git/azure-devops ref matchers) — the same set of always-unused `depth=`/`&depth=` query-string groups is converted to non-capturing in both files. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(config): name capture groups for prefer-named-capture-group Burns down prefer-named-capture-group violations in lib/config/. Used groups get names with replacement strings switched from $1/$2 to $<name>; the unused separator group in schedule-migration.ts's afterBeforeRegex becomes non-capturing. presets/parse.ts keeps assigning through the already-declared `repo` variable rather than array-destructuring the exec() result, matching this file's existing style for the other named-group regexes just above it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(util): name capture groups for prefer-named-capture-group Burns down prefer-named-capture-group violations across lib/util/ and lib/logger/. Same treatment as previous batches: named groups for values that are read (via $<name> replacement strings, .groups!.<name>, or destructured from .groups), non-capturing groups where nothing reads the captured value (e.g. semantic.ts's angular-commit .test()-only regex). www-authenticate.ts's tokenizer entries each get their own named group but keep accessing the match generically via match[1], since a positionally-indexed named group is still readable by index. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(workers): name capture groups for prefer-named-capture-group Burns down prefer-named-capture-group violations in lib/workers/. Used groups get names with $<name> replacement strings; unused wrapper/alternation groups (e.g. semantic-commit-message.ts's optional scope/issue wrappers, release-notes.ts's date-heading and horizontal-rule matchers that are only probed with .search()/replaced wholesale) become non-capturing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(test,tools): name capture groups for prefer-named-capture-group Finishes the prefer-named-capture-group burndown: test/, tools/, and vitest.config.mts. Groups whose value is read get names ($<name> replacement strings or .groups.<name> access); groups only used via .test()/.search() or that feed a .match(/…/g) call (whose return value is the array of whole matches, not captured groups) become non-capturing. This is the last remaining slice of pre-existing violations, so the rule (already enabled at error repo-wide) now passes with zero findings across the whole codebase. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * fix prettier failure * refactor(lint): use a named capture group in `v8-ignore-no-count` New rule from main trips the newly enabled `prefer-named-capture-group` oxlint rule. --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
152 lines
4.6 KiB
TypeScript
152 lines
4.6 KiB
TypeScript
import { isNullOrUndefined } from '@sindresorhus/is';
|
|
import pMap from 'p-map';
|
|
import { logger } from '../../../logger/index.ts';
|
|
import * as packageCache from '../../../util/cache/package/index.ts';
|
|
import { withCache } from '../../../util/cache/package/with-cache.ts';
|
|
import { coerceObject } from '../../../util/object.ts';
|
|
import { regEx } from '../../../util/regex.ts';
|
|
import { joinUrlParts } from '../../../util/url.ts';
|
|
import * as semanticVersioning from '../../versioning/semver/index.ts';
|
|
import { Datasource } from '../datasource.ts';
|
|
import type { Release } from '../index.ts';
|
|
import type { GetReleasesConfig, ReleaseResult } from '../types.ts';
|
|
import {
|
|
DenoAPIModuleResponse,
|
|
DenoAPIModuleVersionResponse,
|
|
} from './schema.ts';
|
|
|
|
export class DenoDatasource extends Datasource {
|
|
static readonly id = 'deno';
|
|
|
|
override readonly customRegistrySupport = true;
|
|
|
|
override readonly registryStrategy = 'first';
|
|
|
|
override readonly defaultVersioning = semanticVersioning.id;
|
|
|
|
override readonly defaultRegistryUrls = ['https://apiland.deno.dev'];
|
|
|
|
override readonly releaseTimestampSupport = true;
|
|
override readonly releaseTimestampNote =
|
|
'The release timestamp is determined from the `uploaded_at` field in the results.';
|
|
override readonly sourceUrlSupport = 'release';
|
|
override readonly sourceUrlNote =
|
|
'The source URL is determined from the `repository` field in the results.';
|
|
|
|
constructor() {
|
|
super(DenoDatasource.id);
|
|
}
|
|
|
|
private async _getReleases({
|
|
packageName,
|
|
registryUrl,
|
|
}: GetReleasesConfig): Promise<ReleaseResult | null> {
|
|
const massagedRegistryUrl = registryUrl!;
|
|
|
|
const extractResult = regEx(
|
|
/^(?:https:\/\/deno.land\/)(?<rawPackageName>[^@\s]+)/,
|
|
).exec(packageName);
|
|
const rawPackageName = extractResult?.groups?.rawPackageName;
|
|
if (isNullOrUndefined(rawPackageName)) {
|
|
logger.debug(
|
|
`Could not extract rawPackageName from packageName: "${packageName}"`,
|
|
);
|
|
return null;
|
|
}
|
|
|
|
// remove third-party prefix if defined. The only internal library is `std` and is available under the same API
|
|
const massagedPackageName = rawPackageName.replace('x/', '');
|
|
|
|
// https://apiland.deno.dev/v2/modules/postgres
|
|
const moduleAPIURL = joinUrlParts(
|
|
massagedRegistryUrl,
|
|
'v2/modules',
|
|
massagedPackageName,
|
|
);
|
|
|
|
return await this.getReleaseResult(moduleAPIURL);
|
|
}
|
|
|
|
getReleases(config: GetReleasesConfig): Promise<ReleaseResult | null> {
|
|
return withCache(
|
|
{
|
|
namespace: `datasource-${DenoDatasource.id}`,
|
|
// TODO: types (#22198)
|
|
key: `getReleases:${config.registryUrl}:${config.packageName}`,
|
|
fallback: true,
|
|
},
|
|
() => this._getReleases(config),
|
|
);
|
|
}
|
|
|
|
private async _getReleaseResult(
|
|
moduleAPIURL: string,
|
|
): Promise<ReleaseResult> {
|
|
const detailsCacheKey = `details:${moduleAPIURL}`;
|
|
const releasesCache: Record<string, Release> = coerceObject(
|
|
await packageCache.get(
|
|
`datasource-${DenoDatasource.id}`,
|
|
detailsCacheKey,
|
|
),
|
|
);
|
|
let cacheModified = false;
|
|
|
|
const {
|
|
body: { versions, tags },
|
|
} = await this.http.getJson(moduleAPIURL, DenoAPIModuleResponse);
|
|
|
|
// get details for the versions
|
|
const releases = await pMap(
|
|
versions,
|
|
async (version) => {
|
|
const cacheRelease = releasesCache[version];
|
|
/* v8 ignore next: hard to test */
|
|
if (cacheRelease) {
|
|
return cacheRelease;
|
|
}
|
|
|
|
// https://apiland.deno.dev/v2/modules/postgres/v0.17.0
|
|
const url = joinUrlParts(moduleAPIURL, version);
|
|
const { body: release } = await this.http.getJson(
|
|
url,
|
|
DenoAPIModuleVersionResponse.catch(({ error: err }) => {
|
|
logger.warn(
|
|
{ err, version },
|
|
'Deno: failed to get version details',
|
|
);
|
|
return { version };
|
|
}),
|
|
);
|
|
|
|
releasesCache[release.version] = release;
|
|
cacheModified = true;
|
|
|
|
return release;
|
|
},
|
|
{ concurrency: 5 },
|
|
);
|
|
|
|
if (cacheModified) {
|
|
// 1 week. Releases at Deno are immutable, therefore we can use a long term cache here.
|
|
await packageCache.set(
|
|
`datasource-${DenoDatasource.id}`,
|
|
detailsCacheKey,
|
|
releasesCache,
|
|
10080,
|
|
);
|
|
}
|
|
|
|
return { releases, tags };
|
|
}
|
|
|
|
getReleaseResult(moduleAPIURL: string): Promise<ReleaseResult> {
|
|
return withCache(
|
|
{
|
|
namespace: `datasource-${DenoDatasource.id}`,
|
|
key: `getReleaseResult:${moduleAPIURL}`,
|
|
},
|
|
() => this._getReleaseResult(moduleAPIURL),
|
|
);
|
|
}
|
|
}
|