Files
Sebastian Poxhofer a473e73b3e fix(linters): forbid inert counts in v8 coverage-ignore comments (#45287)
Adds a custom oxlint rule renovate/v8-ignore-no-count that flags the
count form '/* v8 ignore next <N> */'. The count is not honored by
vitest's ast-v8-to-istanbul hint parser, which captures only the
keyword (if/else/next/file); 'next' always exempts exactly the next
AST node. Trailing counts therefore suggest a line range that is never
applied and mislead readers.

The rule is autofixable (drops the count, preserving actual behavior)
and has been applied to all existing occurrences.
2026-08-22 11:25:31 +00:00

94 lines
2.9 KiB
TypeScript

import { isString } from '@sindresorhus/is';
import { regEx } from '../../../util/regex.ts';
import { Datasource } from '../datasource.ts';
import type { GetReleasesConfig, Release, ReleaseResult } from '../types.ts';
import { DartResponse } from './schema.ts';
export const stableVersionRegex = regEx(/^\d+\.\d+\.\d+$/);
/**
* The server returns old svn versions which would need mapping to a version.
* They are very old, so we skip them instead.
* https://github.com/dart-lang/site-www/blob/7d4409c87bb6570b2d8870b20283f81f2b7e08fc/tool/get-dart/dart_sdk_archive/lib/src/svn_versions.dart#L2
*/
export const svnVersionRegex = regEx(/^\d+$/);
export class DartVersionDatasource extends Datasource {
static readonly id = 'dart-version';
constructor() {
super(DartVersionDatasource.id);
}
override readonly customRegistrySupport = false;
override readonly defaultRegistryUrls = ['https://storage.googleapis.com'];
override readonly caching = true;
private readonly channels = ['stable', 'beta', 'dev'];
override readonly sourceUrlSupport = 'package';
override readonly sourceUrlNote =
'We use the URL: https://github.com/dart-lang/sdk.';
async getReleases({
registryUrl,
}: GetReleasesConfig): Promise<ReleaseResult | null> {
/* v8 ignore next -- should never happen */
if (!registryUrl) {
return null;
}
const result: ReleaseResult = {
homepage: 'https://dart.dev/',
sourceUrl: 'https://github.com/dart-lang/sdk',
registryUrl,
releases: [],
};
try {
for (const channel of this.channels) {
const resp = (
await this.http.getJson(
`${registryUrl}/storage/v1/b/dart-archive/o?delimiter=%2F&prefix=channels%2F${channel}%2Frelease%2F&alt=json`,
DartResponse,
)
).body;
const releases = this.getReleasesFromResponse(channel, resp.prefixes);
result.releases.push(...releases);
}
} catch (err) {
this.handleGenericErrors(err);
}
return result.releases.length ? result : null;
}
private getReleasesFromResponse(
channel: string,
prefixes: string[],
): Release[] {
return prefixes
.map((prefix) => this.getVersionFromPrefix(prefix))
.filter(isString)
.filter((version) => {
if (
version === 'latest' ||
// skip old svn versions
svnVersionRegex.test(version) ||
// The API response contains a stable version being released as a non-stable
// release. So we filter out these releases here.
(channel !== 'stable' && stableVersionRegex.test(version))
) {
return false;
}
return true;
})
.map((version) => ({ version, isStable: channel === 'stable' }));
}
// Prefix should have a format of "channels/stable/release/2.9.3/"
private getVersionFromPrefix(prefix: string): string | undefined {
const parts = prefix.split('/');
return parts.at(-2);
}
}