mirror of
https://github.com/renovatebot/renovate.git
synced 2026-11-01 02:00:10 +00:00
Sebastian Poxhofer
97327c3d28
* refactor(linters): add prefer-coerce-array rule Refs #45217 `x ?? []` and `coerceArray(x)` say the same thing, but only the second one is searchable and consistent. The rule flags a `??` whose default is a bare `[]` literal; a non-empty default or an asserted `([] as Foo[])` still passes. Applying it across `lib/` surfaced three spots the helper cannot cover, which keep `?? []` with a disable comment or a narrower fix: - `package-files.ts` destructures a tuple, which `coerceArray()` widens - `generate.spec.ts` defaults `matchAll()`, an iterator rather than an array - `mise/upgradeable-tooling.ts` declares a `Record` return, so its `?? []` fallback was wrong to begin with and becomes `coerceObject()` * refactor(platform/github): hoist the GHE version header lookup `Object.entries(...).find()` returns a tuple, and defaulting it with `?? []` only to destructure the second element reads as an array default when it is not one. Name the found entry instead, which drops the `?? []` rather than routing a tuple through `coerceArray()`.
52 lines
1.5 KiB
TypeScript
52 lines
1.5 KiB
TypeScript
import {
|
|
DescribeDBEngineVersionsCommand,
|
|
RDSClient,
|
|
} from '@aws-sdk/client-rds';
|
|
import { coerceArray } from '../../../util/array.ts';
|
|
import { withCache } from '../../../util/cache/package/with-cache.ts';
|
|
import { Lazy } from '../../../util/lazy.ts';
|
|
import { Datasource } from '../datasource.ts';
|
|
import type { GetReleasesConfig, ReleaseResult } from '../types.ts';
|
|
|
|
export class AwsRdsDatasource extends Datasource {
|
|
static readonly id = 'aws-rds';
|
|
|
|
override readonly caching = true;
|
|
|
|
private readonly rds: Lazy<RDSClient>;
|
|
|
|
constructor() {
|
|
super(AwsRdsDatasource.id);
|
|
this.rds = new Lazy(() => new RDSClient({}));
|
|
}
|
|
|
|
private async _getReleases({
|
|
packageName: serializedFilter,
|
|
}: GetReleasesConfig): Promise<ReleaseResult | null> {
|
|
const cmd = new DescribeDBEngineVersionsCommand({
|
|
Filters: JSON.parse(serializedFilter),
|
|
});
|
|
const response = await this.rds.getValue().send(cmd);
|
|
const versions = coerceArray(response.DBEngineVersions);
|
|
return {
|
|
releases: versions
|
|
.filter((version) => version.EngineVersion)
|
|
.map((version) => ({
|
|
version: version.EngineVersion!,
|
|
isDeprecated: version.Status === 'deprecated',
|
|
})),
|
|
};
|
|
}
|
|
|
|
getReleases(config: GetReleasesConfig): Promise<ReleaseResult | null> {
|
|
return withCache(
|
|
{
|
|
namespace: `datasource-${AwsRdsDatasource.id}`,
|
|
key: `getReleases:${config.packageName}`,
|
|
fallback: true,
|
|
},
|
|
() => this._getReleases(config),
|
|
);
|
|
}
|
|
}
|