Files
Sebastian Poxhofer 9717259ffc refactor(oxlint): enable no-else-return and unicorn/no-lonely-if (#44553)
Enable no-else-return (with allowElseIf: false) and unicorn/no-lonely-if
as errors in .oxlintrc.json and fix all 131 pre-existing violations
(91 no-else-return, 40 unicorn/no-lonely-if) across 98 files.

The no-else-return violations were fixed with the oxlint autofix
(iterated to a fixpoint, plus two else-if chains that required
--fix-dangerously) followed by Prettier formatting. One comment dropped
by the autofix in lib/modules/manager/pub/artifacts.ts was restored
manually. The unicorn/no-lonely-if violations were merged by hand,
preserving comments and coverage-ignore hints.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-14 12:11:21 +00:00

118 lines
3.4 KiB
TypeScript

import { logger } from '../../../logger/index.ts';
import { withCache } from '../../../util/cache/package/with-cache.ts';
import { parse } from '../../../util/html.ts';
import { HttpError } from '../../../util/http/index.ts';
import { regEx } from '../../../util/regex.ts';
import { asTimestamp } from '../../../util/timestamp.ts';
import { joinUrlParts } from '../../../util/url.ts';
import { Datasource } from '../datasource.ts';
import type { GetReleasesConfig, Release, ReleaseResult } from '../types.ts';
import { datasource } from './common.ts';
export class ArtifactoryDatasource extends Datasource {
static readonly id = datasource;
constructor() {
super(datasource);
}
override readonly customRegistrySupport = true;
override readonly caching = true;
override readonly registryStrategy = 'merge';
override readonly releaseTimestampSupport = true;
override readonly releaseTimestampNote =
'The release timestamp is determined from the date-like text, next to the version hyperlink tag in the results.';
private async _getReleases({
packageName,
registryUrl,
}: GetReleasesConfig): Promise<ReleaseResult | null> {
if (!registryUrl) {
logger.warn(
{ packageName },
'artifactory datasource requires custom registryUrl. Skipping datasource',
);
return null;
}
const url = joinUrlParts(registryUrl, packageName);
const result: ReleaseResult = {
releases: [],
};
try {
const response = await this.http.getText(url);
const body = parse(response.body, {
blockTextElements: {
script: true,
noscript: true,
style: true,
},
});
const nodes = body.querySelectorAll('a');
nodes
.filter(
// filter out hyperlink to navigate to parent folder
(node) => node.innerHTML !== '../' && node.innerHTML !== '..',
)
.forEach(
// extract version and published time for each node
(node) => {
const version: string = node.innerHTML.endsWith('/')
? node.innerHTML.slice(0, -1)
: node.innerHTML;
const releaseTimestamp = asTimestamp(
node.nextSibling?.text?.trimStart()?.split(regEx(/\s{2,}/))?.[0],
);
const thisRelease: Release = {
version,
releaseTimestamp,
};
result.releases.push(thisRelease);
},
);
if (result.releases.length) {
logger.trace(
{ registryUrl, packageName, versions: result.releases.length },
'artifactory: Found versions',
);
} else {
logger.trace(
{ registryUrl, packageName },
'artifactory: No versions found',
);
}
} catch (err) {
if (err instanceof HttpError && err.response?.statusCode === 404) {
logger.warn(
{ registryUrl, packageName },
'artifactory: `Not Found` error',
);
return null;
}
this.handleGenericErrors(err);
}
return result.releases.length ? result : null;
}
getReleases(config: GetReleasesConfig): Promise<ReleaseResult | null> {
return withCache(
{
namespace: `datasource-${datasource}`,
key: `${config.registryUrl}:${config.packageName}`,
fallback: true,
},
() => this._getReleases(config),
);
}
}