mirror of
https://github.com/renovatebot/renovate.git
synced 2026-11-07 12:40:49 +00:00
Sebastian Poxhofer
97327c3d28
* refactor(linters): add prefer-coerce-array rule Refs #45217 `x ?? []` and `coerceArray(x)` say the same thing, but only the second one is searchable and consistent. The rule flags a `??` whose default is a bare `[]` literal; a non-empty default or an asserted `([] as Foo[])` still passes. Applying it across `lib/` surfaced three spots the helper cannot cover, which keep `?? []` with a disable comment or a narrower fix: - `package-files.ts` destructures a tuple, which `coerceArray()` widens - `generate.spec.ts` defaults `matchAll()`, an iterator rather than an array - `mise/upgradeable-tooling.ts` declares a `Record` return, so its `?? []` fallback was wrong to begin with and becomes `coerceObject()` * refactor(platform/github): hoist the GHE version header lookup `Object.entries(...).find()` returns a tuple, and defaulting it with `?? []` only to destructure the second element reads as an array default when it is not one. Name the found entry instead, which drops the `?? []` rather than routing a tuple through `coerceArray()`.
46 lines
1.5 KiB
TypeScript
46 lines
1.5 KiB
TypeScript
import { isArray, isNonEmptyObject, isString } from '@sindresorhus/is';
|
|
import { coerceArray } from '../../../util/array.ts';
|
|
import type { PackageRule } from '../../types.ts';
|
|
import { AbstractMigration } from '../base/abstract-migration.ts';
|
|
|
|
export class PackageFilesMigration extends AbstractMigration {
|
|
override readonly deprecated = true;
|
|
override readonly propertyName = 'packageFiles';
|
|
|
|
override run(value: unknown): void {
|
|
const packageRules: PackageRule[] = coerceArray(this.get('packageRules'));
|
|
// v8 ignore else -- TODO: add test #40625
|
|
if (isArray(value)) {
|
|
const fileList: string[] = [];
|
|
for (const packageFile of value) {
|
|
// v8 ignore else -- TODO: add test #40625
|
|
if (
|
|
isNonEmptyObject(packageFile) &&
|
|
'packageFile' in packageFile &&
|
|
isString(packageFile.packageFile)
|
|
) {
|
|
fileList.push(packageFile.packageFile);
|
|
packageFile.paths = [packageFile.packageFile];
|
|
delete packageFile.packageFile;
|
|
|
|
if (Object.keys(packageFile).length > 1) {
|
|
packageRules.push({
|
|
...packageFile,
|
|
});
|
|
}
|
|
} else if (isArray(packageFile, isString)) {
|
|
fileList.push(...packageFile);
|
|
} else if (isString(packageFile)) {
|
|
fileList.push(packageFile);
|
|
}
|
|
}
|
|
if (fileList.length) {
|
|
this.setSafely('includePaths', fileList);
|
|
}
|
|
if (packageRules.length) {
|
|
this.setSafely('packageRules', packageRules);
|
|
}
|
|
}
|
|
}
|
|
}
|