mirror of
https://github.com/renovatebot/renovate.git
synced 2026-11-02 02:29:51 +00:00
Sebastian Poxhofer
97327c3d28
* refactor(linters): add prefer-coerce-array rule Refs #45217 `x ?? []` and `coerceArray(x)` say the same thing, but only the second one is searchable and consistent. The rule flags a `??` whose default is a bare `[]` literal; a non-empty default or an asserted `([] as Foo[])` still passes. Applying it across `lib/` surfaced three spots the helper cannot cover, which keep `?? []` with a disable comment or a narrower fix: - `package-files.ts` destructures a tuple, which `coerceArray()` widens - `generate.spec.ts` defaults `matchAll()`, an iterator rather than an array - `mise/upgradeable-tooling.ts` declares a `Record` return, so its `?? []` fallback was wrong to begin with and becomes `coerceObject()` * refactor(platform/github): hoist the GHE version header lookup `Object.entries(...).find()` returns a tuple, and defaulting it with `?? []` only to destructure the second element reads as an array default when it is not one. Name the found entry instead, which drops the `?? []` rather than routing a tuple through `coerceArray()`.
23 lines
792 B
TypeScript
23 lines
792 B
TypeScript
import { isArray, isString } from '@sindresorhus/is';
|
|
import { coerceArray } from '../../../util/array.ts';
|
|
import { AbstractMigration } from '../base/abstract-migration.ts';
|
|
|
|
export class FileMatchMigration extends AbstractMigration {
|
|
override readonly deprecated = true;
|
|
override readonly propertyName = 'fileMatch';
|
|
|
|
override run(value: unknown): void {
|
|
// v8 ignore else -- TODO: add test #40625
|
|
if (isString(value) || isArray(value, isString)) {
|
|
const fileMatch = isArray(value) ? value : [value];
|
|
|
|
let managerFilePatterns = coerceArray(this.get('managerFilePatterns'));
|
|
managerFilePatterns = managerFilePatterns.concat(
|
|
fileMatch.map((match) => `/${match}/`),
|
|
);
|
|
|
|
this.setHard('managerFilePatterns', managerFilePatterns);
|
|
}
|
|
}
|
|
}
|