mirror of
https://github.com/renovatebot/renovate.git
synced 2026-10-24 22:48:06 +00:00
Sebastian Poxhofer
97327c3d28
* refactor(linters): add prefer-coerce-array rule Refs #45217 `x ?? []` and `coerceArray(x)` say the same thing, but only the second one is searchable and consistent. The rule flags a `??` whose default is a bare `[]` literal; a non-empty default or an asserted `([] as Foo[])` still passes. Applying it across `lib/` surfaced three spots the helper cannot cover, which keep `?? []` with a disable comment or a narrower fix: - `package-files.ts` destructures a tuple, which `coerceArray()` widens - `generate.spec.ts` defaults `matchAll()`, an iterator rather than an array - `mise/upgradeable-tooling.ts` declares a `Record` return, so its `?? []` fallback was wrong to begin with and becomes `coerceObject()` * refactor(platform/github): hoist the GHE version header lookup `Object.entries(...).find()` returns a tuple, and defaulting it with `?? []` only to destructure the second element reads as an array default when it is not one. Name the found entry instead, which drops the `?? []` rather than routing a tuple through `coerceArray()`.
69 lines
2.2 KiB
TypeScript
69 lines
2.2 KiB
TypeScript
import { isNonEmptyString, isNullOrUndefined } from '@sindresorhus/is';
|
|
import type { CustomDatasourceConfig } from '../../../config/types.ts';
|
|
import { logger } from '../../../logger/index.ts';
|
|
import { coerceArray } from '../../../util/array.ts';
|
|
import * as template from '../../../util/template/index.ts';
|
|
import type { GetReleasesConfig } from '../types.ts';
|
|
|
|
export function massageCustomDatasourceConfig(
|
|
customDatasourceName: string,
|
|
{
|
|
customDatasources,
|
|
packageName,
|
|
currentValue,
|
|
registryUrl: defaultRegistryUrl,
|
|
}: GetReleasesConfig,
|
|
): Required<CustomDatasourceConfig> | null {
|
|
const customDatasource = customDatasources?.[customDatasourceName];
|
|
if (isNullOrUndefined(customDatasource)) {
|
|
logger.debug(
|
|
`No custom datasource config provided while ${packageName} has been requested`,
|
|
);
|
|
return null;
|
|
}
|
|
const templateInput = { packageName, currentValue };
|
|
|
|
const registryUrlTemplate =
|
|
defaultRegistryUrl ?? customDatasource.defaultRegistryUrlTemplate;
|
|
if (isNullOrUndefined(registryUrlTemplate)) {
|
|
logger.debug(
|
|
'No registry url provided by extraction nor datasource configuration',
|
|
);
|
|
return null;
|
|
}
|
|
const registryUrl = template.compile(registryUrlTemplate, templateInput);
|
|
|
|
const transformTemplates = coerceArray(customDatasource.transformTemplates);
|
|
const transform: string[] = [];
|
|
for (const transformTemplate of transformTemplates) {
|
|
const templated = template.compile(transformTemplate, templateInput);
|
|
transform.push(templated);
|
|
}
|
|
|
|
logger.trace({ transform }, `Custom datasource compiled data.`);
|
|
|
|
return {
|
|
format: customDatasource.format ?? 'json',
|
|
defaultRegistryUrlTemplate: registryUrl,
|
|
transformTemplates: transform,
|
|
};
|
|
}
|
|
|
|
export function getCustomConfig(
|
|
getReleasesConfig: GetReleasesConfig,
|
|
): Required<CustomDatasourceConfig> | null {
|
|
const customDatasourceName = getReleasesConfig.datasource?.replace(
|
|
'custom.',
|
|
'',
|
|
);
|
|
|
|
if (!isNonEmptyString(customDatasourceName)) {
|
|
logger.debug(
|
|
`No datasource has been supplied while looking up ${getReleasesConfig.packageName}`,
|
|
);
|
|
return null;
|
|
}
|
|
|
|
return massageCustomDatasourceConfig(customDatasourceName, getReleasesConfig);
|
|
}
|