mirror of
https://github.com/renovatebot/renovate.git
synced 2026-10-25 15:01:49 +00:00
3412de84ce
* refactor(lint): enable oxlint prefer-named-capture-group at error Numbered capture groups (m[1], $1) break silently when a regex is edited and group order shifts. Named groups (?<name>...) make intent explicit and accesses (m.groups.name) resilient to reordering. This enables the built-in eslint rule prefer-named-capture-group, surfacing 321 pre-existing unnamed-group violations across ~121 files to be burned down incrementally in follow-up commits. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(versioning): name capture groups for prefer-named-capture-group Burns down all prefer-named-capture-group violations in lib/modules/versioning/. Unused capture groups (only reachable via .test() or whole-match) become non-capturing (?:...); groups whose value is read become named (?<name>...), with accesses rewritten to match.groups!.<name> (or destructured from .groups!) instead of positional match[n]/$n so a future edit that reorders groups cannot silently break the reader. Two cases needed extra care to preserve behavior: - semver/common.ts and poetry/patterns.ts split() on a regex whose capture group is relied upon by String.prototype.split to keep the separator in the output array; the group is kept capturing and named, not converted to non-capturing. - hashicorp/convertor.ts's semverRegex is only ever embedded via .source into a named `(?<version>...)` group elsewhere and never matched directly, so its internal groups are safe to make non-capturing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(datasource): name capture groups for prefer-named-capture-group Burns down all prefer-named-capture-group violations under lib/modules/datasource/. Same treatment as the versioning module: unused groups become non-capturing, used groups get names, and positional match[n] reads move to match.groups!.<name>. docker/ecr.ts and pypi/common.ts keep their positional destructuring (`const [, region] = ...`, `!!m &&`) working unchanged since a named capture group is still addressable by its numeric index in JavaScript — only pypi/common.ts's access was rewritten to m.groups!.owner for clarity since it read a single group directly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(platform): name capture groups for prefer-named-capture-group Burns down all prefer-named-capture-group violations under lib/modules/platform/. Uses the repo's established idiom of `match.groups?.<name>` after an optional-chained exec()/match() (see bitbucket/index.ts hostnameWithoutApiPrefix, gerrit/utils.ts extractSourceBranch) and `$<name>` in String.replace replacement strings. Unused groups (markdown/HTML massaging regexes matched only to be stripped) become non-capturing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(manager): name capture groups in ansible-galaxy for prefer-named-capture-group Burns down prefer-named-capture-group violations in lib/modules/manager/ansible-galaxy/. newBlockRegEx and blockLineRegEx dropped their unused outer wrapping group (only the inner key/value groups were ever read) and named the key/value groups; nameMatchRegex's remaining unused groups (protocol/user-info/port alternatives) become non-capturing since only source/hostname/depName/version are read via .groups. Accesses in collections.ts and roles.ts move from lineMatch[2]/lineMatch[3] to lineMatch.groups!.key/value. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(manager): name capture groups for prefer-named-capture-group (batch 1) Burns down prefer-named-capture-group violations across the first alphabetical slice of lib/modules/manager/ (ansible through mix). Used groups get names with accesses rewritten to match.groups!.<name> (or $<name> in replacement strings); groups whose value is never read become non-capturing (?:...). Two String.split() call sites (git-submodules/extract.ts, meteor/extract.ts) keep the established "named group still readable positionally from the split() result array" idiom instead of restructuring the destructuring. bazel/rules/go.ts and buildpacks/extract.ts dockerRef verified byte-for-byte equivalent before/after via a quick node script since several nested groups collapsed to non-capturing at once. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(manager): name capture groups for prefer-named-capture-group (batch 2) Burns down prefer-named-capture-group violations across the remaining alphabetical slice of lib/modules/manager/ (npm through terragrunt). Same treatment as batch 1: used groups get names with accesses moved to match.groups!.<name> or $<name> replacement strings; unused groups (wrapping alternations, quantifier repetition groups only consumed via .test(), or values never read from a match) become non-capturing. terraform/extractors/others/modules.ts and terragrunt/modules.ts share near-identical URL-parsing regexes (github/bitbucket/git/azure-devops ref matchers) — the same set of always-unused `depth=`/`&depth=` query-string groups is converted to non-capturing in both files. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(config): name capture groups for prefer-named-capture-group Burns down prefer-named-capture-group violations in lib/config/. Used groups get names with replacement strings switched from $1/$2 to $<name>; the unused separator group in schedule-migration.ts's afterBeforeRegex becomes non-capturing. presets/parse.ts keeps assigning through the already-declared `repo` variable rather than array-destructuring the exec() result, matching this file's existing style for the other named-group regexes just above it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(util): name capture groups for prefer-named-capture-group Burns down prefer-named-capture-group violations across lib/util/ and lib/logger/. Same treatment as previous batches: named groups for values that are read (via $<name> replacement strings, .groups!.<name>, or destructured from .groups), non-capturing groups where nothing reads the captured value (e.g. semantic.ts's angular-commit .test()-only regex). www-authenticate.ts's tokenizer entries each get their own named group but keep accessing the match generically via match[1], since a positionally-indexed named group is still readable by index. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(workers): name capture groups for prefer-named-capture-group Burns down prefer-named-capture-group violations in lib/workers/. Used groups get names with $<name> replacement strings; unused wrapper/alternation groups (e.g. semantic-commit-message.ts's optional scope/issue wrappers, release-notes.ts's date-heading and horizontal-rule matchers that are only probed with .search()/replaced wholesale) become non-capturing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(test,tools): name capture groups for prefer-named-capture-group Finishes the prefer-named-capture-group burndown: test/, tools/, and vitest.config.mts. Groups whose value is read get names ($<name> replacement strings or .groups.<name> access); groups only used via .test()/.search() or that feed a .match(/…/g) call (whose return value is the array of whole matches, not captured groups) become non-capturing. This is the last remaining slice of pre-existing violations, so the rule (already enabled at error repo-wide) now passes with zero findings across the whole codebase. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * fix prettier failure * refactor(lint): use a named capture group in `v8-ignore-no-count` New rule from main trips the newly enabled `prefer-named-capture-group` oxlint rule. --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
402 lines
9.2 KiB
TypeScript
402 lines
9.2 KiB
TypeScript
import { isUndefined } from '@sindresorhus/is';
|
|
import type { SemVer } from 'semver';
|
|
import semver from 'semver';
|
|
import { logger } from '../../../logger/index.ts';
|
|
import { regEx } from '../../../util/regex.ts';
|
|
import type { NewValueConfig, VersioningApi } from '../types.ts';
|
|
|
|
export const id = 'github-actions';
|
|
export const displayName = 'GitHub Actions';
|
|
export const urls = [
|
|
'[GitHub Actions - Using release management for custom actions](https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/find-and-customize-actions#using-release-management-for-your-custom-actions)',
|
|
];
|
|
export const supportsRanges = true;
|
|
export const supportedRangeStrategies = ['pin', 'replace'];
|
|
|
|
const floatingMinorTagRegex = regEx(/^\d+(?:\.\d+)?$/);
|
|
const majorOnlyRegex = regEx(/^\d+$/);
|
|
|
|
function massageValue(input: string): string {
|
|
return input.trim().replace(regEx(/^v/i), '');
|
|
}
|
|
|
|
function parseVersion(input: string): SemVer | null {
|
|
const stripped = massageValue(input);
|
|
const v = semver.parse(stripped);
|
|
if (v) {
|
|
return v;
|
|
}
|
|
// Handle major.minor-prerelease format (e.g. v2.2-rc.1) by normalizing to major.minor.0-prerelease
|
|
return semver.parse(
|
|
stripped.replace(
|
|
regEx(/^(?<majorMinor>\d+\.\d+)(?<prerelease>-.+)$/),
|
|
'$<majorMinor>.0$<prerelease>',
|
|
),
|
|
);
|
|
}
|
|
|
|
interface Range {
|
|
major: number;
|
|
minor?: number;
|
|
}
|
|
|
|
function parseRange(input: string): Range | null {
|
|
const stripped = massageValue(input);
|
|
if (!floatingMinorTagRegex.test(stripped)) {
|
|
return null;
|
|
}
|
|
const coerced = semver.coerce(stripped);
|
|
/* v8 ignore if -- unreachable: floatingMinorTagRegex should guarantee coerce() succeeds */
|
|
if (!coerced) {
|
|
return null;
|
|
}
|
|
const { major, minor } = coerced;
|
|
|
|
if (majorOnlyRegex.test(stripped)) {
|
|
return { major };
|
|
}
|
|
|
|
return { major, minor };
|
|
}
|
|
|
|
/*
|
|
* Like parseVersion but also accepts floating tags (e.g. `v1`, `v1.2`)
|
|
* by coercing them to full semver.
|
|
*/
|
|
function parseVersionCoerced(input: string): SemVer | null {
|
|
const v = parseVersion(input);
|
|
if (v) {
|
|
return v;
|
|
}
|
|
const stripped = massageValue(input);
|
|
if (!regEx(/^\d/).test(stripped)) {
|
|
return null;
|
|
}
|
|
return semver.coerce(stripped);
|
|
}
|
|
|
|
function isValid(input: string): boolean {
|
|
return !!parseVersion(input) || !!parseRange(input);
|
|
}
|
|
|
|
function isVersion(input: string | undefined | null): boolean {
|
|
if (!input) {
|
|
return false;
|
|
}
|
|
|
|
if (parseVersion(input)) {
|
|
return true;
|
|
}
|
|
|
|
const stripped = massageValue(input);
|
|
if (!regEx(/^\d/).test(stripped)) {
|
|
return false;
|
|
}
|
|
|
|
return parseRange(input) !== null;
|
|
}
|
|
|
|
function isStable(version: string): boolean {
|
|
const v = parseVersionCoerced(version);
|
|
if (!v) {
|
|
return false;
|
|
}
|
|
|
|
return v.prerelease.length === 0;
|
|
}
|
|
|
|
function isSingleVersion(input: string): boolean {
|
|
return !!parseVersion(input);
|
|
}
|
|
|
|
function getMajor(version: string): number | null {
|
|
return parseVersionCoerced(version)?.major ?? null;
|
|
}
|
|
|
|
function getMinor(version: string): number | null {
|
|
return parseVersionCoerced(version)?.minor ?? null;
|
|
}
|
|
|
|
function getPatch(version: string): number | null {
|
|
return parseVersionCoerced(version)?.patch ?? null;
|
|
}
|
|
|
|
function sortVersions(x: string, y: string): number {
|
|
const a = parseVersionCoerced(x);
|
|
const b = parseVersionCoerced(y);
|
|
if (!a || !b) {
|
|
return 0;
|
|
}
|
|
const cmp = semver.compare(a, b);
|
|
if (cmp === 0) {
|
|
return x.localeCompare(y, undefined, { numeric: true });
|
|
}
|
|
return cmp;
|
|
}
|
|
|
|
function equals(x: string, y: string): boolean {
|
|
const a = parseVersionCoerced(x);
|
|
const b = parseVersionCoerced(y);
|
|
if (!a || !b) {
|
|
return false;
|
|
}
|
|
return semver.eq(a, b);
|
|
}
|
|
|
|
function isGreaterThan(x: string, y: string): boolean {
|
|
const a = parseVersionCoerced(x);
|
|
const b = parseVersionCoerced(y);
|
|
if (!a || !b) {
|
|
return false;
|
|
}
|
|
return semver.gt(a, b);
|
|
}
|
|
|
|
function matches(version: string, range: string): boolean {
|
|
// if we have a valid floating tag provided, and it's the same as the range, treat it as the same
|
|
if (
|
|
parseVersionCoerced(version) &&
|
|
massageValue(version) === massageValue(range)
|
|
) {
|
|
return true;
|
|
}
|
|
|
|
const v = parseVersion(version);
|
|
if (!v) {
|
|
return false;
|
|
}
|
|
|
|
const rv = parseVersion(range);
|
|
if (rv) {
|
|
return semver.eq(v, rv);
|
|
}
|
|
|
|
const r = parseRange(range);
|
|
if (!r) {
|
|
return false;
|
|
}
|
|
|
|
if (v.prerelease.length > 0) {
|
|
return false;
|
|
}
|
|
|
|
if (v.major !== r.major) {
|
|
return false;
|
|
}
|
|
|
|
if (isUndefined(r.minor)) {
|
|
return true;
|
|
}
|
|
|
|
return v.minor === r.minor;
|
|
}
|
|
|
|
function getSatisfyingVersion(
|
|
versions: string[],
|
|
range: string,
|
|
): string | null {
|
|
const sortedVersions = versions.sort(sortVersions).reverse();
|
|
for (const version of sortedVersions) {
|
|
if (matches(version, range)) {
|
|
return version;
|
|
}
|
|
}
|
|
return null;
|
|
}
|
|
|
|
function minSatisfyingVersion(
|
|
versions: string[],
|
|
range: string,
|
|
): string | null {
|
|
const sortedVersions = versions.sort(sortVersions);
|
|
for (const version of sortedVersions) {
|
|
if (matches(version, range)) {
|
|
return version;
|
|
}
|
|
}
|
|
return null;
|
|
}
|
|
|
|
function isLessThanRange(version: string, range: string): boolean {
|
|
const v = parseVersionCoerced(version);
|
|
const r = parseRange(range);
|
|
|
|
if (!v || !r) {
|
|
return false;
|
|
}
|
|
|
|
if (v.major !== r.major) {
|
|
return v.major < r.major;
|
|
}
|
|
|
|
if (isUndefined(r.minor)) {
|
|
return false;
|
|
}
|
|
|
|
if (v.minor !== r.minor) {
|
|
return v.minor < r.minor;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
function getNewValue({
|
|
currentValue,
|
|
currentVersion,
|
|
rangeStrategy,
|
|
newVersion,
|
|
allVersions,
|
|
}: NewValueConfig): string | null {
|
|
if (rangeStrategy === 'pin') {
|
|
return newVersion;
|
|
}
|
|
|
|
const range = parseRange(currentValue);
|
|
if (!range) {
|
|
return newVersion;
|
|
}
|
|
|
|
// When a minor (i.e. `v1.2`), don't return a less-specific tag (i.e. `v1`), even if it's found in `allVersions`
|
|
const minLevel = isUndefined(range.minor) ? 'major' : 'minor';
|
|
const [prefix] = currentValue.split(massageValue(currentValue));
|
|
const newParsed = parseVersion(newVersion);
|
|
if (!newParsed) {
|
|
const newCoerced = parseVersionCoerced(newVersion);
|
|
if (newCoerced) {
|
|
// check that we're not returning a version that doesn't exist
|
|
// for instance, in the case `v5.5` is tagged, but there's no `v5` (or if it's been deleted)
|
|
const shortest = getShortestMatchingVersion(
|
|
prefix,
|
|
newCoerced,
|
|
allVersions ?? new Set(),
|
|
minLevel,
|
|
);
|
|
if (shortest) {
|
|
return shortest;
|
|
}
|
|
}
|
|
return newVersion;
|
|
}
|
|
|
|
// Check if currentValue is a full version (has patch component)
|
|
const currentParsed = parseVersion(currentValue);
|
|
// v8 ignore if -- currentValue can't fail both parseRange and parseVersion
|
|
if (currentParsed) {
|
|
// currentValue is a full version, return full newVersion
|
|
return newVersion;
|
|
}
|
|
|
|
if (isUndefined(allVersions) || allVersions.size === 0) {
|
|
if (isUndefined(range.minor)) {
|
|
return `${prefix}${newParsed.major}`;
|
|
}
|
|
|
|
return `${prefix}${newParsed.major}.${newParsed.minor}`;
|
|
}
|
|
|
|
// If a major (i.e. `v7`), and the proposed update is a minor i.e. (`v7.6`), return the existing major version instead of updating to the new minor, as the major should have been re-tagged, too
|
|
if (isUndefined(range.minor) && newParsed.major === range.major) {
|
|
return `${prefix}${newParsed.major}`;
|
|
}
|
|
|
|
const shortest = getShortestMatchingVersion(
|
|
prefix,
|
|
newParsed,
|
|
allVersions,
|
|
minLevel,
|
|
);
|
|
if (shortest) {
|
|
return shortest;
|
|
}
|
|
|
|
logger.once.debug(
|
|
{
|
|
versioning: id,
|
|
currentValue,
|
|
currentVersion,
|
|
newVersion,
|
|
rangeStrategy,
|
|
allVersions,
|
|
},
|
|
`Suggested newValue \`${newVersion}\` was not included in allVersions, but it should have been. Returning it anyway`,
|
|
);
|
|
|
|
return newVersion;
|
|
}
|
|
|
|
function getShortestMatchingVersion(
|
|
prefix: string,
|
|
newParsed: SemVer,
|
|
allVersions: Set<string>,
|
|
minLevel: 'major' | 'minor' = 'major',
|
|
): string | null {
|
|
const { major, minor, patch } = newParsed;
|
|
const versions = new Set(allVersions);
|
|
|
|
// in shortest-first order: major, minor, patch, full
|
|
if (minLevel === 'major') {
|
|
const v = `${prefix}${major}`;
|
|
if (versions.has(v)) {
|
|
return v;
|
|
}
|
|
}
|
|
|
|
const v = `${prefix}${major}.${minor}`;
|
|
if (versions.has(v)) {
|
|
return v;
|
|
}
|
|
|
|
const patchVersion = `${prefix}${major}.${minor}.${patch}`;
|
|
if (versions.has(patchVersion)) {
|
|
return patchVersion;
|
|
}
|
|
|
|
const fullVersion = `${prefix}${newParsed.toString()}`;
|
|
if (versions.has(fullVersion)) {
|
|
return fullVersion;
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
function isCompatible(version: string): boolean {
|
|
return isValid(version);
|
|
}
|
|
|
|
function isBreaking(version: string, current: string): boolean {
|
|
const versionParsed = parseVersion(version);
|
|
const currentParsed = parseVersion(current);
|
|
|
|
if (!versionParsed || !currentParsed) {
|
|
return false;
|
|
}
|
|
|
|
if (currentParsed.major === 0) {
|
|
return versionParsed.major > 0 || versionParsed.minor > currentParsed.minor;
|
|
}
|
|
|
|
return versionParsed.major > currentParsed.major;
|
|
}
|
|
|
|
export const api: VersioningApi = {
|
|
equals,
|
|
getMajor,
|
|
getMinor,
|
|
getPatch,
|
|
isBreaking,
|
|
isCompatible,
|
|
isGreaterThan,
|
|
isLessThanRange,
|
|
isSingleVersion,
|
|
isStable,
|
|
isValid,
|
|
isVersion,
|
|
matches,
|
|
getSatisfyingVersion,
|
|
minSatisfyingVersion,
|
|
getNewValue,
|
|
sortVersions,
|
|
};
|
|
|
|
export default api;
|