Files
renovate/lib/modules/manager/git-submodules/update.spec.ts
Sebastian Poxhofer fbedd41e82 test: replace env operation with vi.stubEnv() (#45490)
* test: replace manual process.env mutation with vi.stubEnv

Enable Vitest's `unstubEnvs` so env stubs are reverted automatically
before every test, and convert the manual `process.env.X = ...` /
`delete process.env.X` pairs in specs to `vi.stubEnv()`.

This removes the hand-written `afterEach` cleanup blocks and the
`const OLD_ENV = process.env` / `process.env = { ...OLD_ENV }`
save-restore dance, which silently leaked state between tests when a
test set a variable without a matching delete.

Left as-is (incompatible with `unstubEnvs`, which unstubs before each
test, not after):
- module top-level env writes (cocoapods, gomod, post-update, pip-compile
  and bundler artifacts specs)
- `beforeAll` env writes -- the two in `util/http` moved to `beforeEach`

* test: stop asserting on ambient environment variables

Three specs asserted on values that the surrounding environment can
override, so they only passed on a machine that happened not to set them:

- `util/exec/env`: `getChildProcessEnv()` forwards every entry of
  `basicEnvVars`, but the spec only seeded a subset. Any other forwarded
  variable that was set ambiently (e.g. a lowercase `http_proxy`) leaked
  into the `toEqual` assertion. Clear all of them first.
- `util/git/index`: `process.env.GIT_SSH_COMMAND` deliberately overrides
  the default that the two env-inheritance tests assert on. Clear it.
- `logger/pretty-stdout`: the colorized level strings are built at import
  time, so the `beforeEach` setting `FORCE_COLOR` could never affect them
  -- it was dead code, and the test silently assumed a terminal without
  colour support. Derive the expectation the same way the module does.

* test(datasource/nuget): use a throwaway cache dir for nupkg downloads

The `determine source URL from nupkg` tests do not mock the filesystem,
so they really wrote downloaded packages into a fixed `/tmp/cache` path.
That fails wherever the system tmpdir is not writable, and two checkouts
running the suite at once would share the same directory.

Use `tmp.dir({ unsafeCleanup: true })` and clean it up afterwards, which
is the pattern the other specs that touch disk already use.

* feat(lint): add renovate/prefer-stub-env rule

Enforces in specs what the migration to `vi.stubEnv` established:

- assigning to or deleting `process.env.X` inside `beforeEach`, `afterEach`,
  `it` or `test` is reported, with a fixer that rewrites it to `vi.stubEnv()`
- module scope, `describe` bodies and `beforeAll` / `afterAll` are left alone:
  `unstubEnvs` reverts stubs *before* each test, so a stub created there is
  gone by the time the first test runs, and those must keep assigning directly
- replacing the `process.env` object is reported everywhere and never fixed.
  `vi.stubEnv()` captures the original object when the worker starts, so after
  a reassignment its deletes silently target the old object

The rule found 28 further violations in specs the earlier sweep missed, since
that one was anchored on `delete process.env`. Twelve were auto-fixed; the
rest replaced `process.env` wholesale and are now `clearEnv()` from test/util.

`util/exec/index.spec.ts` opts out with a comment: it asserts on the whole
child env, and `vi.stubEnv()` cannot express that because it maps `PROD`,
`DEV` and `SSR` onto '' instead of deleting them.
2026-08-28 09:26:20 +00:00

147 lines
4.3 KiB
TypeScript

import { codeBlock } from 'common-tags';
import type { SimpleGit } from 'simple-git';
import type { DirectoryResult } from 'tmp-promise';
import { dir } from 'tmp-promise';
import upath from 'upath';
import { mock } from 'vitest-mock-extended';
import { clearEnv, fs } from '~test/util.ts';
import { GlobalConfig } from '../../../config/global.ts';
import type {
InternalGlobalConfigOptions,
RepoGlobalConfig,
} from '../../../config/types.ts';
import * as git from '../../../util/git/index.ts';
import type { Upgrade } from '../types.ts';
import { updateDependency } from './index.ts';
vi.mock('../../../util/fs/index.ts');
const createSimpleGit = vi.mocked(git.createSimpleGit);
const gitMock = mock<SimpleGit>();
const baseDir = `${import.meta.dirname}/__fixtures__`;
describe('modules/manager/git-submodules/update', () => {
beforeEach(() => {
GlobalConfig.set({ localDir: baseDir });
clearEnv();
createSimpleGit.mockReturnValue(gitMock);
});
describe('updateDependency', () => {
let upgrade: Upgrade;
let adminConfig: RepoGlobalConfig & InternalGlobalConfigOptions;
let tmpDir: DirectoryResult;
beforeAll(async () => {
upgrade = { depName: 'renovate' };
tmpDir = await dir({ unsafeCleanup: true });
adminConfig = { localDir: upath.join(tmpDir.path) };
GlobalConfig.set(adminConfig);
});
afterAll(async () => {
await tmpDir.cleanup();
GlobalConfig.reset();
});
it('returns null on error', async () => {
gitMock.submoduleUpdate.mockRejectedValue(new Error());
const update = await updateDependency({
fileContent: '',
packageFile: '.gitmodules',
upgrade,
});
expect(update).toBeNull();
});
it('returns content on update', async () => {
gitMock.submoduleUpdate.mockResolvedValue('');
gitMock.checkout.mockResolvedValue('');
const update = await updateDependency({
fileContent: '',
packageFile: '.gitmodules',
upgrade,
});
expect(update).toBe('');
});
it('requests Git authentication for submodule commands', async () => {
gitMock.submoduleUpdate.mockResolvedValue('');
gitMock.checkout.mockResolvedValue('');
const update = await updateDependency({
fileContent: '',
packageFile: '.gitmodules',
upgrade,
});
expect(update).toBe('');
expect(createSimpleGit).toHaveBeenCalledTimes(2);
expect(createSimpleGit).toHaveBeenNthCalledWith(1, {
config: { baseDir },
authentication: {
hostTypes: ['git-tags', 'git-refs'],
},
});
expect(createSimpleGit).toHaveBeenNthCalledWith(2, {
config: { baseDir: upath.join(baseDir, 'renovate') },
authentication: {
hostTypes: ['git-tags', 'git-refs'],
},
});
});
it('update gitmodule branch value if value changed', async () => {
gitMock.submoduleUpdate.mockResolvedValue('');
gitMock.checkout.mockResolvedValue('');
const updatedGitModules = codeBlock`
[submodule "renovate"]
path = deps/renovate
url = https://github.com/renovatebot/renovate.git
branch = v0.0.2
`;
fs.readLocalFile.mockResolvedValueOnce(updatedGitModules);
upgrade = {
depName: 'renovate',
currentValue: 'v0.0.1',
newValue: 'v0.0.2',
packageFile: '.gitmodules',
};
const update = await updateDependency({
fileContent: '',
packageFile: '.gitmodules',
upgrade,
});
expect(update).toBe(updatedGitModules);
expect(gitMock.subModule).toHaveBeenCalledExactlyOnceWith([
'set-branch',
'--branch',
'v0.0.2',
'renovate',
]);
});
it('do not update gitmodule branch value if value not changed', async () => {
gitMock.submoduleUpdate.mockResolvedValue('');
gitMock.checkout.mockResolvedValue('');
upgrade = {
depName: 'renovate',
currentValue: 'main',
newValue: 'main',
packageFile: '.gitmodules',
};
const update = await updateDependency({
fileContent: '',
packageFile: '.gitmodules',
upgrade,
});
expect(update).toBe('');
expect(gitMock.subModule).toHaveBeenCalledTimes(0);
});
});
});