mirror of
https://github.com/renovatebot/renovate.git
synced 2026-10-25 23:11:31 +00:00
3412de84ce
* refactor(lint): enable oxlint prefer-named-capture-group at error Numbered capture groups (m[1], $1) break silently when a regex is edited and group order shifts. Named groups (?<name>...) make intent explicit and accesses (m.groups.name) resilient to reordering. This enables the built-in eslint rule prefer-named-capture-group, surfacing 321 pre-existing unnamed-group violations across ~121 files to be burned down incrementally in follow-up commits. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(versioning): name capture groups for prefer-named-capture-group Burns down all prefer-named-capture-group violations in lib/modules/versioning/. Unused capture groups (only reachable via .test() or whole-match) become non-capturing (?:...); groups whose value is read become named (?<name>...), with accesses rewritten to match.groups!.<name> (or destructured from .groups!) instead of positional match[n]/$n so a future edit that reorders groups cannot silently break the reader. Two cases needed extra care to preserve behavior: - semver/common.ts and poetry/patterns.ts split() on a regex whose capture group is relied upon by String.prototype.split to keep the separator in the output array; the group is kept capturing and named, not converted to non-capturing. - hashicorp/convertor.ts's semverRegex is only ever embedded via .source into a named `(?<version>...)` group elsewhere and never matched directly, so its internal groups are safe to make non-capturing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(datasource): name capture groups for prefer-named-capture-group Burns down all prefer-named-capture-group violations under lib/modules/datasource/. Same treatment as the versioning module: unused groups become non-capturing, used groups get names, and positional match[n] reads move to match.groups!.<name>. docker/ecr.ts and pypi/common.ts keep their positional destructuring (`const [, region] = ...`, `!!m &&`) working unchanged since a named capture group is still addressable by its numeric index in JavaScript — only pypi/common.ts's access was rewritten to m.groups!.owner for clarity since it read a single group directly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(platform): name capture groups for prefer-named-capture-group Burns down all prefer-named-capture-group violations under lib/modules/platform/. Uses the repo's established idiom of `match.groups?.<name>` after an optional-chained exec()/match() (see bitbucket/index.ts hostnameWithoutApiPrefix, gerrit/utils.ts extractSourceBranch) and `$<name>` in String.replace replacement strings. Unused groups (markdown/HTML massaging regexes matched only to be stripped) become non-capturing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(manager): name capture groups in ansible-galaxy for prefer-named-capture-group Burns down prefer-named-capture-group violations in lib/modules/manager/ansible-galaxy/. newBlockRegEx and blockLineRegEx dropped their unused outer wrapping group (only the inner key/value groups were ever read) and named the key/value groups; nameMatchRegex's remaining unused groups (protocol/user-info/port alternatives) become non-capturing since only source/hostname/depName/version are read via .groups. Accesses in collections.ts and roles.ts move from lineMatch[2]/lineMatch[3] to lineMatch.groups!.key/value. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(manager): name capture groups for prefer-named-capture-group (batch 1) Burns down prefer-named-capture-group violations across the first alphabetical slice of lib/modules/manager/ (ansible through mix). Used groups get names with accesses rewritten to match.groups!.<name> (or $<name> in replacement strings); groups whose value is never read become non-capturing (?:...). Two String.split() call sites (git-submodules/extract.ts, meteor/extract.ts) keep the established "named group still readable positionally from the split() result array" idiom instead of restructuring the destructuring. bazel/rules/go.ts and buildpacks/extract.ts dockerRef verified byte-for-byte equivalent before/after via a quick node script since several nested groups collapsed to non-capturing at once. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(manager): name capture groups for prefer-named-capture-group (batch 2) Burns down prefer-named-capture-group violations across the remaining alphabetical slice of lib/modules/manager/ (npm through terragrunt). Same treatment as batch 1: used groups get names with accesses moved to match.groups!.<name> or $<name> replacement strings; unused groups (wrapping alternations, quantifier repetition groups only consumed via .test(), or values never read from a match) become non-capturing. terraform/extractors/others/modules.ts and terragrunt/modules.ts share near-identical URL-parsing regexes (github/bitbucket/git/azure-devops ref matchers) — the same set of always-unused `depth=`/`&depth=` query-string groups is converted to non-capturing in both files. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(config): name capture groups for prefer-named-capture-group Burns down prefer-named-capture-group violations in lib/config/. Used groups get names with replacement strings switched from $1/$2 to $<name>; the unused separator group in schedule-migration.ts's afterBeforeRegex becomes non-capturing. presets/parse.ts keeps assigning through the already-declared `repo` variable rather than array-destructuring the exec() result, matching this file's existing style for the other named-group regexes just above it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(util): name capture groups for prefer-named-capture-group Burns down prefer-named-capture-group violations across lib/util/ and lib/logger/. Same treatment as previous batches: named groups for values that are read (via $<name> replacement strings, .groups!.<name>, or destructured from .groups), non-capturing groups where nothing reads the captured value (e.g. semantic.ts's angular-commit .test()-only regex). www-authenticate.ts's tokenizer entries each get their own named group but keep accessing the match generically via match[1], since a positionally-indexed named group is still readable by index. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(workers): name capture groups for prefer-named-capture-group Burns down prefer-named-capture-group violations in lib/workers/. Used groups get names with $<name> replacement strings; unused wrapper/alternation groups (e.g. semantic-commit-message.ts's optional scope/issue wrappers, release-notes.ts's date-heading and horizontal-rule matchers that are only probed with .search()/replaced wholesale) become non-capturing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(test,tools): name capture groups for prefer-named-capture-group Finishes the prefer-named-capture-group burndown: test/, tools/, and vitest.config.mts. Groups whose value is read get names ($<name> replacement strings or .groups.<name> access); groups only used via .test()/.search() or that feed a .match(/…/g) call (whose return value is the array of whole matches, not captured groups) become non-capturing. This is the last remaining slice of pre-existing violations, so the rule (already enabled at error repo-wide) now passes with zero findings across the whole codebase. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * fix prettier failure * refactor(lint): use a named capture group in `v8-ignore-no-count` New rule from main trips the newly enabled `prefer-named-capture-group` oxlint rule. --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
199 lines
5.3 KiB
TypeScript
199 lines
5.3 KiB
TypeScript
import { DateTime } from 'luxon';
|
|
import dataFiles from '../../data-files.generated.ts';
|
|
import { regEx } from '../../util/regex.ts';
|
|
import type {
|
|
DistroDataFile,
|
|
DistroInfoRecord,
|
|
DistroInfoRecordWithVersion,
|
|
DistroSchedule,
|
|
} from './types.ts';
|
|
|
|
// Days to delay new releases
|
|
const delay = 1;
|
|
|
|
export class DistroInfo {
|
|
private readonly _codenameToVersion = new Map<
|
|
string,
|
|
DistroInfoRecordWithVersion
|
|
>();
|
|
|
|
private readonly _sortedInfo: DistroInfoRecordWithVersion[] = [];
|
|
|
|
private readonly _distroInfo: DistroInfoRecord;
|
|
|
|
constructor(distroJsonKey: DistroDataFile) {
|
|
this._distroInfo = JSON.parse(
|
|
dataFiles
|
|
.get(distroJsonKey)!
|
|
.replace(regEx(/v(?<version>[\d.]+)\b/gm), '$<version>'),
|
|
);
|
|
|
|
for (const version of Object.keys(this._distroInfo)) {
|
|
const schedule = this._distroInfo[version];
|
|
this._codenameToVersion.set(schedule.series, { version, ...schedule });
|
|
}
|
|
|
|
const arr = Object.keys(this._distroInfo).sort(
|
|
(a, b) => parseFloat(a) - parseFloat(b),
|
|
);
|
|
|
|
for (const v of arr) {
|
|
const obj = { version: v, ...this._distroInfo[v.toString()] };
|
|
if (!obj.release) {
|
|
// istanbul ignore next
|
|
continue;
|
|
}
|
|
this._sortedInfo.push(obj);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Check if input is a valid release codename
|
|
* @param input A codename
|
|
* @returns true if input is a codename, false otherwise
|
|
*/
|
|
public isCodename(input: string): boolean {
|
|
return this._codenameToVersion.has(input);
|
|
}
|
|
|
|
/**
|
|
* Checks if given input string is a valid release version
|
|
* @param input A codename/semVer
|
|
* @returns true if release exists, false otherwise
|
|
*/
|
|
public exists(input: string): boolean {
|
|
const ver = this.getVersionByCodename(input);
|
|
return !!this._distroInfo[ver];
|
|
}
|
|
|
|
/**
|
|
* Get semVer representation of a given codename
|
|
* @param input A codename
|
|
* @returns A semVer if exists, otherwise input string is returned
|
|
*/
|
|
public getVersionByCodename(input: string): string {
|
|
const schedule = this._codenameToVersion.get(input);
|
|
if (schedule) {
|
|
return schedule.version;
|
|
}
|
|
return input;
|
|
}
|
|
|
|
/**
|
|
* Get codename representation of a given semVer
|
|
* @param input A semVer
|
|
* @returns A codename if exists, otherwise input string is returned
|
|
*/
|
|
public getCodenameByVersion(input: string): string {
|
|
const di = this._distroInfo[input];
|
|
if (di) {
|
|
return di.series;
|
|
}
|
|
// istanbul ignore next
|
|
return input;
|
|
}
|
|
|
|
/**
|
|
* Get schedule of a given release
|
|
* @param input A codename/semVer
|
|
* @returns A schedule if available, otherwise undefined
|
|
*/
|
|
public getSchedule(input: string): DistroSchedule | null {
|
|
const ver = this.getVersionByCodename(input);
|
|
return this._distroInfo[ver] ?? null;
|
|
}
|
|
|
|
/**
|
|
* Check if a given release has passed its EOL
|
|
* @param input A codename/semVer
|
|
* @returns false if still supported, true otherwise
|
|
*/
|
|
public isEolLts(input: string): boolean {
|
|
const ver = this.getVersionByCodename(input);
|
|
const schedule = this.getSchedule(ver);
|
|
const endLts = schedule?.eol ?? null;
|
|
let end = schedule?.eol_lts ?? null;
|
|
|
|
// ubuntu: does not have eol_lts
|
|
// debian: only "Stable" has no eol_lts, old and oldold has both
|
|
end ??= endLts;
|
|
|
|
if (end) {
|
|
const now = DateTime.now().toUTC();
|
|
const eol = DateTime.fromISO(end, { zone: 'utc' });
|
|
return eol < now;
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
/**
|
|
* Check if a given version has been released
|
|
* @param input A codename/semVer
|
|
* @returns false if unreleased or has no schedule, true otherwise
|
|
*/
|
|
public isReleased(input: string): boolean {
|
|
const ver = this.getVersionByCodename(input);
|
|
const schedule = this.getSchedule(ver);
|
|
|
|
if (!schedule?.release) {
|
|
return false;
|
|
}
|
|
|
|
const now = DateTime.now().minus({ day: delay }).toUTC();
|
|
const release = DateTime.fromISO(schedule.release, { zone: 'utc' });
|
|
|
|
return release < now;
|
|
}
|
|
|
|
/**
|
|
* Check if a given version has been created
|
|
* @param input A codename/semVer
|
|
* @returns false if unreleased or has no schedule, true otherwise
|
|
*/
|
|
public isCreated(input: string): boolean {
|
|
const ver = this.getVersionByCodename(input);
|
|
const schedule = this.getSchedule(ver);
|
|
|
|
if (!schedule) {
|
|
return false;
|
|
}
|
|
|
|
const now = DateTime.now().minus({ day: delay }).toUTC();
|
|
const created = DateTime.fromISO(schedule.created, { zone: 'utc' });
|
|
|
|
return created < now;
|
|
}
|
|
|
|
/**
|
|
* Get distro info for the release that has N other newer releases.
|
|
* Example: n=0 corresponds to the latest available release, n=1 the release before, etc.
|
|
* In Debian terms: N = 0 -> stable, N = 1 -> oldstable, N = 2 -> oldoldstalbe
|
|
* @param n
|
|
* @returns Distro info of the Nth latest release
|
|
*/
|
|
public getNLatest(n: number): DistroInfoRecordWithVersion | null {
|
|
const len = this._sortedInfo.length - 1;
|
|
let idx = -1;
|
|
|
|
if (n < 0) {
|
|
return null;
|
|
}
|
|
|
|
for (let i = len; i >= 0; i--) {
|
|
if (this.isReleased(this._sortedInfo[i].version)) {
|
|
// 'i' holds the latest released version index
|
|
// compensate for the requested 'n'
|
|
idx = i - Math.floor(n);
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (idx > len || idx < 0) {
|
|
return null;
|
|
}
|
|
|
|
return this._sortedInfo[idx];
|
|
}
|
|
}
|