2 Commits

Author	SHA1	Message	Date
Sebastian Poxhofer	4b4d14ec00	feat(manager): pass extracted constraints to updateArtifacts (#45826) ... * feat(manager): pass extracted constraints to updateArtifacts `extractedConstraints` were collected during extraction but only ever read by `fetch.ts` for the lookup. At artifact time every manager had to derive the same tool constraints a second time, and when the updated package file no longer carried the constraint there was nothing to fall back to. `generateBranchConfig()` now merges the `extractedConstraints` of all upgrades of a branch onto the branch config, which reaches `updateArtifacts()` through `patchConfigForArtifactsUpdate()`. `UpdateArtifactsConfig` declares the field and documents what it contains. The new `resolveToolConstraint()` helper implements the ladder once: user `constraints` > an optional artifact-time derivation > the extracted value. The derivation is ranked above the extracted value on purpose: it reads the package files as the branch changed them, so poetry (python is an updatable dependency there), composer, pipenv (`pipenv` can be a dev package) and pep621 (`requires-python` is an updatable dependency) would otherwise regress to a stale constraint. pipenv, pep621 uv/pdm, poetry and composer are migrated to the helper and keep their derivation. Behaviour change: these managers now use the extract-time constraint as a last resort instead of running unconstrained, for example on lock file maintenance where pipenv deletes `Pipfile.lock` before deriving. `execute-post-upgrade-commands.ts` is unaffected: it reads `upgrade.constraints` per upgrade, and the extracted values are kept in a separate field rather than folded into `constraints`, so post-upgrade task tool constraints still come from user config only. Not migrated, because their constraints are never extracted, so the fallback would be dead code: bundler (`ruby`/`bundler`), pixi (`pixi`), pep621 uv (`required-version`) and npm's node ladder, whose last step already reads `package.json` engines. * refactor(manager): resolve tool constraints through resolveToolConstraint() Every manager now obtains the constraint of a tool it runs through `resolveToolConstraint()` instead of reading `config.constraints` itself, so the precedence "user config, then a value derived from the updated files, then the constraints collected during extraction" applies everywhere. The helper treats an empty string as not set at every step and accepts the `PostUpdateConfig` shape, whose `constraints` may be `null`. Behaviour changes that go beyond the new fallback to extracted constraints: - `mix` applies its hardcoded erlang default only after the extracted constraint, so an erlang version collected at extraction can win over it. - `kustomize` decides `HELM_EXPERIMENTAL_OCI` from the fully resolved helm constraint; `generateHelmEnvs()` takes that value instead of the config. - `npm` (yarn): an upgrade of yarn without a new value now consults the user constraint before deriving one from package.json or the lock file. - The "Using <tool> constraint from config" debug lines in bundler, composer, copier and pip-compile are gone, as the helper is the only reader of the config now. Helpers that read the config synchronously became async: bundler `getBundlerConstraint()`, copier `getPythonVersionConstraint()` and `getCopierVersionConstraint()`, pip-compile `get*VersionConstraint()` and `getToolVersionConstraint()`, gomod `deriveGoToolchainConstraints()` and `getUpdateImportPathCmds()`, mise `getMiseLockToolConstraints()`. composer `getPhpConstraint()` is removed. Each converted manager has a test showing the extracted constraint reaching the executed tool, and, where a derive callback exists, that the derived value still wins over it. * refactor(linters): add prefer-resolve-tool-constraint rule Reports member reads and destructuring of `constraints` and `extractedConstraints` from a manager config in `lib/modules/manager/**`, so that tool constraints are resolved through `resolveToolConstraint()` in `lib/modules/manager/util.ts` only. Writes and the same properties on package files, which extraction has to populate, are not reported. The helper itself and spec files are exempt in `.oxlintrc.json`. * refactor(manager): inline thin resolveToolConstraint wrappers Drop copier/utils.ts and the pip-compile getPipToolsVersionConstraint / getUvVersionConstraint helpers, which only forwarded to resolveToolConstraint(). Callers now call it directly. * docs(development): note lock file maintenance in tool constraints section * refactor(manager): address review on tool constraint resolution composer only runs extractConstraints() when a user constraint is missing, via Lazy. UpdateArtifactsConfig no longer re-declares constraints and extractedConstraints, which ToolConstraintsConfig already provides.	2026-09-14 11:09:07 +00:00
Tim Tran	2f71422620	feat(bazel-module,bazelisk): add lock files updating (#41507) ... * feat(exec): register bazelisk as containerbase tool * test(bazel-module): add failing tests for updateArtifacts * feat(bazel-module): implement updateArtifacts for lockfile support * feat(bazel-module): export updateArtifacts from manager index * fix(bazel-module): address code review feedback - Use logger.warn instead of debug for artifact errors - Add utf8 encoding to readLocalFile calls - Use getSiblingFileName for lockfile path derivation - Add empty updatedDeps guard - Strengthen test assertions * docs(bazel-module): document lockfile support * Update lib/modules/manager/bazel-module/index.ts Co-authored-by: Michael Kriese <michael.kriese@gmx.de> * Apply suggestions from code review Co-authored-by: Michael Kriese <michael.kriese@gmx.de> * fix(bazel-module): address review feedback - Remove unnecessary afterEach in tests - Use partial<StatusResult> for all StatusResult mocks - Add lockfile maintenance support - Export supportsLockFileMaintenance flag * fix(bazel-module): handle untracked lock files and clarify docs Check status.not_added alongside status.modified for lock file changes, matching the pattern used by other managers (composer, gomod, etc.). Clarify that Bazelisk (not Renovate) reads .bazelversion. Add test for lockfile maintenance with no changes. * feat(bazelisk): implement updateArtifacts for MODULE.bazel.lock When the Bazel version in .bazelversion changes, run `bazel mod deps` to regenerate MODULE.bazel.lock and return the updated lockfile as an artifact. * feat(bazelisk): add lockfile maintenance support * docs(bazelisk): add lockfile support section linking to bazel-module docs * refactor(bazel-module): extract shared lockfile update helper * refactor(bazel-module): delegate lockfile update to shared helper Replace inline lockfile update logic in artifacts.ts with a call to the shared updateBazelLockfile() helper, and update tests to mock the helper. * refactor(bazelisk): delegate lockfile update to shared helper Replace inline lockfile update logic in bazelisk/artifacts.ts with a call to the shared updateBazelLockfile() helper from bazel-module/lockfile.ts. * fix(bazelisk): use index.md for cross-manager docs link The docs pipeline renames readme.md to index.md, so cross-manager links must reference index.md to pass the docs link checker. * feat(bazel-module,bazelisk): support bazelisk version constraint Pass config.constraints.bazelisk through to toolConstraints so users can pin the bazelisk version if the newest release is broken. * fix(bazel-module): rename lockFile to fileName in ArtifactError Upstream renamed lockFile to fileName in ArtifactError type (#41631). --------- Co-authored-by: Michael Kriese <michael.kriese@gmx.de>	2026-03-12 16:40:24 +00:00