Commit Graph

35 Commits

Author SHA1 Message Date
Sebastian Poxhofer b2d3b64c48 refactor(lint): enforce err key for errors in logger metadata (#45759)
* refactor(lint): enforce err key for errors in logger metadata

* refactor(lint): flag error message and stack strings in logger-err-key
2026-09-09 13:55:14 +00:00
Sebastian Poxhofer 0ff377b688 test(linters): forbid file-based snapshot matchers (#45661)
* test(linters): forbid file-based snapshot matchers

* test(linters): drop inline snapshot recommendation

* test(linters): assert on relevant sections instead of full bodies
2026-09-04 10:28:56 +00:00
Sebastian Poxhofer a473e73b3e fix(linters): forbid inert counts in v8 coverage-ignore comments (#45287)
Adds a custom oxlint rule renovate/v8-ignore-no-count that flags the
count form '/* v8 ignore next <N> */'. The count is not honored by
vitest's ast-v8-to-istanbul hint parser, which captures only the
keyword (if/else/next/file); 'next' always exempts exactly the next
AST node. Trailing counts therefore suggest a line range that is never
applied and mislead readers.

The rule is autofixable (drops the count, preserving actual behavior)
and has been applied to all existing occurrences.
2026-08-22 11:25:31 +00:00
Sebastian Poxhofer 171a591d84 feat(git): validate commit shas (#43988)
* feat(git): validate length commit shas

* test: adapt test mocks

* chore: update import paths

* feat(git): make the validation more strict and support repositories using sha256

* test: add fakeSha function for deterministic git commit shas in tests
2026-06-15 06:36:57 +00:00
Sebastian Poxhofer b632d27cdd ci(agents): extend AGENTS.md and add Claude hooks (#43470)
* ci: add agent instructions and ClaudeCode hooks

* refactor: rename start-check and use schemas

* fix: remove redundant flow diagram

* refactor: add block utility

* docs: add reference to development documentation

* ci: add pretooluse hook

* test: remove unnecessary schema tests

* ci: add --all flag run fixer and linters in a single command

* ci: switch stop hook to `pnpm check --all`

* refactor: use simple git

* refactor: use zod/v4

* ci: prevent usages of pnpm vitest

* ci: add must read and code example for codeBlock

* fixup! simplegit by allowing user pagers and editors

* ci(agent hooks): run installs on worktree changes

* docs: shorten description

* chore: remove additional new line at the end

* explicitly fail if parsing fails

* fix: rename to kebabcase

* docs: reduce commands highlighted for local dev
2026-06-08 13:56:15 +00:00
Sebastian Poxhofer fcadf4c531 docs(dev): add code example of regex utility (#43624) 2026-05-27 11:33:29 +00:00
RahulGautamSingh cb96dee10b docs(development): using mock & mockDeep (#43162)
* docs(best-practices): using mock & mockDeep

* Update docs/development/best-practices.md

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

---------

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
2026-05-09 06:43:38 +00:00
Michael Kriese 050ac8d23b chore: better code coverage (#39518) 2025-11-25 15:01:54 +00:00
Michael Kriese b5ff90f2bd fix: improve coverage (#34667) 2025-03-06 17:05:19 +00:00
Michael Kriese bb5377b3d8 test: fix code coverage (#34495) 2025-02-26 12:40:30 +00:00
Michael Kriese 997c23502e test: migrate to vitest (#34475)
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
2025-02-26 09:35:54 +00:00
Rhys Arkins de014979e9 docs: Use codeBlock (#31132) 2024-08-31 06:28:21 +00:00
Florian Greinacher a567774e7e docs(development): clarify logging principles (#28162) 2024-03-28 16:17:22 +00:00
HonkingGoose fc1418940d docs(best practices): fix styling (#27905) 2024-03-13 10:40:46 +00:00
Oleksandr Redko 1ffa44c4fe docs: fix typos and improve documentation consistency (#27418) 2024-02-19 12:36:39 +00:00
Ikko Eltociear Ashimine 60dda0d6ff docs: fix typo in best-practices.md (#27043) 2024-02-03 19:30:05 +00:00
HonkingGoose afa289f72a docs(best practices): refactor code or tests, not both at once (#25237) 2023-10-17 07:16:45 +00:00
HonkingGoose bdf5fb96b1 docs: rewrite best practices developer docs (#22985) 2023-06-26 14:46:43 +00:00
HonkingGoose b08fa0cf8b docs: drop weasel words (#22165)
Co-authored-by: Rhys Arkins <rhys@arkins.net>
2023-05-29 08:20:40 +00:00
HonkingGoose e387b8225e docs(best-practices): prefer satisfies operator over as (#20566)
Co-authored-by: Rhys Arkins <rhys@arkins.net>
2023-02-23 09:14:58 +00:00
HonkingGoose 73fab475db docs(best-practices): conventional commit branch names (#20108)
Co-authored-by: Rhys Arkins <rhys@arkins.net>
2023-01-31 07:28:09 +01:00
Sergei Zharinov 74ddbe319c docs(best-practices): Separate AAA with empty line (#18098) 2022-10-03 18:58:12 +02:00
HonkingGoose d782636d47 docs(best-practices): improve functions section (#17070) 2022-08-10 09:59:09 +03:00
Gabriel-Ladzaretti 9bf011893f docs: added functions section to best-practices.md (#17065)
added functions section to the best-practices.md
2022-08-09 09:44:29 +02:00
Nabeel Saabna afa877bbba docs: add code simplicity section (#16786) 2022-07-29 20:43:51 +02:00
Gabriel-Ladzaretti 5f83529ec8 docs: best practices add cast bullet under unit testing (#16756)
docs: best prac add cast bullet under unit testing
2022-07-25 14:15:09 +02:00
HonkingGoose badccaff89 docs(best practices): create section for async functions (#16574) 2022-07-15 14:10:01 +03:00
HonkingGoose 6ae4a55bd3 docs(best practices): avoid boolean instead use is functions (#16573)
* docs(best practices): avoid boolean instead use is functions

* Update docs/development/best-practices.md

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
2022-07-15 10:46:02 +00:00
HonkingGoose bb45bc37b0 docs: prevent line ending problems when self-hosting on Windows (#16326) 2022-07-01 09:46:10 +02:00
Michael Kriese aeec0f411e chore: enforce ts as cast (#16164) 2022-06-22 10:20:34 +00:00
Michael Kriese f7454a0f6b docs: no toDeepEqual on jest v28 (#16152) 2022-06-20 13:20:14 +02:00
Philip 49e3aff78b docs: update best practices regex groups + windows clrf + exporting test functions (#15969) 2022-06-10 06:48:06 +02:00
Michael Kriese d28324a517 docs: update best practices (#15960) 2022-06-10 05:31:33 +02:00
HonkingGoose 8e540f051a docs(best practices): add new unit testing rules (#15799) 2022-06-01 11:33:35 +02:00
Gabriel-Ladzaretti 2689a5560d docs: Add renovate related best practices guide (#15589) 2022-05-26 07:48:40 +02:00