Commit Graph

32 Commits

Author SHA1 Message Date
Sebastian Poxhofer b2d3b64c48 refactor(lint): enforce err key for errors in logger metadata (#45759)
* refactor(lint): enforce err key for errors in logger metadata

* refactor(lint): flag error message and stack strings in logger-err-key
2026-09-09 13:55:14 +00:00
Sebastian Poxhofer c41b46bac3 feat(logging): do not use dynamic fields in log messages with severity WARN or higher (#44560)
* ci(linter): add renovate/logger-static-message rule

Adds a custom oxlint rule that enforces a static msg component for
logger.warn/error/fatal calls (including logger.once variants) so the
messages can be grouped in metrics and error catching services, per
docs/development/best-practices.md. It also flags metadata properties
named 'error' that hold error-ish values, because the bunyan serializer
only handles the 'err' key.

The rule is enabled as an error for lib/ production code and disabled
for spec files. All 33 pre-existing violations are fixed by moving
interpolated values into the metadata object, making messages static,
and renaming 'error' metadata keys to 'err'. Affected log-message
assertions in co-located specs are updated accordingly.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* ci: ignore validator output

* fixup new merged in log messages

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-16 06:53:37 +00:00
Jamie Tanna b0eaed712e chore(workers/repository): instrument handleError (#43746)
As it was useful in debugging #43745's multiple calls to raise an
"Action Required" configuration warning.
2026-06-02 16:55:14 +00:00
Sergei Zharinov 930cf6633c refactor: Rewrite imports with .ts extensions (#40700)
fix: Additional vi.mock path corrections and prettier formatting
2026-01-26 22:48:17 +00:00
Jamie Tanna 58d6f4125b fix(types): make result a strong type (#39783)
As a way to make it more predictable what the possible states the
`result` in a given `Repository finished` log message can be, we can
wrap these into a type.

This requires a slight refactor where these are used to make sure that
Typescript is happy with the value being returned.

We can capture the common groups of errors (which are then present as a
`RepositoryResult`) and expose that to be used.
2025-12-08 18:17:54 +00:00
Dave 83d64647b7 feat: add configValidationError option to log config validation errors as errors instead of warnings (#39177)
* feat: add configValidationError option to log config validation errors as errors instead of warnings

* Moved `configValidationError` docs to correct file.
2025-11-10 17:09:20 +00:00
RahulGautamSingh 3c4b2f6935 feat(logs): convert invalid config log level to warn (#38925)
logLevel: info -> warn
2025-10-29 07:12:50 +00:00
Rhys Arkins 3bdd530ae5 feat: forkCreation (#27686) 2024-03-02 10:42:43 +00:00
Rhys Arkins 2caf0b304b fix(github): skip forked repos when in fork mode (#27684) 2024-03-02 07:16:07 +00:00
Scott Busche d0cd6fae8e fix(docs): Update outdated error message (#27079) 2024-02-05 20:04:49 +00:00
Sergei Zharinov b69416ce17 refactor(prettier): Force trailing commas (#25631) 2023-11-07 15:50:29 +00:00
Rhys Arkins 43fa615e05 fix: Revert "feat(github): forkOrgs, forkCreate (#18770)"
This reverts commit 2f77695ba5.
2023-06-19 15:10:21 +02:00
Rhys Arkins 2f77695ba5 feat(github): forkOrgs, forkCreate (#18770)
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
2023-06-19 03:29:32 +00:00
Jesse Houwing 4349b38449 fix: Provide link to the relevant cli switch to include forked repos (#20207)
Co-authored-by: Rhys Arkins <rhys@arkins.net>
2023-06-18 10:07:32 +00:00
Gabriel-Ladzaretti d88d63b4f9 feat(config-error): raise a warning issue for misconfigured matchConfidence (#22296)
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
2023-05-18 17:02:13 +00:00
Rhys Arkins 143c9a6751 refactor: rename lookupName -> packageName (#14494)
Renames `lookupName` to be `packageName`.

BREAKING CHANGE: Use `packageName` instead of `lookupName` if interacting with Renovate datasources directly.
2022-03-04 09:04:02 +01:00
HonkingGoose ab018191fa chore: report and fix unused ESLint disable directives (#12548) 2021-11-08 20:20:03 +01:00
Sergei Zharinov b957d4afb7 refactor(config): Extract interfaces from "index.ts" to separate "types.ts" (#9629) 2021-04-20 10:52:57 +02:00
Rhys Arkins e28e8b44cb fix: add new disabled commands to result handling 2021-02-11 17:10:20 +01:00
Rhys Arkins fa9031f5e9 feat(internal): expand disabled error messages
Splits REPOSITORY_DISABLED into multiple
2021-02-11 13:32:29 +01:00
Rhys Arkins 7de273aa6b fix(git): gracefully handle not a git repository failure 2020-10-12 10:36:49 +02:00
Rhys Arkins 91be1678ac refactor: targetBranch mandatory in platform.createPr (#6829) 2020-07-23 12:43:06 +02:00
Rhys Arkins 926a553a76 fix: sanitize commitMessage, prTitle, branchName
In preparation for secrets PR
2020-07-03 16:52:16 +02:00
Rhys Arkins 031ad87b62 refactor: move ExternalHostError 2020-06-23 11:44:52 +02:00
Rhys Arkins 52a074e041 refactor: ExternalHostError (#6563) 2020-06-22 21:28:02 +02:00
Rhys Arkins 53ca91301f chore: import linting (#6105) 2020-05-01 18:03:48 +02:00
Rhys Arkins f97b194515 fix: gracefully catch and handle out of memory 2020-04-16 18:08:53 +02:00
Rhys Arkins 8fc70b8faf logs: log err with Registry error 2020-02-14 13:44:53 +01:00
Rhys Arkins 12166f5540 fix(datasource): better DatasourceError handling 2020-02-14 09:19:45 +01:00
Sourav Das ee153e560e feat: use error constants (#5088) (#5100)
Use defined error constants throughout codebase.
2020-01-12 08:50:11 +01:00
Rhys Arkins 0dab3f4067 refactor: logs meta 2020-01-11 09:16:22 +01:00
Jamie Magee 45474d63d5 fix(ts): convert lib/workers/repository to typescript (#5105)
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
2020-01-10 11:35:49 +01:00