Commit Graph

71 Commits

Author SHA1 Message Date
Sebastian Poxhofer 05e1271376 test: use expect().resolves instead of awaiting inside expect (#45672)
Enables the vitest/prefer-expect-resolves oxlint rule and applies its
autofix across the spec suite.
2026-09-04 10:40:46 +00:00
Sebastian Poxhofer 762ac01133 test(platform): replace file snapshots with explicit assertions (#45684)
* test(manager): replace file snapshots with explicit assertions

* test(manager): replace inline snapshots with explicit assertions

* test(manager): assert on relevant sections instead of full bodies

* test(manager): drop assertions implied by full equality

* test(manager): address review feedback

* test(manager): assert depType and versioning in the regex matcher

* test(bundler): replace file snapshots with explicit assertions

* test(bundler): replace inline snapshots with explicit assertions

* test(bundler): drop assertions implied by full equality

* test(bundler): address review feedback

* test(npm): replace file snapshots with explicit assertions

* test(npm): replace inline snapshots with explicit assertions

* test(platform): replace file snapshots with explicit assertions

* test(platform): replace inline snapshots with explicit assertions

* test(platform): assert on relevant sections instead of full bodies

* test(platform): address review feedback

* test(platform): use resolves instead of awaiting inside expect
2026-09-04 10:28:54 +00:00
Fernando Fernández e631d60813 fix(bitbucket): bbUseDevelopmentBranch fetching (#45626)
* fix(bitbucket): use effective-branching-mode endpoint for bbUseDevelopmentBranch

Signed-off-by: Fernando Fernández <ferferga@hotmail.com>

* refactor(bitbucket): add more logging around BitBucket's branching model

Signed-off-by: Fernando Fernández <ferferga@hotmail.com>

* test(bitbucket): update mock for effective-branching-model

Signed-off-by: Fernando Fernández <ferferga@hotmail.com>

* test(bitbucket): fix forgotten test mock

Signed-off-by: Fernando Fernández <ferferga@hotmail.com>

* chore: address review comments

Signed-off-by: Fernando Fernández <ferferga@hotmail.com>

* fix(bitbucket): tests and types

Signed-off-by: Fernando Fernández <ferferga@hotmail.com>

---------

Signed-off-by: Fernando Fernández <ferferga@hotmail.com>
2026-09-02 15:50:47 +00:00
Jamie Tanna ad63dddef7 fix(platform/bitbucket): remove support for Issues (#45445)
On 2026-02-20, Atlassian announced that they would be removing the
native issue tracker in Bitbucket Cloud[0].

As of 2026-08-24[1], this change is now complete.

When Renovate attempts to update an existing Dependency Dashboard Issue,
we see:

    DEBUG: GET https://api.bitbucket.org/2.0/repositories/some/repo/issues?q=... = (code=ERR_NON_2XX_3XX_RESPONSE, statusCode=410 retryCount=0, duration=87)
    WARN: Error finding issues

And when trying to create one, we see:

    DEBUG: findIssue(Dependency Dashboard)
    DEBUG: Issues are disabled - cannot findIssue

Because it's not possible - until #20568 - to use another source for
Issues on Bitbucket Cloud, we need to remove support for the Dependency
Dashboard.

When we do try and interact with them, we can DEBUG log as to why it's a
no-op (similar to `platform=bitbucket-server`), and reference the deprecation.

As we now don't touch Issues, we can remove the additional permissions
that were previously required.

As there are no longer Issues, we can remove `has_issues` from our
types.

As well as the Dependency Dashboard, this also means that i.e. Config
Warning Issues are no longer available.

[0]: https://developer.atlassian.com/cloud/bitbucket/changelog/#CHANGE-3071
[0]: https://developer.atlassian.com/cloud/bitbucket/changelog/#CHANGE-3401

Co-authored-by: Claude Opus 5 <jamie.tanna+claude-code@mend.io>
2026-08-25 15:40:06 +00:00
Sebastian Poxhofer 5ad36a2387 test(linters): add linting rule to enforce usage of host rules test util (#44692)
* ci(linter): add renovate/no-host-rules-mock rule

Flags vi.mock()/vi.doMock() calls whose module specifier contains
"host-rules" in spec files. Tests should configure real rules via
hostRules.add() instead of mocking the host-rules module.

Enabled at "warn" severity instead of "error": the repo currently has
35 pre-existing violations across 34 spec files, which exceeds the
agreed fix threshold of 12 files. No violation fixes are included;
migrating each spec to real hostRules.add()/clear() setup is a
semantic test rewrite that should be done incrementally, after which
the rule can be promoted to "error".

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* ci(linter): enforce renovate/no-host-rules-mock at error

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* test(datasource): use real host-rules instead of mocking

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* test(manager): use real host-rules instead of mocking

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* test(platform): use real host-rules instead of mocking

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* test(util,workers): use real host-rules instead of mocking

Also narrow renovate/no-host-rules-mock to the host-rules module itself so that mocking e.g. host-rules-from-env is not flagged.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* ci(linter): mention '~test/host-rules.ts' util in no-host-rules-mock message

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-19 10:36:12 +00:00
Sebastian Poxhofer c41b46bac3 feat(logging): do not use dynamic fields in log messages with severity WARN or higher (#44560)
* ci(linter): add renovate/logger-static-message rule

Adds a custom oxlint rule that enforces a static msg component for
logger.warn/error/fatal calls (including logger.once variants) so the
messages can be grouped in metrics and error catching services, per
docs/development/best-practices.md. It also flags metadata properties
named 'error' that hold error-ish values, because the bunyan serializer
only handles the 'err' key.

The rule is enabled as an error for lib/ production code and disabled
for spec files. All 33 pre-existing violations are fixed by moving
interpolated values into the metadata object, making messages static,
and renaming 'error' metadata keys to 'err'. Affected log-message
assertions in co-located specs are updated accordingly.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* ci: ignore validator output

* fixup new merged in log messages

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-16 06:53:37 +00:00
Nikolay Frantsev a602d166a5 feat(bitbucket): add draft PRs support (#43965) 2026-07-11 05:53:46 +00:00
Sebastian Poxhofer ad0b59f8b7 refactor(oxlint): enable vitest/require-to-throw-message (#44421) 2026-07-07 17:47:04 +00:00
Sebastian Poxhofer aac8365dd6 refactor(oxlint): enable vitest/prefer-snapshot-hint (#44420)
Add distinct hints to the multi-snapshot tests flagged by the rule
and regenerate the affected snapshot files, then re-enable the rule.

Part of #43845

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-07 16:35:22 +00:00
relnah 413dcddc1f fix(platform/bitbucket): replace deprecated cross-workspace repos endpoint (#42134)
* fix(platform/bitbucket): replace deprecated cross-workspace repos endpoint

The GET /2.0/repositories?role=contributor endpoint is being removed by
Bitbucket Cloud on 2026-03-31 (CHANGE-2770). Replace it with per-workspace
calls to GET /2.0/repositories/{workspace}.

When autodiscoverNamespaces is set, those values are used directly as
workspace slugs. Otherwise the current user's workspaces are first
discovered via GET /2.0/user/workspaces (the non-deprecated replacement
for GET /2.0/workspaces) and repositories are then fetched per workspace.

* fix(platform/bitbucket): address review comments

- Use z.array instead of LooseArray for WorkspaceAccesses schema
- Limit workspace fetch concurrency via promises.map
- Align test workspace slugs with reviewer suggestions

* fix(platform/bitbucket): address review comments

- Use z.array instead of LooseArray for WorkspaceAccesses schema
- Limit workspace fetch concurrency via promises.map
- Align test workspace slugs with reviewer suggestions

* fix(platform/bitbucket): restore original repo names in negation test
2026-03-26 16:47:51 +00:00
Adam Setch 579ff4c2ba feat: hyperlink warnings to dep dashboard (#40395)
* feat: hyperlink warnings to dep dashboard

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* feat: hyperlink warnings to dep dashboard

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* feat: hyperlink warnings to dep dashboard

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* feat: hyperlink warnings to dep dashboard

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* add tests

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* update tests

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* Merge branch 'main' into feat/hyperlink-dashboard

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* updated forgejo smartLinks

Signed-off-by: Adam Setch <adam.setch@outlook.com>

---------

Signed-off-by: Adam Setch <adam.setch@outlook.com>
2026-02-20 15:19:35 +00:00
renovate[bot] e752a3db29 build(deps): update dependency got to v14 (main) (#41302)
* build(deps): update dependency got to v14

| datasource | package | from   | to     |
| ---------- | ------- | ------ | ------ |
| npm        | got     | 12.6.1 | 14.6.6 |

* test: fix tests

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
2026-02-19 17:50:48 +00:00
RahulGautamSingh 26f4fee6cc refactor: move bbUseDevelopmentBranch to InheritConfig.OPTIONS (#40890)
* move bbUseDevelopmentBranch to InheritConfig.OPTIONS

* fix import extension

* fix import order
2026-02-15 08:15:12 +00:00
Sergei Zharinov 9d857c1f68 refactor(lint): Organize imports with biome (#40966) 2026-02-06 13:40:01 +00:00
Sergei Zharinov 930cf6633c refactor: Rewrite imports with .ts extensions (#40700)
fix: Additional vi.mock path corrections and prettier formatting
2026-01-26 22:48:17 +00:00
Adam Setch eec42ca57d fix(bitbucket): massage codeblock markdown (#40346)
* fix(bitbucket): /massage codeblock markdown

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* fix(bitbucket): massage codeblock markdown

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* fix(bitbucket): massage codeblock markdown

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* fix(bitbucket): massage codeblock markdown

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* Update index.ts

* fix(bitbucket): massage codeblock markdown

Signed-off-by: Adam Setch <adam.setch@outlook.com>

---------

Signed-off-by: Adam Setch <adam.setch@outlook.com>
2026-01-15 16:26:01 +00:00
Adam Setch 54d0edc750 fix(bitbucket): update indentation regex (#40359)
* fix(bitbucket): update regex to match multiline new lines

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* fix(bitbucket): update regex to match multiline new lines

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* Update index.ts

* update test to cover unordered lists in release notes

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* update test to cover unordered lists in release notes

Signed-off-by: Adam Setch <adam.setch@outlook.com>

---------

Signed-off-by: Adam Setch <adam.setch@outlook.com>
2026-01-15 12:06:02 +00:00
Adam Setch 5c19dd608d feat(dashboard): add heading for abandoned deps section (#40381)
* feat(dashboard): heading for abandoned deps section

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* feat(dashboard): heading for abandoned deps section

Signed-off-by: Adam Setch <adam.setch@outlook.com>

---------

Signed-off-by: Adam Setch <adam.setch@outlook.com>
2026-01-12 15:30:33 +00:00
Adam Setch 3854945c6a fix(bitbucket): markdown massaging for release notes (#40344)
Signed-off-by: Adam Setch <adam.setch@outlook.com>
2026-01-09 07:36:10 +00:00
Adam Setch aacb0261b4 feat(bitbucket): massage markdown for collapsible sections section (#39720)
* feat(bitbucket): massage markdown for detected deps section

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* feat: add totals to detected dependency summaries

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* Revert "feat: add totals to detected dependency summaries"

This reverts commit f76631a36d.

* collapsible formatting

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* collapsible formatting

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* collapsible formatting

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* collapsible formatting

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* collapsible formatting

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* collapsible formatting

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* collapsible formatting

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* update test

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* collapsible formatting

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* collapsible formatting

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* collapsible formatting

Signed-off-by: Adam Setch <adam.setch@outlook.com>

---------

Signed-off-by: Adam Setch <adam.setch@outlook.com>
2025-12-15 08:51:15 +00:00
Adam Setch e8f77e5926 fix(bitbucket): abandoned dependencies section heading formatting (#39817)
* fix: more targeted movement of note

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* fix: more targeted movement of note

Signed-off-by: Adam Setch <adam.setch@outlook.com>

---------

Signed-off-by: Adam Setch <adam.setch@outlook.com>
2025-12-09 21:51:23 +00:00
Adam Setch 68baaa2856 refactor(dashboard): consistently use title case for headings (#39754)
* refactor(dashboard): proper-case section headings

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* refactor(dashboard): proper-case section headings

Signed-off-by: Adam Setch <adam.setch@outlook.com>

---------

Signed-off-by: Adam Setch <adam.setch@outlook.com>
2025-12-04 13:55:44 +00:00
Adam Setch b9da569bf0 feat(bitbucket): massage issue markdown for abandoned deps section (#39717)
* feat(bitbucket): massage markdown for abandoned deps section

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* feat(bitbucket): massage markdown for abandoned deps section

Signed-off-by: Adam Setch <adam.setch@outlook.com>

---------

Signed-off-by: Adam Setch <adam.setch@outlook.com>
2025-12-03 08:32:57 +00:00
Adam Setch 079350743a refactor(bitbucket): compare issue type when determining whether to update existing issues (#39571)
* refactor(bitbucket): issue update consider issue type

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* refactor(bitbucket): issue update consider issue type

Signed-off-by: Adam Setch <adam.setch@outlook.com>

* refactor(bitbucket): issue update consider issue type

Signed-off-by: Adam Setch <adam.setch@outlook.com>

---------

Signed-off-by: Adam Setch <adam.setch@outlook.com>
2025-11-26 17:45:00 +00:00
renovate[bot] b4ed9e65d9 chore(deps): update dependency @vitest/eslint-plugin to v1.3.23 (main) (#38702)
* chore(deps): update dependency @vitest/eslint-plugin to v1.3.23

| datasource | package               | from   | to     |
| ---------- | --------------------- | ------ | ------ |
| npm        | @vitest/eslint-plugin | 1.3.16 | 1.3.23 |

* remove now unnecessary exceptions

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: secustor <sebastian@poxhofer.at>
2025-10-31 07:50:48 +00:00
renovate[bot] 1280fe4dc7 chore(deps): update dependency @vitest/eslint-plugin to v1.3.16 (main) (#38502)
* chore(deps): update dependency @vitest/eslint-plugin to v1.3.16

| datasource | package               | from   | to     |
| ---------- | --------------------- | ------ | ------ |
| npm        | @vitest/eslint-plugin | 1.3.13 | 1.3.16 |

* fix linting errors

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: secustor <sebastian@poxhofer.at>
2025-10-13 09:24:15 +00:00
Sergei Zharinov ad48b22d3b feat(bitbucket): Better cache invalidation for branch status cache (#38084) 2025-09-18 19:36:43 +00:00
Schuman Zhang 7c4038494a feat: add support for Bitbucket API tokens (#36614) 2025-06-23 08:19:23 +00:00
Michael Kriese 19c115c813 test: cleanup (#34785) 2025-03-13 17:52:09 +00:00
Michael Kriese 4f60a8b7fe test: mock git globally (#34783) 2025-03-13 15:48:02 +00:00
Michael Kriese 997c23502e test: migrate to vitest (#34475)
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
2025-02-26 09:35:54 +00:00
Sergei Zharinov 318caf1994 test(bitbucket): Fix the tests performance (#34407) 2025-02-23 13:48:33 +00:00
RahulGautamSingh 3ee48571b0 fix(platform/bitbucket): ensure getPrList() runtime integrity (#32970) 2024-12-18 05:13:53 +00:00
RahulGautamSingh 8a52e50b3f test(gitlab): fix cache mock (#32969) 2024-12-08 07:24:49 +00:00
Adam Setch 021db4bf0b fix: Revert "fix(bitbucket): source link root path" (#32680) 2024-11-22 16:48:52 +00:00
Adam Setch b7951c3c0a fix(bitbucket): source link root path (#32676)
Signed-off-by: Adam Setch <adam.setch@outlook.com>
2024-11-22 16:13:03 +00:00
Daniel Barrett 07169cdfbc feat(bitbucket): support task autocomplete (#30901)
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Rhys Arkins <rhys@arkins.net>
2024-09-21 19:16:38 +00:00
RahulGautamSingh 4b502025fe refactor: rename platformOptions -> platformPrOptions (#30173) 2024-07-16 07:33:55 +00:00
Sergei Zharinov b0ea9156da fix(bitbucket): Use schema for repo result validation (#27855) 2024-03-18 21:50:22 +00:00
RahulGautamSingh 11b3c59215 feat(platform/bitbucket): autodiscoverProjects (#27845)
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
2024-03-14 09:49:21 +00:00
Rhys Arkins 59df10183a feat(platform): getRepoForceRebase -> getBranchForceRebase (#27052)
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
2024-02-06 09:14:11 +00:00
Sergei Zharinov 597167ae2e feat(bitbucket): Implement PR cache for repositories (#26345) 2024-01-04 07:43:18 +00:00
RahulGautamSingh 5f163552a9 fix(reconfigure/pr): find reconfigure pr separately (#25954)
Co-authored-by: Rhys Arkins <rhys@arkins.net>
2023-12-29 12:55:11 +00:00
Sergei Zharinov e80b882156 feat(bitbucket): Server-side filtering of PR list response (#26336) 2023-12-16 18:08:13 +00:00
Sergei Zharinov b69416ce17 refactor(prettier): Force trailing commas (#25631) 2023-11-07 15:50:29 +00:00
Michael Kriese 84a97a62fa test(perf): improve test speed (#24323) 2023-09-08 11:40:04 +00:00
Adam Setch ed182aa67b feat(platform/bitbucket): support reopening declined PRs via comments (#22984) 2023-07-02 16:19:09 +00:00
RahulGautamSingh 4180370e01 feat(platform): update PR target branch if baseBranch changed (#23010) 2023-07-01 14:58:34 +00:00
Adam Setch 96c06e58e6 feat(platform/bitbucket): handle author is also default reviewer (#22978) 2023-06-26 11:33:24 +00:00
Adam Setch 06f71346cd feat(bitbucket): add support for pagelen (#22278) 2023-05-20 05:43:00 +00:00