When reporting config validation issues, we generally use the same
constants for our validation errors/warnings.
Instead of having these strings duplicated everywhere, we can refactor
these into constants, making it clearer when reading the code.
We can retain a "soft" union for cases where we use a dynamically
generated topic, which we won't know ahead of time.
Co-authored-by: Claude Opus 4.8 <jamie.tanna+claude-code@mend.io>
Enable no-else-return (with allowElseIf: false) and unicorn/no-lonely-if
as errors in .oxlintrc.json and fix all 131 pre-existing violations
(91 no-else-return, 40 unicorn/no-lonely-if) across 98 files.
The no-else-return violations were fixed with the oxlint autofix
(iterated to a fixpoint, plus two else-if chains that required
--fix-dangerously) followed by Prettier formatting. One comment dropped
by the autofix in lib/modules/manager/pub/artifacts.ts was restored
manually. The unicorn/no-lonely-if violations were merged by hand,
preserving comments and coverage-ignore hints.
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Jamie Tanna