mirror of
https://github.com/rcourtman/Pulse.git
synced 2026-09-20 18:23:47 +00:00
rcourtman
fb293169f7
Before this change, all three dismissal reasons funnelled through the same "swallow re-detection at same/lower severity" path in FindingsStore.Add, so will_fix_later was functionally identical to expected_behavior — Pulse stayed quiet forever despite the dismiss_finding tool literally telling the LLM "Pulse Patrol will continue to monitor this issue." Now will_fix_later sets Finding.RemindAt (default 7 days) at dismissal time. Once RemindAt has passed, the next re-detection clears the dismissal and emits a `reminded` lifecycle event so the operator sees their lapsed commitment instead of a swallowed finding. expected_behavior keeps acknowledged-forever semantics; not_an_issue keeps Suppressed=true. The LLM tool response now surfaces the remind-at date so Patrol's conversational explanations stay aligned with the contract.