mirror of
https://github.com/rcourtman/Pulse.git
synced 2026-09-24 20:22:53 +00:00
courtmanr@gmail.com
f21d05e3cb
Two clusters at different sites that reuse the same corosync cluster name and the same RFC1918 addressing presented colliding member IPs, which ConsolidatePVEInstances took as strong endpoint overlap and folded the second site's connection into the first. The standalone-into-cluster merge had the same hole for a standalone whose address collides with a cluster endpoint at another site. The v6.1.1 node-aggregation guard never fires in this case because it keys on cluster-name conflict, and same-name clusters do not conflict. Address coincidence is weak evidence across sites, but the TOFU-captured TLS certificate fingerprints already stored on instances and cluster endpoints are strong evidence: contradicting fingerprints for the same authority, node name, or endpoint address mean different machines. Consolidation now refuses to merge in that case. The fail-safe direction is deliberate - a certificate rotation may leave a genuinely duplicated cluster as two views, but two distinct clusters are never silently folded into one. Reported via support by an MSP whose two customer clusters kept merging after the v6.1.1 aggregation fix. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>