Files
pulse/internal/monitoring/monitor_storage_webhook_test.go
T
pulse-triage[bot] 6ffc02e5c5 Verify storage gap containment through the notification queue
Use the production Monitor callback wiring and a guest-local receiver to require fresh confirmed recovery before a resolved webhook. Preserve occurrence identity and validate queue completion without native-service claims.

Change-source: pulse-maintainer
2026-10-07 08:59:42 +01:00

236 lines
7.5 KiB
Go

package monitoring
import (
"encoding/json"
"net/http"
"net/http/httptest"
"strings"
"testing"
"time"
"github.com/rcourtman/pulse-go-rewrite/internal/alerts"
"github.com/rcourtman/pulse-go-rewrite/internal/models"
"github.com/rcourtman/pulse-go-rewrite/internal/notifications"
)
// Synthetic storage observations and a local receiver exercise the production
// callback/queue path. This does not qualify an installed PBS poller or image.
func TestStorageEmptyRecoveryWebhook(t *testing.T) {
type payload struct {
Event string `json:"event"`
Alerts []alerts.Alert `json:"alerts"`
}
received := make(chan payload, 16)
receiver := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
var p payload
if r.Method != http.MethodPost || json.NewDecoder(r.Body).Decode(&p) != nil {
t.Error("invalid webhook request")
http.Error(w, "invalid request", http.StatusBadRequest)
return
}
select {
case received <- p:
default:
t.Error("unexpected webhook flood")
}
w.WriteHeader(http.StatusOK)
}))
defer receiver.Close()
nm := notifications.NewNotificationManagerWithDataDir("", t.TempDir())
defer nm.Stop()
nm.SetGroupingWindow(0)
nm.SetNotifyOnResolve(true)
if err := nm.UpdateAllowedPrivateCIDRs("127.0.0.1/32"); err != nil {
t.Fatal(err)
}
nm.AddWebhook(notifications.WebhookConfig{ID: "local-receiver", Name: "local-receiver", URL: receiver.URL, Enabled: true})
manager := alerts.NewManagerWithDataDir(t.TempDir())
defer manager.Stop()
manager.UpdateConfig(alerts.AlertConfig{Enabled: true, ActivationState: alerts.ActivationActive,
TimeThresholds: map[string]int{"storage": 0}, StorageDefault: alerts.HysteresisThreshold{Trigger: 80, Clear: 70}})
monitor := newPBSHealthAuthorityMonitor(nil)
monitor.alertManager, monitor.notificationMgr = manager, nm
monitor.wireExternalAlertCallbacks(nil)
receive := func() payload {
t.Helper()
select {
case p := <-received:
return p
case <-time.After(5 * time.Second):
t.Fatal("webhook not received")
return payload{}
}
}
waitSent := func(want int) {
t.Helper()
deadline := time.Now().Add(5 * time.Second)
for time.Now().Before(deadline) {
entries, err := nm.GetDeliveryLog(time.Time{}, 20)
if err != nil {
t.Fatal(err)
}
sent := 0
for _, e := range entries {
if e.Success {
sent++
}
}
if sent == want {
return
}
time.Sleep(10 * time.Millisecond)
}
t.Fatalf("did not record %d successful deliveries", want)
}
storage := models.Storage{ID: "pbs-test-backups", Name: "backups", Type: "pbs", Status: "online", Total: 1000, Used: 850, Free: 150, Usage: 85}
for range 5 {
manager.CheckStorage(storage)
}
firing := receive()
if len(firing.Alerts) != 1 || firing.Alerts[0].Type != "usage" || firing.Event == "resolved" {
t.Fatalf("unexpected firing: %+v", firing)
}
incident := firing.Alerts[0]
waitSent(1)
// Missing free capacity must not masquerade as a measured empty store.
storage.Usage, storage.Used, storage.Free = 0, 0, 0
for range 5 {
manager.CheckStorage(storage)
}
if len(manager.GetActiveAlerts()) != 1 || manager.GetResolvedAlert(incident.ID) != nil {
t.Fatal("missing capacity fabricated recovery")
}
select {
case p := <-received:
t.Fatalf("missing capacity sent webhook: %+v", p)
case <-time.After(150 * time.Millisecond):
}
storage.Free = 1000
for range 5 {
manager.CheckStorage(storage)
}
recovery := receive()
if recovery.Event != "resolved" || len(recovery.Alerts) != 1 {
t.Fatalf("unexpected recovery: %+v", recovery)
}
resolved := recovery.Alerts[0]
if resolved.ID != incident.ID || !resolved.StartTime.Equal(incident.StartTime) || resolved.Value != 0 || !resolved.LastSeen.After(incident.LastSeen) || !strings.Contains(resolved.Message, "0.0%") || !strings.HasPrefix(resolved.Message, "Resolved: ") {
t.Fatalf("incorrect clearing payload: %+v", resolved)
}
waitSent(2)
history := manager.GetResolvedAlert(incident.ID)
if history == nil || history.Value != 0 || history.Message != resolved.Message {
t.Fatalf("incorrect history: %+v", history)
}
for range 5 {
manager.CheckStorage(storage)
}
select {
case p := <-received:
t.Fatalf("duplicate webhook: %+v", p)
case <-time.After(150 * time.Millisecond):
}
}
// The callback and durable queue must not tell a receiver that an outage has
// recovered by joining healthy observations across missing status evidence.
func TestStorageConnectivityGapWebhook(t *testing.T) {
type payload struct {
Event string `json:"event"`
Alerts []alerts.Alert `json:"alerts"`
}
received := make(chan payload, 8)
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
defer r.Body.Close()
var p payload
if r.Method != http.MethodPost || json.NewDecoder(r.Body).Decode(&p) != nil {
t.Error("invalid webhook request")
http.Error(w, "invalid request", http.StatusBadRequest)
return
}
received <- p
w.WriteHeader(http.StatusOK)
}))
defer server.Close()
nm := notifications.NewNotificationManagerWithDataDir("", t.TempDir())
defer nm.Stop()
nm.SetGroupingWindow(0)
nm.SetNotifyOnResolve(true)
if err := nm.UpdateAllowedPrivateCIDRs("127.0.0.1/32"); err != nil {
t.Fatal(err)
}
nm.AddWebhook(notifications.WebhookConfig{ID: "storage-gap", URL: server.URL, Enabled: true})
manager := alerts.NewManagerWithDataDir(t.TempDir())
defer manager.Stop()
manager.UpdateConfig(alerts.AlertConfig{Enabled: true, ActivationState: alerts.ActivationActive,
TimeThresholds: map[string]int{"storage": 0}, StorageDefault: alerts.HysteresisThreshold{Trigger: 80, Clear: 70}})
monitor := newPBSHealthAuthorityMonitor(nil)
monitor.alertManager, monitor.notificationMgr = manager, nm
monitor.wireExternalAlertCallbacks(nil)
take := func() payload {
t.Helper()
select {
case p := <-received:
return p
case <-time.After(5 * time.Second):
t.Fatal("missing webhook receipt")
return payload{}
}
}
quiet := func() {
t.Helper()
select {
case p := <-received:
t.Fatalf("unconfirmed recovery sent a webhook: %+v", p)
case <-time.After(150 * time.Millisecond):
}
}
storage := models.Storage{ID: "pbs-gap-backups", Name: "backups", Type: "pbs", Status: "unavailable"}
for range 2 {
manager.CheckStorage(storage)
}
fired := take()
if fired.Event == "resolved" || len(fired.Alerts) != 1 || fired.Alerts[0].Type != "offline" {
t.Fatalf("unexpected firing receipt: %+v", fired)
}
original := fired.Alerts[0]
storage.Status = "available"
manager.CheckStorage(storage)
storage.Status = "unknown"
manager.CheckStorage(storage)
storage.Status = "available"
manager.CheckStorage(storage)
active := manager.GetActiveAlerts()
if len(active) != 1 || active[0].ID != original.ID || !active[0].StartTime.Equal(original.StartTime) {
t.Fatalf("non-consecutive recovery changed the original outage: %+v", active)
}
quiet()
manager.CheckStorage(storage)
recovered := take()
if recovered.Event != "resolved" || len(recovered.Alerts) != 1 || recovered.Alerts[0].ID != original.ID || !recovered.Alerts[0].StartTime.Equal(original.StartTime) {
t.Fatalf("bad confirmed-recovery receipt: %+v", recovered)
}
deadline := time.Now().Add(5 * time.Second)
for {
stats, err := nm.GetQueueStats()
if err != nil {
t.Fatal(err)
}
if stats["pending"]+stats["sending"] == 0 {
if stats["failed"]+stats["dlq"] != 0 {
t.Fatalf("notification delivery failed: %v", stats)
}
break
}
if time.Now().After(deadline) {
t.Fatalf("notification queue did not drain: %v", stats)
}
time.Sleep(time.Millisecond)
}
for range 3 {
manager.CheckStorage(storage)
}
quiet()
}