mirror of
https://github.com/rcourtman/Pulse.git
synced 2026-10-25 21:20:00 +00:00
rcourtman
acd353f30f
## What was wrong On the Patrol page's Activity tab (Finding options and history), an open finding review threw the reader back to the top of the page: - on opening the review (1389px to 0 at 1024x768), - on opening its investigation thread, - on Re-investigate and on each 5-second poll of a running investigation, - on every 30s app-shell and 60s Patrol-page findings reload (a reader at 2715px dropped to 0 at about 25s and again at 55s). Each reload parsed new finding objects, so `FindingsPanel` rebuilt every row and remounted the open review. The review read its investigation with `createResource`, and the nearest `<Suspense>` above it is the route boundary in `AppLayout.tsx`. Its "Loading view..." fallback replaced the whole page, so the scroll shell's content collapsed and its position clamped to 0. The rebuild also closed the review's thread and reset its inner scroll. Separately, the API returns tied findings in no fixed order, so rows swapped places between polls. ## What changed - **Findings store:** a read that returns a finding unchanged keeps its object, and a read that changes nothing keeps the list. - **FindingsPanel:** - keeps display groups whose findings did not change (`reuseIdenticalPatrolFindingDisplayGroups`); - breaks sort ties by finding id; - passes the open review its related findings through a getter, so it redraws only when its own finding changes; - reads row and review ages from the shared relative-time clock (they had only moved because rows were rebuilt). - **InvestigationSection, ApprovalSection, InvestigationMessages:** read through `createNonSuspendingQuery` instead of `createResource`. Refreshes no longer remount them, so they re-read on their own: - the investigation and its governed action every 30s, and the investigation every 5s while it runs; - the thread every 5s while the run is live, once more when it finishes, and 30s after a failed read. A failed read keeps the last answer; only a 404 means "no investigation". Re-investigate waits for the first read. The thread is keyed by the run's session and keeps unchanged message rows, along with any expanded tool output. - **`createNonSuspendingQuery`:** `pollMs` also accepts an accessor, so a cadence can follow state through the hook's protected poll path, which never replaces a slow read still in flight. The numeric path is unchanged. - **RunToolCallTrace:** moves to the same query. It did not suspend before (its reads checked `loading` first), so this is for consistency, not a fix. - **Contracts:** notes in `patrol-intelligence.md` (Forbidden Paths 6 and a Current State note) and `frontend-primitives.md`. ## Verification - **Browser.** Private Pulse Pro stack (enterprise binary built from main, seeded Patrol findings and investigation sessions), headless Chromium at 1024x768, 1440x900 and 390x844: - Opening a review keeps the page where it was. - Over 70s with the review open (two 30s reloads, one 60s reload and a 30s re-read of the investigation) the page stays put: no fallback, no row or review content rebuilt, rows in the same order, the thread still open and the review's inner scroll unchanged. - A 150-second watch with unchanged findings moved no row. - Main at 1024x768: 1389px to 0 on open, 2715px to 0 at about 25s and 55s, and the row and review content rebuilt three times in 70s. - Receipt: `frontend-modern/browser-verification/14b0b05ccd7e4c6f.json`. - **Tests.** - New `FindingsPanel.refresh.test.tsx` drives the real store, panel and review sections under a Suspense boundary. - Also adds to the store, display-group, hook and four component tests. - Negative controls: every new test fails against main's runtime files. Reverting any one layer (store, panel or sections) fails the refresh test. Main's hook fails the cadence, retry and live-thread tests. Removing the message reuse or the final thread read fails their tests. - **Checks.** - Targeted suites (60 files, 1267 tests), type-check, the full `npm run lint` chain and Prettier pass. - The full frontend suite passed except one 5-second timeout in `dependencyTooling.test.ts` under heavy load, which passes on its own. - Committed with the pre-commit hooks. ## Follow-ups, not changed here - The API still returns tied findings in no fixed order: `GetAllFindings` and `GetAllFindingsIncludingResolved` use `sort.Slice` over map iteration. The panel no longer depends on that order. - A change to the open finding itself still redraws its review, which closes the thread, but the page no longer moves. - Below 1280px the review renders under the whole findings list, so opening one from a row far down leaves it out of view until the reader scrolls.
Pulse documentation
Start here for installation, platform setup, security, operations, and Pulse Intelligence. Commands, configuration keys, image names, API fields, and product identifiers remain untranslated in localized guides.
Need help with a failure? Read the safe reporting guidance before sharing evidence. A second reproduction or diagnostics export is not required; keep the original evidence if another attempt could interrupt workloads or send duplicate notifications. GitHub reports and attachments are public: review them locally and keep credentials and private details out.
Start here
- Install Pulse — signed Proxmox/Linux installation, Docker, Docker Compose, Kubernetes, and first-run setup.
- Production deployment and security — least-privilege Proxmox setup, root-agent boundaries, discovery, supply-chain verification, plan limits, scale evidence, and a rollout checklist.
- Upgrade from Pulse v5 — migration prerequisites, rollback, agent continuity, and post-upgrade checks.
- Releases and update channels: choosing Stable or Preview, beta and RC expectations, and how releases are tested and promoted.
- Configure Pulse — authentication, notifications, discovery, retention, and system settings.
- Deployment models — data locations, lifecycle, and differences between supported deployment paths.
- Troubleshooting and FAQ — common failures, diagnostics, and operator questions.
Localized getting started guides: Deutsch · Español
Platforms and agents
- Proxmox Backup Server
- Proxmox Mail Gateway
- Docker and Podman
- Kubernetes and Helm
- TrueNAS SCALE and CORE
- Unified Agent
- Agent security
- VM disk monitoring
- ZFS monitoring
- Temperature monitoring
VMware vSphere support is early access. Current builds expose dedicated vSphere inventory and recovery context, but operators should validate the integration against their own vCenter before production use.
Monitoring and operations
- Metrics history
- Recovery data
- Webhooks
- Automatic updates
- Centralized agent management (Pro)
- Operational trust model
- Current product screenshots
Pulse Intelligence
- Assistant, Patrol, and external-agent overview
- Patrol modes and safety
- Assistant safety model
- External agent HTTP and MCP substrate
Patrol watch-only analysis is available on Community with a local model or the operator's own provider. Investigation and governed fixes require the relevant Pulse Pro capabilities.
Security, privacy, and access
- Production deployment and security
- Security review scope
- Authentication and credential storage review packet
- Security guide
- Privacy and telemetry disclosure
- OIDC and SSO
- Proxy authentication
- Role-based access control (Pro)
- Audit logging (Pro)
- Reverse proxy configuration
- Code-signing policy
Plans and managed access
- Community, Relay, and Pro capabilities
- Relay and Pulse Mobile handoff
- Multi-tenant organizations (Enterprise/custom)
- Provider-hosted MSP operations (request-assisted)
Pulse Cloud is not generally available. Ordinary self-hosted Pulse remains the primary installation path; MSP and Enterprise access are explicit commercial paths rather than defaults in self-hosted setup.
Development and reference
Detailed design notes and dated migration specifications may remain in this directory for maintainers, but they are not operator setup guides unless they are linked from the sections above.
Previous versions and migrations
- Upgrade from v4 to v5
- Retired unified-navigation migration — historical context only; current Pulse uses platform-shaped navigation.
- Move a Pulse installation
Found a bug? Use the issue forms. For setup questions, use GitHub Discussions.