mirror of
https://github.com/rcourtman/Pulse.git
synced 2026-09-11 14:00:29 +00:00
rcourtman
a982456189
Fixed critical argument mismatch bug where fmt.Sprintf arguments didn't align with template placeholders. This caused: - authToken being passed where pulseURL expected (curl errors) - pulseURL being passed where authToken expected (empty Authorization headers) - tokenName misalignment (Token ID placeholder broken) Root cause: Template has 51 %s placeholders (54 total - 3 escaped %%s), but argument list had wrong count and ordering. Solution: Rebuilt argument list (lines 5049-5059) with correct mapping: - 27 pulseURL (all installer URLs, --pulse-server flags, API endpoints) - 11 tokenName (token creation, checks, final Token ID) - 3 authToken (AUTH_TOKEN variable + 2 Authorization headers) - 3 serverHost (error message rerun hints) - 1 each: serverName, time, pulseIP, storagePerms, SSH keys, minProxyReadyVersion Verified with go vet (passes). Mapping confirmed by walking each placeholder in template and matching to correct argument type. Related to #TBD (user will test)
Internal API Package
This directory contains the API server implementation for Pulse.
Important Note About frontend-modern/
The frontend-modern/ subdirectory that appears here is:
- AUTO-GENERATED during builds
- NOT the source code - just a build artifact
- IN .gitignore - never committed
- REQUIRED BY GO - The embed directive needs it here
Frontend Development Location
👉 Edit frontend files at: /opt/pulse/frontend-modern/src/
Why This Structure?
Go's //go:embed directive has limitations:
- Cannot use
../paths to access parent directories - Cannot follow symbolic links
- Must embed files within the Go module
This is a known Go limitation and our structure works around it.