mirror of
https://github.com/rcourtman/Pulse.git
synced 2026-09-23 19:57:09 +00:00
rcourtman
80d4558b42
The Recovery and Snapshot Age threshold sections rendered two Global Defaults surfaces at once, the live editor row plus a synthetic read-only resource row of the same values. Both looked editable but the synthetic row's pencil editor saved through findThresholdResource, which never finds the pseudo-resource, so its edits were dropped silently. Reported in #1680 by FabienD74. The synthetic rows are gone; the always-live editor row is the single surface in both table and card layouts. The dead editScope field and its unreachable saveEdit branches go with them. The size columns move from Recovery to Snapshot Age where they belong. BackupAlertConfig has no size fields, so on Recovery they always rendered an inert Off. SnapshotAlertConfig sizes are live in the alert engine (backup_snapshot.go) but were previously invisible and, worse, unpersistable. The records now carry the normalized warningSizeGiB and criticalSizeGiB metric keys the column editor reads and writes, and applyAlertsConfigToSnapshot plus buildAlertsConfigurationPayload carry the size fields through load and save instead of stripping them. Verified end to end against the mock dev stack, PUT then GET returns the saved sizes and a reload shows them. Guests in the VMs & Containers section now sort by display name with vmid as tiebreaker. The old vmid-first order looked random because the rows do not render the vmid, which is what the sorting complaint in #1680 was about. Dropping the phantom columns and the per-row bulk-edit checkbox also brings the Recovery table under the desktop width budget, so it renders as a table at 1280px and up instead of falling back to cards.