mirror of
https://github.com/rcourtman/Pulse.git
synced 2026-10-26 13:39:47 +00:00
rcourtman
7c29ec63e3
Commita5baa7563bstopped Patrol reading cache-inclusive Proxmox memory as guest pressure (issue #2762, a QEMU VM). It also put `cluster-resources` in that cache-inclusive group for every guest type. An LXC without a linked Pulse agent only ever gets `cluster-resources`, so Patrol dropped memory pressure for all agentless containers: - a container at 97% of its limit got no triage flag, forecast or anomaly - the seed said "guest pressure unknown; may include reclaimable cache" - older memory alerts went to a billed model review on every run, and any resolve verdict was thrown away **That premise is wrong for LXC.** On both PVE 9 (`master`) and PVE 8 (`stable-bookworm` / `stable-8`), Proxmox subtracts page cache before reporting a container's memory: - `pve-common` `src/PVE/CGroup.pm` `get_memory_stat`: `$res->{mem} = $mem - $stat->{file};` on cgroup v2 (`memory.current`), and `$res->{mem} = $mem - $stat->{total_cache};` on v1 (`memory.usage_in_bytes`). - `pve-container` `src/PVE/LXC.pm` `vmstatus` stores that value with `$d->{mem} = int($mem->{mem});`. `PVE::LXC::CGroup` inherits `get_memory_stat` from `PVE::CGroup` without overriding it. - `pve-manager` `pvestatd` `update_lxc_status` writes `$d->{mem}` into RRD field 8. `/cluster/resources` (`PVE/API2/Cluster.pm` → `PVE::API2Tools::extract_vm_stats`) returns `$entry->{mem} = ($d->[8] || 0) + 0;`. A QEMU guest's listing `mem` is the host's view of guest RAM, which does include the guest's cache, so it stays pressure-unknown. **Change** - `unifiedresources.QualifyGuestMemoryForKind` now takes the guest kind: other platform, Proxmox VM or Proxmox container. - A current, dated `cluster-resources` reading counts as known pressure for a Proxmox container and stays cache-inclusive and unknown for QEMU. - `status-mem`, `status-freemem` and `derived-total-minus-used` are unchanged for every guest type. - `GuestMemoryEvidenceForResource` takes the kind from the resource type, so the Patrol inventory, the observer runtime and AI query projections agree. - `QualifyGuestMemory(bool)` keeps the conservative QEMU reading for callers that don't know the guest type. - The wrong comments in `calculateLXCMemory` and the LXC monitor tests are corrected. - Everything else ina5baa7563bstill applies: retained, undated, unknown and unavailable readings still cannot establish pressure or recovery. **Tests** - `TestPatrolAgentlessLXCListingMemoryIsPressure` (new) builds an LXC and a QEMU guest at 97%, both on `cluster-resources`, through legacy and canonical read state. The LXC gets a memory triage flag and alert review reads its value; the QEMU guest gets neither. - `TestGuestMemoryClusterResourcesIsTypeAware` (new) covers both guest kinds, retained readings, the other cache-inclusive sources and the resource-type mapping. - The `cluster-cache` fixture in `TestPatrolGuestMemoryEvidence` now expects pressure for the container variant. It previously encoded the wrong behaviour. - Against origin/main's production files (`go test -overlay`), the new and updated Patrol tests fail; with this change they pass. Refs #2762 Supersedes #3011, which failed the documentation recipe test that pinned the old `QualifyGuestMemory(` call in Patrol; this commit also updates that pin to `QualifyGuestMemoryForKind(`.
Pulse documentation
Start here for installation, platform setup, security, operations, and Pulse Intelligence. Commands, configuration keys, image names, API fields, and product identifiers remain untranslated in localized guides.
Need help with a failure? Read the safe reporting guidance before sharing evidence. A second reproduction or diagnostics export is not required; keep the original evidence if another attempt could interrupt workloads or send duplicate notifications. GitHub reports and attachments are public: review them locally and keep credentials and private details out.
Start here
- Install Pulse — signed Proxmox/Linux installation, Docker, Docker Compose, Kubernetes, and first-run setup.
- Production deployment and security — least-privilege Proxmox setup, root-agent boundaries, discovery, supply-chain verification, plan limits, scale evidence, and a rollout checklist.
- Upgrade from Pulse v5 — migration prerequisites, rollback, agent continuity, and post-upgrade checks.
- Releases and update channels: choosing Stable or Preview, beta and RC expectations, and how releases are tested and promoted.
- Configure Pulse — authentication, notifications, discovery, retention, and system settings.
- Deployment models — data locations, lifecycle, and differences between supported deployment paths.
- Troubleshooting and FAQ — common failures, diagnostics, and operator questions.
Localized getting started guides: Deutsch · Español
Platforms and agents
- Proxmox Backup Server
- Proxmox Mail Gateway
- Docker and Podman
- Kubernetes and Helm
- TrueNAS SCALE and CORE
- Unified Agent
- Agent security
- VM disk monitoring
- ZFS monitoring
- Temperature monitoring
VMware vSphere support is early access. Current builds expose dedicated vSphere inventory and recovery context, but operators should validate the integration against their own vCenter before production use.
Monitoring and operations
- Metrics history
- Recovery data
- Webhooks
- Automatic updates
- Centralized agent management (Pro)
- Operational trust model
- Current product screenshots
Pulse Intelligence
- Assistant, Patrol, and external-agent overview
- Patrol modes and safety
- Assistant safety model
- External agent HTTP and MCP substrate
Patrol watch-only analysis is available on Community with a local model or the operator's own provider. Investigation and governed fixes require the relevant Pulse Pro capabilities.
Security, privacy, and access
- Production deployment and security
- Security review scope
- Authentication and credential storage review packet
- Security guide
- Privacy and telemetry disclosure
- OIDC and SSO
- Proxy authentication
- Role-based access control (Pro)
- Audit logging (Pro)
- Reverse proxy configuration
- Code-signing policy
Plans and managed access
- Community, Relay, and Pro capabilities
- Relay and Pulse Mobile handoff
- Multi-tenant organizations (Enterprise/custom)
- Provider-hosted MSP operations (request-assisted)
Pulse Cloud is not generally available. Ordinary self-hosted Pulse remains the primary installation path; MSP and Enterprise access are explicit commercial paths rather than defaults in self-hosted setup.
Development and reference
Detailed design notes and dated migration specifications may remain in this directory for maintainers, but they are not operator setup guides unless they are linked from the sections above.
Previous versions and migrations
- Upgrade from v4 to v5
- Retired unified-navigation migration — historical context only; current Pulse uses platform-shaped navigation.
- Move a Pulse installation
Found a bug? Use the issue forms. For setup questions, use GitHub Discussions.