mirror of
https://github.com/rcourtman/Pulse.git
synced 2026-10-27 05:57:27 +00:00
rcourtman
c501376843
Return persisted planning acceptance or refusal inside the investigation turn. Keep model judgment separate from action authority and preserve accepted action identity across provider failures. Enforce actor/request idempotency atomically and retain complete approval and independent verification context. Preserve unknown disk evidence, stream whitespace and historical resolution timestamps. Keep conversation scrolling inside its own panel. Record real-model, disposable-lab and browser qualification with explicit population limits. Refs #1782
61 lines
2.4 KiB
Go
61 lines
2.4 KiB
Go
package actionlifecycle
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"testing"
|
|
"time"
|
|
|
|
unified "github.com/rcourtman/pulse-go-rewrite/internal/unifiedresources"
|
|
)
|
|
|
|
func TestPlanRequestReplayRetainsAcceptedPlanWithoutLiveRegistry(t *testing.T) {
|
|
store := unified.NewMemoryStore()
|
|
service := serviceForStore(t, store, testResource(time.Now().UTC(), unified.ApprovalAdmin), &stubExecutor{})
|
|
actor := testActionActor("requester", "default")
|
|
request := restartRequest()
|
|
plan, err := service.Plan(context.Background(), "default", request, actor)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
service.Registry = func(string) (*unified.ResourceRegistry, error) {
|
|
t.Fatal("replay consulted live registry")
|
|
return nil, nil
|
|
}
|
|
stronger := unified.ApprovalRequirementForFloor(unified.ApprovalMultiFactor)
|
|
replay, err := service.PlanWithOptions(context.Background(), "default", request, PlanOptions{Actor: actor, ApprovalRequirement: &stronger})
|
|
if err != nil || replay.ActionID != plan.ActionID || replay.PlanHash != plan.PlanHash || !replay.ExpiresAt.Equal(plan.ExpiresAt) {
|
|
t.Fatalf("replay changed accepted plan: %#v %v", replay, err)
|
|
}
|
|
}
|
|
|
|
func TestPlanRequestConflictCannotCreateAnotherAction(t *testing.T) {
|
|
store := unified.NewMemoryStore()
|
|
service := serviceForStore(t, store, testResource(time.Now().UTC(), unified.ApprovalAdmin), &stubExecutor{})
|
|
actor := testActionActor("requester", "default")
|
|
request := restartRequest()
|
|
plan, err := service.Plan(context.Background(), "default", request, actor)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
registry := service.Registry
|
|
service.Registry = func(string) (*unified.ResourceRegistry, error) {
|
|
t.Fatal("conflicting request consulted live registry")
|
|
return nil, nil
|
|
}
|
|
request.Reason = "different intent on same request identity"
|
|
if _, err := service.Plan(context.Background(), "default", request, actor); !errors.Is(err, unified.ErrActionIdentityConflict) {
|
|
t.Fatalf("conflicting replay: %v", err)
|
|
}
|
|
record, found, err := store.GetActionAudit(plan.ActionID)
|
|
if err != nil || !found || record.Request.Reason == request.Reason {
|
|
t.Fatalf("original record changed: %#v %v", record, err)
|
|
}
|
|
service.Registry = registry
|
|
request.RequestID += "-new"
|
|
replacement, err := service.Plan(context.Background(), "default", request, actor)
|
|
if err != nil || replacement.ActionID == plan.ActionID {
|
|
t.Fatalf("explicit new request failed: %#v %v", replacement, err)
|
|
}
|
|
}
|