mirror of
https://github.com/rcourtman/Pulse.git
synced 2026-10-26 13:39:47 +00:00
rcourtman
d167d7f492
## Why The Patrol weekly digest's **Investigated** line, on the Patrol page and in the weekly email, was unreliable: - It counted `investigation_outcome` lifecycle rows and read their outcome from `metadata["outcome"]`. The only writer of those rows (`updateInvestigationOutcomeLocked`) writes `prev_outcome`/`next_outcome`, so every counted row was labelled `unknown`. - Those rows are later steps of an earlier run's fix (approved, run, verified), not investigations. Meanwhile the `investigation_updated` rows every run writes were ignored, apart from one `LastInvestigatedAt` fallback count per finding. - So two runs on one finding counted once, a fix approved after last week's run counted as this week's investigation, and the email could print "Investigated: 3" followed by "No issues needed a closer look." ## What changes - `digestInvestigationRuns` counts one investigation per run that finished in the window, from the rows the findings store already writes for every run. That includes a run whose own fix was verified before it closed, and a run whose status a regression cleared mid-run. A fix that moves on afterwards relabels its run instead of counting again. - A run that failed with no outcome is labelled `failed`, the bucket name telemetry already uses. It sits after `timed_out` in `PatrolDigestOutcomeOrder`. - The summary-field fallback is removed. Every run since the v6 release writes lifecycle rows, and the fallback could count one run in two adjacent weeks. - Email: `failed` reads "ended with an error". When the count is above zero but no outcome in the breakdown has wording, the line shows the count alone instead of "No issues needed a closer look." or the watch-only sentence. - `internal/ai/findings.go` is unchanged; the digest reads the rows the store writes today. Known limits: lifecycle rows carry no session ID, so a late end written by an older run is read as the end of whichever run is open. That's the store-side stale-write problem, which is being closed separately with session checks. A run whose rows the 50-row lifecycle has already dropped is not counted. ## Proof - `internal/ai/patrol_digest_test.go` drives the store's own writers: the orchestrator's start and end updates, `UpdateInvestigationOutcome`, `ReconcileInvestigationOutcome`, `RecoverStuckInvestigation`, and `Resolve` + `Add` for a mid-run regression. The scenario covers ten finished runs plus one still running. The old code reports 8 investigations, 3 of them `unknown`. - `internal/api/contract_test.go` follows the scheduled email's path: store writers → `AISettingsHandler.BuildPatrolDigest` → `renderPatrolDigestEmail`. The old code reports two runs as `1 unknown`. - `internal/api/patrol_digest_email_test.go` checks the `failed` wording and the non-zero-count guard. - On pulse-dev, `go vet` passes for `./internal/ai/` and `./internal/api/`, and the full `./internal/ai/` package and every `PatrolDigest` test in `./internal/api/` pass. The new tests fail against the previous digest and email (negative controls via `-overlay`). ## Related The Patrol page's This week card gets the same `failed` wording and the same non-zero-count guard in #3132. Until that lands, a week with only failed runs reads "No issues needed a closer look." on the card. That's what those runs already showed as `unknown`, so it isn't a regression.
Pulse documentation
Start here for installation, platform setup, security, operations, and Pulse Intelligence. Commands, configuration keys, image names, API fields, and product identifiers remain untranslated in localized guides.
Need help with a failure? Read the safe reporting guidance before sharing evidence. A second reproduction or diagnostics export is not required; keep the original evidence if another attempt could interrupt workloads or send duplicate notifications. GitHub reports and attachments are public: review them locally and keep credentials and private details out.
Start here
- Install Pulse — signed Proxmox/Linux installation, Docker, Docker Compose, Kubernetes, and first-run setup.
- Production deployment and security — least-privilege Proxmox setup, root-agent boundaries, discovery, supply-chain verification, plan limits, scale evidence, and a rollout checklist.
- Upgrade from Pulse v5 — migration prerequisites, rollback, agent continuity, and post-upgrade checks.
- Releases and update channels: choosing Stable or Preview, beta and RC expectations, and how releases are tested and promoted.
- Configure Pulse — authentication, notifications, discovery, retention, and system settings.
- Deployment models — data locations, lifecycle, and differences between supported deployment paths.
- Troubleshooting and FAQ — common failures, diagnostics, and operator questions.
Localized getting started guides: Deutsch · Español
Platforms and agents
- Proxmox Backup Server
- Proxmox Mail Gateway
- Docker and Podman
- Kubernetes and Helm
- TrueNAS SCALE and CORE
- Unified Agent
- Agent security
- VM disk monitoring
- ZFS monitoring
- Temperature monitoring
VMware vSphere support is early access. Current builds expose dedicated vSphere inventory and recovery context, but operators should validate the integration against their own vCenter before production use.
Monitoring and operations
- Metrics history
- Recovery data
- Webhooks
- Automatic updates
- Centralized agent management (Pro)
- Operational trust model
- Current product screenshots
Pulse Intelligence
- Assistant, Patrol, and external-agent overview
- Patrol modes and safety
- Assistant safety model
- External agent HTTP and MCP substrate
Patrol watch-only analysis is available on Community with a local model or the operator's own provider. Investigation and governed fixes require the relevant Pulse Pro capabilities.
Security, privacy, and access
- Production deployment and security
- Security review scope
- Authentication and credential storage review packet
- Security guide
- Privacy and telemetry disclosure
- OIDC and SSO
- Proxy authentication
- Role-based access control (Pro)
- Audit logging (Pro)
- Reverse proxy configuration
- Code-signing policy
Plans and managed access
- Community, Relay, and Pro capabilities
- Relay and Pulse Mobile handoff
- Multi-tenant organizations (Enterprise/custom)
- Provider-hosted MSP operations (request-assisted)
Pulse Cloud is not generally available. Ordinary self-hosted Pulse remains the primary installation path; MSP and Enterprise access are explicit commercial paths rather than defaults in self-hosted setup.
Development and reference
Detailed design notes and dated migration specifications may remain in this directory for maintainers, but they are not operator setup guides unless they are linked from the sections above.
Previous versions and migrations
- Upgrade from v4 to v5
- Retired unified-navigation migration — historical context only; current Pulse uses platform-shaped navigation.
- Move a Pulse installation
Found a bug? Use the issue forms. For setup questions, use GitHub Discussions.