mirror of
https://github.com/rcourtman/Pulse.git
synced 2026-10-15 16:42:15 +00:00
rcourtman
b707512e38
golangci-lint run ./... failed on ~190 pre-existing errcheck violations and 5 unformatted files, burying any new regression in noise. Fix all of them: - Test files that hand-rolled mock-mode set/restore (vmware, truenas, and friends) now use the canonical setMockModeForTest/testutil.SetMockMode helper instead of drift copies that ignored SetEnabled errors. - internal/mock and internal/monitoring tests get package-local mustSetEnabled/mustSetMockEnabled/mustSetMonitorMockMode helpers that fail the test on toggle errors. - pkg/auth/sqlite_manager.go, pkg/metrics/store.go, pkg/server/server.go: rollbacks in defers use the explicit-discard idiom, migration renames and rollup commits log failures, the hosted reaper goroutine logs an error exit, shutdown mock-disable logs failures. - Remaining test sites check errors with t.Fatalf/t.Errorf or explicitly discard best-effort calls (restore-chmods, handler-closure unmarshals) per existing repo style. - gofmt: internal/api/maintenance_verification.go, internal/ai/demo.go and three findings test files. Only dupl findings remain (44 pre-existing production-code duplication pairs) — those need real refactors, not mechanical fixes. Full test suites pass for every touched package.
26 lines
697 B
Go
26 lines
697 B
Go
package monitoring
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/rcourtman/pulse-go-rewrite/internal/mock"
|
|
)
|
|
|
|
// mustSetMockEnabled toggles the package mock-mode state and fails the test
|
|
// on error so callers don't repeat the check at every toggle.
|
|
func mustSetMockEnabled(t testing.TB, enabled bool) {
|
|
t.Helper()
|
|
if err := mock.SetEnabled(enabled); err != nil {
|
|
t.Fatalf("mock.SetEnabled(%v): %v", enabled, err)
|
|
}
|
|
}
|
|
|
|
// mustSetMonitorMockMode flips a monitor between mock and real data and fails
|
|
// the test on error.
|
|
func mustSetMonitorMockMode(t testing.TB, m *Monitor, enabled bool) {
|
|
t.Helper()
|
|
if err := m.SetMockMode(enabled); err != nil {
|
|
t.Fatalf("SetMockMode(%v): %v", enabled, err)
|
|
}
|
|
}
|