rcourtman 3baab9bc59 Say a reviewed Patrol issue stays reviewed when suppression ends (#2615) ...

Ending a suppression puts the alert in Acknowledged when it is
acknowledged and in Open otherwise (`unsuppressOperationalAlert` in
internal/alerts/active_lifecycle.go). Acknowledged is not active
attention (`attentionStateCountsAsActive`).

The Patrol attention detail still promised otherwise for an issue that
was marked reviewed and then suppressed:
- its early-end button read "Return to active attention"
- the handled-view notice read "Returned to decision inbox"
- the suppression form offered "Return it to active attention after"

In each case the issue actually went back to Reviewed.

| | Reviewed issue | Unreviewed issue (unchanged) |
|---|---|---|
| Suppression duration | End suppression after | Return it to active
attention after |
| Early-end button | End suppression | Return to active attention |
| Handled-view notice | Suppression ended. It stays reviewed. | Returned
to decision inbox |

The duration label and the button follow the detail's
`operationalRecord.acknowledgement`. The notice instead reads the item's
state from the reload that follows the change. If the review was removed
elsewhere after the detail loaded (another tab), it still reports what
actually happened. `getAttentionSuppressionEndPresentation` owns the
copy.

The countdown line under the suppression ("Returns to active attention
in 1d.") is fixed separately by fix/future-relative-time, using the same
wording.

Verification:
- Three new tests in `PatrolAttentionWorkbench.test.tsx`:
  - The reviewed case fails on main.
- The stale-detail case fails on a version that predicts the notice from
the detail.
  - The unreviewed case pins the copy that stays the same.
- `src/features/patrol` and the two other test files that import the
workbench pass (492 tests).
- Run live on a private mock stack at 1440px, 800px and 390px:
- Reviewed case: mark an issue reviewed, suppress it, end the
suppression early from the handled view. The button read End
suppression, the notice read "Suppression ended. It stays reviewed. N
handled issues remain.", and the attention API reported the item
`acknowledged` with the active count unchanged.
  - Unreviewed case: the item came back to the inbox as `open`.
- Stale-detail case: the review was removed through the API while the
detail stayed open. The notice read "Returned to decision inbox",
matching the API state `open`.

2026-10-06 22:37:10 +01:00

..

internal

Describe releases as the fixed release train everywhere

2026-10-06 12:06:18 +01:00

v6

Say a reviewed Patrol issue stays reviewed when suppression ends (#2615)

2026-10-06 22:37:10 +01:00

control_plane.json

Cut 6.5 and later releases from main

2026-10-04 18:37:43 +01:00

control_plane.schema.json

…