mirror of
https://github.com/rcourtman/Pulse.git
synced 2026-09-10 18:45:53 +00:00
rcourtman
802b3aac49
Two real bugs that surfaced once the 20m test timeout let the internal/api and internal/monitoring packages run to completion. cloneVMwareInventoryMetrics omitted four fields: Commit23ea4e487(Surface vSphere VM uptime and guest disk usage) added UptimeSeconds, DiskUsedBytes, DiskTotalBytes, and DiskPercent to vmware.InventoryMetrics but did not extend cloneVMwareInventoryMetrics. The clone left those pointer fields aliased to the source struct, so the mock fixture refresh path (refreshVMwareInventoryMetrics writing through metrics.UptimeSeconds via ensureInt64Ptr) and the snapshot read path (inventoryUptimeSeconds dereferencing metrics.UptimeSeconds) raced on the same heap-allocated int64. TestMonitorBuildBroadcastFrontendStateUsesCanonicalMockUnifiedResources exemption: The test asserts broadcast state does not publish the lowercase- hyphenated legacy docker host label so canonical docker hosts surface their human-readable DisplayName. Commit89abed099(2026-05-24) added the docker-swarm-node resource type whose Name is the swarm node hostname (matching how Docker Swarm identifies node members), which collided with the legacy-label rejection. Refine the assertion to apply only to host-type resources (docker-host, agent, node).