gsadmin/pulse
1
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-09-22 19:23:31 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,878 Commits 295 Branches 594 Tags
869a88a8009858f28939cd27f288f271e73ab2fc
Commit Graph

407 Commits

Author SHA1 Message Date
rcourtman cd1420a085 test: Add filesystem error tests for CSRFTokenStore 
Cover saveUnsafe (57.9% to 89.5%) and load (50.0% to 67.9%) error paths
 2025-12-02 01:38:49 +00:00
rcourtman eadd8442bb test: Add filesystem error tests for RecoveryTokenStore.saveUnsafe 
Cover MkdirAll, WriteFile, and Rename error paths (46.7% to 86.7%)
 2025-12-02 01:36:21 +00:00
rcourtman a73dcd51a1 test: Add edge case tests for HandleSetupScript 
Tests method not allowed, missing type parameter, and invalid host
parameter error paths (71.4% to 79.2% coverage).
 2025-12-02 01:11:57 +00:00
rcourtman 13d05cbdc4 test: Add invalid PEM data test for newOIDCHTTPClient 
Tests the error path when a CA bundle file contains non-PEM data
(81.8% to 86.4% coverage).
 2025-12-02 01:00:06 +00:00
rcourtman 8eb195b9ff test: Add edge cases for UniversalRateLimitMiddleware 
Cover nil config initialization and static asset bypass paths.
Coverage: UniversalRateLimitMiddleware 87.5% -> 100%
 2025-12-02 00:54:37 +00:00
rcourtman ba03551dba test: Add edge case for initializeBootstrapToken error path 
Cover loadOrCreateBootstrapToken failure path.
Coverage: initializeBootstrapToken 92% -> 100%
 2025-12-02 00:51:44 +00:00
rcourtman 475575212d test: Add edge cases for HandleLookup error paths 
Cover method-not-allowed and missing lookup parameter paths.
Coverage: HandleLookup 88.4% -> 97.7%
 2025-12-02 00:49:16 +00:00
rcourtman 4c7bcd12d0 test: Add edge cases for normalizeRequestedScopes 
- Test blank scope identifier returns error
- Test wildcard-only input returns wildcard scope

Coverage: 89.7% → 96.6% (remaining 3.4% is defensive
unreachable code path)
 2025-12-02 00:19:20 +00:00
rcourtman 57e97c3ec1 test: Add edge case for ensureSettingsWriteScope valid scope 
Tests the code path when an API token has the settings:write scope,
which allows the operation to proceed.
 2025-12-02 00:13:32 +00:00
rcourtman 49f71015c8 Fix backup indicator being reset when VMs/Containers are re-polled 
UpdateVMsForInstance and UpdateContainersForInstance were replacing
guest data without preserving the LastBackup field that was populated
by SyncGuestBackupTimes. This caused backup indicators to always show
"no backup found" since the LastBackup would be wiped every time
guests were polled (which happens more frequently than backup polling).

Now both functions preserve LastBackup from existing data when the
incoming guest data has a zero value.

Related to #762
 2025-12-02 00:12:31 +00:00
rcourtman e471001d29 test: Add edge cases for isTrustedProxyIP and GetClientIP 
Tests empty string, invalid IP, and IP not matching CIDR for
isTrustedProxyIP. Also adds tests for GetClientIP empty RemoteAddr
and X-Real-IP fallback paths.
 2025-12-02 00:09:23 +00:00
rcourtman ad646e3923 test: Add tests for hostAgentSearchCandidates parameter variants 
Tests all code paths: strict mode (both params), platform only,
and no params (generic paths).
 2025-12-02 00:03:19 +00:00
rcourtman b2a4296557 test: Add edge case for handleServerInfo method not allowed 
Tests that POST requests to /api/server/info return 405.
 2025-12-02 00:01:17 +00:00
rcourtman a685ba26b4 test: Add edge case for capturePublicURLFromRequest nil inputs 
Tests the early return paths when router, request, or config are nil.
 2025-12-01 23:59:17 +00:00
rcourtman 7cbb5c061d test: Add edge case for canCapturePublicURL nil inputs 
Tests the early return paths when config or request are nil.
 2025-12-01 23:56:59 +00:00
rcourtman 588665a86f test: Add edge case for recovery token load read error 
Tests the error logging path when os.ReadFile fails with an error
other than ErrNotExist. Uses a directory in place of the file.
 2025-12-01 23:54:42 +00:00
rcourtman a3a894b54b test: Add edge case for writeErrorResponse encode failure 
Tests the error logging path when json.Encode fails due to a
write error on the ResponseWriter.
 2025-12-01 23:52:21 +00:00
rcourtman 80d9d00962 test: Add edge cases for markAutoRegistered empty inputs 
Tests the early return paths when nodeType or nodeName are empty.
 2025-12-01 23:50:10 +00:00
rcourtman 41a7bdf7ff test: Add edge case for clearBootstrapToken remove failure 
Tests the warning log path when os.Remove fails with an error other
than ErrNotExist. Uses a directory with contents to trigger ENOTEMPTY.
 2025-12-01 23:47:58 +00:00
rcourtman a86aa5d6b7 test: Add edge cases for initializeBootstrapToken 
- Nil router and nil config handling (no panic)
- OIDC enabled clears bootstrap token
Coverage: 80% to 92%.
 2025-12-01 23:40:22 +00:00
rcourtman 970e6c4d74 test: Add panic recovery test for ErrorHandler 
Tests that panics in handlers are recovered and return 500.
Coverage: 91.7% to 100%.
 2025-12-01 23:37:50 +00:00
rcourtman d64e992b8e test: Add edge case for handleValidateBootstrapToken invalid JSON 
Tests invalid JSON body triggers json.Decode error and returns 400.
Coverage: 90.5% to 100%.
 2025-12-01 23:35:40 +00:00
rcourtman 7a1d3ec2e5 test: Add edge case for RequireScope empty scope 
Empty scope should allow all requests through without checking token.
Coverage: 84.6% to 100%.
 2025-12-01 23:33:11 +00:00
rcourtman fb417ed742 test: Add edge case for normalizeNodeHost URL parse error 
Control character (null byte) triggers url.Parse error, covering the
'invalid host format' error branch. Coverage: 96.3% to 100%.
 2025-12-01 23:28:32 +00:00
rcourtman 15906fa333 test: Add edge case for DemoModeMiddleware WebSocket POST upgrade 
Tests WebSocket upgrade with POST method in demo mode, ensuring the
websocket check branch is exercised after the GET/HEAD/OPTIONS check.
Coverage: 90% to 100%.
 2025-12-01 23:24:06 +00:00
rcourtman 0e9cd9cce9 test: Add test for ErrorHandler empty URL path normalization 
Covers the fix for issue #334 where empty path is normalized to '/'.
Coverage: 87.5% to 91.7%.
 2025-12-01 23:21:07 +00:00
rcourtman 9e19ed45af test: Add edge case tests for auth helper functions 
- respondMissingScope: nil writer handling (80% to 100%)
- attachAPITokenRecord: nil record handling (80% to 100%)
- getAPITokenRecordFromRequest: wrong type and missing value (87.5% to 100%)
 2025-12-01 23:15:04 +00:00
rcourtman 51582b2d41 test: Add edge case test for addQueryParam URL parse error 
Add test case for URL containing control character (null byte)
which triggers url.Parse error and returns path unchanged.

Coverage improved from 88.9% to 100%.
 2025-12-01 23:08:36 +00:00
rcourtman b2eb110005 test: Add comprehensive test cases for isPrivateIP function 
Expand test coverage from 5 cases to 26 cases:
- Public IPv4/IPv6 addresses
- All RFC1918 private ranges (10.x, 172.16-31.x, 192.168.x)
- Loopback addresses (127.x.x.x, ::1)
- Link-local addresses (169.254.x.x, fe80::)
- Link-local multicast (224.0.0.x, ff02::)
- Unique local IPv6 (fc00::/7, fd00::)
- Edge cases: empty string, invalid IP, invalid format
- Addresses with port numbers

Coverage unchanged at 93.8% (remaining 6.2% is defensive
error handling for hardcoded valid CIDRs).
 2025-12-01 22:54:56 +00:00
rcourtman ee70224aa8 test: Add edge case tests for normalizeNodeHost function 
Add 6 new test cases covering previously untested branches:
- Empty host returns error
- Whitespace-only host returns error
- Unknown node type keeps host without port
- Docker node type keeps host without port
- IPv4 address gets default port
- IPv4 with custom port preserved

Coverage improved from 92.6% to 96.3%.
 2025-12-01 22:49:29 +00:00
rcourtman b310bd8fa5 test: Add tests for instance lookup and setup token validation 
- Add TestFindInstanceNameByHost (12 test cases):
  - PVE instance lookup by host
  - PBS instance lookup by host
  - Unknown node types return empty
  - Empty config handling

- Add TestValidateSetupToken (8 test cases):
  - Empty token returns false
  - Valid/expired/used setup codes
  - Valid/expired recent setup tokens
  - Non-existent token handling
  - Precedence of setup codes over recent tokens

Both functions now have 100% coverage of their logic paths.
 2025-12-01 22:19:30 +00:00
rcourtman c6f14b2c6e test: Add tests for webhook template generation and bootstrap token functions 
- Add comprehensive tests for generatePayloadFromTemplateWithService covering:
  - Valid JSON template rendering
  - Invalid template syntax error handling
  - Template execution errors
  - ntfy service (plain text, skips JSON validation)
  - Various services (discord, telegram, pagerduty) JSON validation
  - Template function usage (upper, title)
  - Numeric and boolean values in templates
  - Special characters and empty template edge cases

- Add tests for bootstrapTokenValid covering:
  - Nil router handling
  - Empty hash and empty token cases
  - Valid token validation
  - Invalid token rejection
  - Whitespace trimming

- Add tests for clearBootstrapToken covering:
  - Nil router safety
  - Token file deletion
  - Missing file handling
  - Empty path handling
 2025-12-01 22:07:40 +00:00
rcourtman c406dcaf4b test: Add tests for API helper functions 
- isRecentlyAutoRegistered: expiry logic, cleanup behavior
- clearAutoRegistered: key deletion, empty input handling
- normalizeDockerAgentArch: all arch variants, case handling, trimming
 2025-12-01 21:33:45 +00:00
rcourtman e70b3cb0f3 test: Improve coverage for cluster config handler functions 
- deriveSchemeAndPort: 87.5% → 100%
  - Empty/whitespace string handling
  - Invalid URL parsing fallback
  - Host without port
- ensureHostHasPort: 91.7% → 100%
  - Empty port returns host unchanged
  - Protocol-relative URL handling (//host)
 2025-12-01 14:46:00 +00:00
rcourtman bf15d01648 test: Add tests for ResetRateLimitForIP function 
- Test nil globalRateLimitConfig early return (no panic)
- Test actual rate limit reset clears IP from limiter
- Improves coverage from 80% to 100%
 2025-12-01 14:38:26 +00:00
rcourtman e57e2e696b test: Improve coverage for security utility functions 
- Add fmt.Stringer test cases for isEmptyInterface (80% -> 100%)
- Expand isTrustedNetwork tests with edge cases (80% -> 100%)
  - Empty/invalid IP strings
  - Invalid CIDR handling
  - Whitespace trimming in CIDRs
  - Multiple network matching
 2025-12-01 14:33:31 +00:00
rcourtman b311625328 test: Add tests for config handler utility functions 
- TestSanitizeErrorMessage: All operation types and error hiding
- TestFindExistingGuestURL: Node matching and edge cases
- TestMatchInstanceNameByHost: Host normalization and matching
Coverage: api 27.7% → 28.0%
 2025-12-01 14:09:35 +00:00
rcourtman c4d16b75dd test: Add tests for OIDC handler utility functions 
- sanitizeOIDCReturnTo: path validation, protocol-relative URL rejection
- addQueryParam: URL building, encoding, fragment preservation
- extractStringClaim: type handling (string, []string, []interface{})
- extractStringSliceClaim: slice extraction with comma/space splitting
- matchesValue: case-insensitive value matching
- matchesDomain: email domain validation with @ handling
- intersects: set intersection with case normalization
- buildRedirectURL: proxy header handling (X-Forwarded-Proto/Host)

Coverage: api 26.7% → 27.7%
 2025-12-01 13:56:38 +00:00
rcourtman 200db2dc40 test: Add error path tests for loadOrCreateBootstrapToken 
Cover all error branches in bootstrap token loading:
- Empty/whitespace dataPath validation
- os.MkdirAll failure (directory creation blocked by file)
- os.WriteFile failure (read-only directory)
- os.ReadFile failure (permission denied on existing file)
- Empty file contents after read
- Whitespace-only file contents

Also adds test for generateBootstrapToken helper function.
 2025-12-01 13:00:27 +00:00
rcourtman 6c88f79404 ADA changes (auto-committed by cron safety check) 2025-12-01 11:20:57 +00:00
rcourtman 48aacecf0d test: Add unit tests for validateIPAddress, validatePort, defaultPortForNodeType 
Cover API validation functions that were previously untested:
- validateIPAddress: IPv4/IPv6 validation with edge cases
- validatePort: Port range validation (1-65535)
- defaultPortForNodeType: Proxmox node type to default port mapping
 2025-12-01 11:06:50 +00:00
rcourtman b21fad833e refactor: Remove dead HandleTestExistingNode function 
This function was superseded by HandleTestNode which is wired to the
router at /api/config/nodes/{id}/test. The old function was not
registered in the router and served no purpose.

Removes 121 lines of unused code.
 2025-12-01 10:21:50 +00:00
rcourtman 7d62fb6f1c Add unit tests for extractHostAndPort utility function 
27 test cases covering URL/host:port parsing for node configuration:
- Scheme stripping (http://, https://)
- Path removal from URLs
- IPv4 addresses with and without ports
- IPv6 addresses (bracketed with port, unbracketed)
- Edge cases (empty string, localhost, port-only)
- Error cases (malformed brackets)

Documents current behavior: bracketed IPv6 without port returns error
(net.SplitHostPort limitation).
 2025-12-01 01:19:10 +00:00
rcourtman bd3e5e44e6 Add unit tests for system_settings.go map utility functions 
52 test cases covering:
- firstValueForKeys: 18 cases for multi-key lookup with priority ordering
- hasAnyKey: 15 cases for key existence checking
- discoveryConfigMap: 19 cases for nested config extraction with camelCase/snake_case support

Tests verify edge cases including nil maps, empty key slices, type assertion failures,
and priority ordering for field name variants used in configuration parsing.
 2025-12-01 01:05:07 +00:00
rcourtman 0c648907a4 Add unit tests for RecoveryTokenStore 
20 test cases covering:
- Token generation (uniqueness, expiry durations, format)
- Token validation (valid, invalid, expired, used, empty store)
- Concurrent use protection (replay attack prevention)
- Cleanup routine (expired tokens, used tokens, stop signal)
- Persistence (save, load, filter expired on load)
- Edge cases (missing file, invalid JSON)
 2025-12-01 00:06:32 +00:00
rcourtman 69e87abf4e Add unit tests for normalizePVEUser and shouldSkipClusterAutoDetection 2025-11-30 23:53:41 +00:00
rcourtman 2d87746eb0 Add unit tests for security lockout and session management functions 
Tests for internal/api/security.go:
- RecordFailedLogin: increments counts, triggers lockout at max attempts
- ClearFailedLogins: clears count and lockout state
- GetLockoutInfo: returns correct attempts/lockout status
- ResetLockout: admin lockout reset functionality
- TrackUserSession: user/session tracking
- GetSessionUsername: session lookup
- clearCSRFCookie: nil safety, cookie attributes
- issueNewCSRFCookie: nil safety, empty session handling
- FailedLogin/AuditEvent struct field validation

30 test cases covering lockout, session tracking, and CSRF functions.
 2025-11-30 23:33:51 +00:00
rcourtman b41611db72 Add unit tests for SessionStore (internal/api) 
Coverage for sessionHash, CreateSession, ValidateSession,
ValidateAndExtendSession, DeleteSession, persistence, and cleanup.
21 test cases covering session lifecycle, expiration handling,
and disk persistence. Coverage 25.0% → 25.3%.
 2025-11-30 23:18:34 +00:00
rcourtman 83303b61b9 Add unit tests for auth helper functions (internal/api) 
Tests for detectProxy, isConnectionSecure, getCookieSettings, and
generateSessionToken functions. Covers proxy detection for various
headers including X-Forwarded-For, CF-Ray, Forwarded (RFC 7239),
and secure connection detection via TLS and proxy headers.
 2025-11-30 23:04:44 +00:00
rcourtman fb27ff7c75 Add unit tests for bootstrap token functions (internal/api) 
20 test cases covering:
- generateBootstrapToken: uniqueness, format, hex encoding
- loadOrCreateBootstrapToken: new token creation, existing token loading,
  empty/whitespace paths, empty token files, directory creation, file permissions
- bootstrapTokenValid: nil router safety, empty hash/token handling
- clearBootstrapToken: nil safety, file deletion, state clearing

First test file for bootstrap_token.go security utilities.
 2025-11-30 22:54:28 +00:00