From bf256b47bfc38264b40cb61f2e744e1590b1bb02 Mon Sep 17 00:00:00 2001
From: Pulse Monitor <pulse@pulse-monitor.dev>
Date: Sat, 23 Aug 2025 23:23:25 +0000
Subject: [PATCH] fix: install script exiting early when updateChannel not in
 system.json

The install script was using 'set -e' which caused it to exit when grep didn't find updateChannel in system.json. Added '|| true' to prevent early exit.

Also improved version detection with fallback when GitHub API is rate-limited.
---
 install.sh | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/install.sh b/install.sh
index d71c6b582..025a11834 100755
--- a/install.sh
+++ b/install.sh
@@ -849,8 +849,17 @@ main() {
         fi
         
         # Get both stable and RC versions
-        local STABLE_VERSION=$(curl -s https://api.github.com/repos/$GITHUB_REPO/releases/latest | grep '"tag_name":' | sed -E 's/.*"([^"]+)".*/\1/' 2>/dev/null)
-        local RC_VERSION=$(curl -s https://api.github.com/repos/$GITHUB_REPO/releases | grep '"tag_name":' | head -1 | sed -E 's/.*"([^"]+)".*/\1/' 2>/dev/null)
+        # Try GitHub API first, but have a fallback
+        local STABLE_VERSION=$(curl -s https://api.github.com/repos/$GITHUB_REPO/releases/latest | grep '"tag_name":' | sed -E 's/.*"([^"]+)".*/\1/' 2>/dev/null || true)
+        
+        # If rate limited or failed, try direct GitHub latest URL
+        if [[ -z "$STABLE_VERSION" ]] || [[ "$STABLE_VERSION" == *"rate limit"* ]]; then
+            # Use the GitHub latest release redirect to get version
+            STABLE_VERSION=$(curl -sI https://github.com/$GITHUB_REPO/releases/latest | grep -i '^location:' | sed -E 's|.*tag/([^[:space:]]+).*|\1|' | tr -d '\r' || true)
+        fi
+        
+        # For RC, we need the API, so if it fails just use empty
+        local RC_VERSION=$(curl -s https://api.github.com/repos/$GITHUB_REPO/releases | grep '"tag_name":' | head -1 | sed -E 's/.*"([^"]+)".*/\1/' 2>/dev/null || true)
         
         # Determine default update channel
         UPDATE_CHANNEL="stable"
@@ -859,7 +868,7 @@ main() {
         if [[ -n "${FORCE_CHANNEL}" ]]; then
             UPDATE_CHANNEL="${FORCE_CHANNEL}"
         elif [[ -f "$CONFIG_DIR/system.json" ]]; then
-            CONFIGURED_CHANNEL=$(cat "$CONFIG_DIR/system.json" 2>/dev/null | grep -o '"updateChannel"[[:space:]]*:[[:space:]]*"[^"]*"' | sed 's/.*"\([^"]*\)"$/\1/')
+            CONFIGURED_CHANNEL=$(cat "$CONFIG_DIR/system.json" 2>/dev/null | grep -o '"updateChannel"[[:space:]]*:[[:space:]]*"[^"]*"' | sed 's/.*"\([^"]*\)"$/\1/' || true)
             if [[ "$CONFIGURED_CHANNEL" == "rc" ]]; then
                 UPDATE_CHANNEL="rc"
             fi