From bb6a8be6f14c2053a7f407847f28019597efe2e2 Mon Sep 17 00:00:00 2001
From: "pulse-triage[bot]"
 <249995291+pulse-triage[bot]@users.noreply.github.com>
Date: Wed, 23 Sep 2026 22:31:02 +0100
Subject: [PATCH] test(alerts): verify orphaned backup opt-out clears canonical
 alert

The existing regression only rejected legacy backup-age key prefixes, so it could pass while a canonical orphaned alert remained active. Assert a real orphan alert exists first, then disable the option and require every backup-age alert to clear. This guards the opt-out relevant to #1741 without changing runtime policy.

Change-source: pulse-maintainer
---
 internal/alerts/alerts_test.go | 25 +++++++++++++++++++++----
 1 file changed, 21 insertions(+), 4 deletions(-)

diff --git a/internal/alerts/alerts_test.go b/internal/alerts/alerts_test.go
index 48c8f041bc..9de3a49844 100644
--- a/internal/alerts/alerts_test.go
+++ b/internal/alerts/alerts_test.go
@@ -2416,7 +2416,7 @@ func TestCheckBackupsSkipsOrphanedWhenDisabled(t *testing.T) {
 	m := newTestManager(t)
 	m.ClearActiveAlerts()
 
-	alertOrphaned := false
+	alertOrphaned := true
 	m.mu.Lock()
 	m.config.Enabled = true
 	m.config.BackupDefaults = BackupAlertConfig{
@@ -2447,12 +2447,29 @@ func TestCheckBackupsSkipsOrphanedWhenDisabled(t *testing.T) {
 
 	m.CheckBackups(rollups, map[string]GuestLookup{}, map[string][]GuestLookup{})
 
+	m.mu.RLock()
+	var activeOrphan bool
+	for _, alert := range m.activeAlerts {
+		if alert != nil && alert.Type == "backup-age" && metadataBoolValue(alert.Metadata, "orphaned") {
+			activeOrphan = true
+		}
+	}
+	m.mu.RUnlock()
+	if !activeOrphan {
+		t.Fatal("expected an orphaned backup-age alert before disabling orphaned alerts")
+	}
+
+	disabled := false
+	m.mu.Lock()
+	m.config.BackupDefaults.AlertOrphaned = &disabled
+	m.mu.Unlock()
+	m.CheckBackups(rollups, map[string]GuestLookup{}, map[string][]GuestLookup{})
+
 	m.mu.RLock()
 	defer m.mu.RUnlock()
 	for storageKey, alert := range m.activeAlerts {
-		id := effectiveAlertID(alert, storageKey)
-		if strings.HasPrefix(id, "backup-age-") {
-			t.Fatalf("expected orphaned backup to be skipped, found alert %s", id)
+		if alert != nil && alert.Type == "backup-age" {
+			t.Fatalf("expected orphaned backup alert to clear after disabling it, found %s", effectiveAlertID(alert, storageKey))
 		}
 	}
 }