From ba7c97fb97faa2d80fb873c557daedfd6965971d Mon Sep 17 00:00:00 2001
From: "pulse-triage[bot]"
 <249995291+pulse-triage[bot]@users.noreply.github.com>
Date: Sat, 24 Oct 2026 07:38:48 +0100
Subject: [PATCH] Check the real Plans and Billing route during Settings smoke

Require each consuming panel to finish loading; an unrelated heading on the removed system-pro route previously let Page Not Found satisfy the smoke test.

Contract-Neutral: Browser-test target and readiness assertion repair only; no runtime, route, access or commercial contract changes.
Change-source: pulse-maintainer
---
 .../tests/11-first-session.spec.ts            | 19 ++++---------------
 1 file changed, 4 insertions(+), 15 deletions(-)

diff --git a/tests/integration/tests/11-first-session.spec.ts b/tests/integration/tests/11-first-session.spec.ts
index b0ecc55cd3..9fb0a2e3f9 100644
--- a/tests/integration/tests/11-first-session.spec.ts
+++ b/tests/integration/tests/11-first-session.spec.ts
@@ -176,7 +176,7 @@ test.describe.serial("First-session experience", () => {
       { path: "/settings/system-updates", readyHeading: "Updates" },
       { path: "/settings/security-overview", readyHeading: "Security Overview" },
       { path: "/settings/security-auth", readyHeading: "Authentication" },
-      { path: "/settings/system-pro", readyHeading: "Current plan" },
+      { path: "/settings/system-billing", readyHeading: "Current plan" },
     ] as const;
 
     const consoleErrors: string[] = [];
@@ -207,19 +207,6 @@ test.describe.serial("First-session experience", () => {
         await page.waitForURL(/\/settings/, { timeout: 10_000 });
         await expect(page.locator("#root")).toBeVisible();
 
-        // Wait for the panel content to render. Scope to the settings content
-        // area (everything after the sidebar) to avoid matching sidebar labels.
-        // Fall back to a page-wide heading if the content area locator doesn't
-        // match — some layouts render headings differently.
-        const panelHeading = page
-          .locator('h1, h2, h3, [role="heading"]')
-          .filter({ hasNotText: "Settings" })
-          .first();
-        await expect(
-          panelHeading,
-          `Route ${route} did not render any panel content`,
-        ).toBeVisible({ timeout: 10_000 });
-
         // The outer page heading is present even while General remains on
         // "Loading configuration...". Require the consuming panel, not just
         // the Settings shell, before judging requests and console output.
@@ -230,7 +217,9 @@ test.describe.serial("First-session experience", () => {
           }),
           `Route ${route} did not finish loading a settings panel`,
         ).toBeVisible({ timeout: 10_000 });
-        await expect(page.getByText("Loading configuration...", { exact: true })).toHaveCount(0);
+        await expect(
+          page.getByText("Loading configuration...", { exact: true }),
+        ).toHaveCount(0);
 
         const unexpectedAIRequests = aiRequests
           .urls()