From 3bef5c3028f63541d98b43b1cdc43686dd418cd3 Mon Sep 17 00:00:00 2001 From: rcourtman <8825017+rcourtman@users.noreply.github.com> Date: Wed, 7 Oct 2026 20:07:27 +0100 Subject: [PATCH] Remove unused CorrelationsResponse type CorrelationsResponse described the /api/ai/intelligence/correlations payload. #2674 removed its uses in the Patrol investigation context model and that model's tests, and #2677 removed the last ones, AIAPI.getCorrelations and the aiIntelligence store's correlation loader, because no page renders the global learned-correlation list. Nothing in the repository references the interface any more, tests included. ResourceCorrelation stays: ResourceIntelligence.correlations, the resource drawer's relationship map (ResourceCorrelationSummary.tsx) and resourceCorrelationPresentation.ts all still use it. TypeScript erases the interface, so the production build is byte-identical: npm run build before and after this change emitted the same 187 dist files with identical SHA-256 sums. Contract-Neutral: Deletes an unreferenced TypeScript interface; the compiler erases it, the production bundle is byte-identical, and no wire, store or page contract changes. --- .../71a0ce6b24830582.json | 39 +++++++++++++++++++ frontend-modern/src/types/aiIntelligence.ts | 8 ---- 2 files changed, 39 insertions(+), 8 deletions(-) create mode 100644 frontend-modern/browser-verification/71a0ce6b24830582.json diff --git a/frontend-modern/browser-verification/71a0ce6b24830582.json b/frontend-modern/browser-verification/71a0ce6b24830582.json new file mode 100644 index 0000000000..0b4623136d --- /dev/null +++ b/frontend-modern/browser-verification/71a0ce6b24830582.json @@ -0,0 +1,39 @@ +{ + "version": 1, + "base_sha": "48c2d6cdce8d019151e3567873de88e21b76bb22", + "verified_at": "2026-10-07T19:05:33Z", + "result": "passed", + "changed_paths": [ + "frontend-modern/src/types/aiIntelligence.ts" + ], + "content_sha256": { + "frontend-modern/src/types/aiIntelligence.ts": "d9287de8171cee10d72c5df0a898c28e47e649be3f9dee8fa791a7406c0adc51" + }, + "routes": [ + "/patrol", + "/kubernetes" + ], + "viewports": [ + { + "width": 1280, + "height": 800 + }, + { + "width": 390, + "height": 844 + } + ], + "states": [ + "Type-only deletion: TypeScript erases CorrelationsResponse, and npm run build before and after the change emitted the same 187 dist files with identical SHA-256 sums, so the shipped bundle is byte-identical", + "Embedded production build in a private demo-mode mock stack (port 7763, fresh data dir)", + "Patrol inbox: Patrol heading and 5 attention rows render at 1280x800 and 390x844", + "Kubernetes deployment account-portal drawer opens with header, technical summary, runtime context and identity sections at both widths", + "No console errors and no page errors on either route at either width; no /api/ai/intelligence/correlations request", + "Relationship map (ResourceCorrelationSummary, the surviving ResourceCorrelation consumer) not rendered in this pass: table-row drawers do not fetch per-resource facets or resource intelligence (enableRemoteHistory is off for table-row presentation); its code ships unchanged in the byte-identical bundle" + ], + "interactions": [ + "Demo sign-in, then navigate to /patrol and wait for the Patrol heading", + "Navigate to /kubernetes and click the account-portal deployment row to open its inline resource drawer", + "Repeat the same pass at 1280x800 and 390x844" + ] +} diff --git a/frontend-modern/src/types/aiIntelligence.ts b/frontend-modern/src/types/aiIntelligence.ts index 48237e884d..f20f83c533 100644 --- a/frontend-modern/src/types/aiIntelligence.ts +++ b/frontend-modern/src/types/aiIntelligence.ts @@ -109,14 +109,6 @@ export interface ResourceCorrelation { description: string; } -export interface CorrelationsResponse { - correlations: ResourceCorrelation[]; - count: number; - message?: string; - license_required?: boolean; - upgrade_url?: string; -} - export interface IntelligenceSummary { timestamp: string; overall_health: IntelligenceHealthScore;