From 8d14fc2023134abf49342b249db9967334ec1e79 Mon Sep 17 00:00:00 2001
From: Pulse Monitor <pulse@pulse-monitor.dev>
Date: Wed, 10 Sep 2025 13:03:42 +0000
Subject: [PATCH] refactor: remove update command creation to avoid conflicts
 with Community Scripts

- Native installations no longer create /usr/local/bin/update
- Avoids conflicts with Community Scripts /bin/update command
- Community installations keep their update mechanism
- Native installations use: curl -fsSL ... | bash for updates
- Each installation method respects the other's update approach
---
 install.sh | 24 +++++++-----------------
 1 file changed, 7 insertions(+), 17 deletions(-)

diff --git a/install.sh b/install.sh
index be31a483b..b0a114a50 100755
--- a/install.sh
+++ b/install.sh
@@ -867,13 +867,8 @@ create_lxc_container() {
         echo 'net.ipv4.tcp_keepalive_time=60' >> /etc/sysctl.conf
         sysctl -p >/dev/null 2>&1
         
-        # Create convenient update script
-        cat > /usr/local/bin/update << 'EOF'
-#!/bin/bash
-echo 'Updating Pulse...'
-curl -sSL https://raw.githubusercontent.com/rcourtman/Pulse/main/install.sh | bash
-EOF
-        chmod +x /usr/local/bin/update
+        # Note: We don't create /usr/local/bin/update to avoid conflicts with Community Scripts
+        # Native installations should update using: curl -fsSL ... | bash
         
         # Ensure /usr/local/bin is in PATH for all users
         if ! grep -q '/usr/local/bin' /etc/profile 2>/dev/null; then
@@ -1325,15 +1320,9 @@ setup_directories() {
 }
 
 setup_update_command() {
-    # Create or update the convenient update script
-    if [[ ! -f /usr/local/bin/update ]]; then
-        cat > /usr/local/bin/update << 'EOF'
-#!/bin/bash
-echo 'Updating Pulse...'
-curl -sSL https://raw.githubusercontent.com/rcourtman/Pulse/main/install.sh | bash
-EOF
-        chmod +x /usr/local/bin/update
-    fi
+    # Function kept for compatibility but no longer creates update command
+    # Community Scripts installations have their own update mechanism at /bin/update
+    # Native installations should update using: curl -fsSL ... | bash
     
     # Ensure /usr/local/bin is in PATH for all users
     if ! grep -q '/usr/local/bin' /etc/profile 2>/dev/null; then
@@ -2073,7 +2062,8 @@ uninstall_pulse() {
     rm -f /etc/systemd/system/pulse-update.timer
     rm -f /usr/local/bin/pulse
     rm -f /usr/local/bin/pulse-auto-update.sh
-    rm -f /usr/local/bin/update
+    # Don't remove update commands - might be from community scripts
+    # rm -f /usr/local/bin/update
     
     # Remove user (if it exists and isn't being used by other services)
     if id "pulse" &>/dev/null; then