From 82a38713cefcaf3430dd76dbc14ccf6a6500df6c Mon Sep 17 00:00:00 2001
From: Pulse Monitor <pulse@pulse-monitor.dev>
Date: Fri, 29 Aug 2025 07:17:13 +0000
Subject: [PATCH] fix: properly implement Node column in list view

addresses #370 - added Node column that only appears in flat/list view mode, positioned between VMID and Uptime columns. This allows users to see which node each guest belongs to when viewing the flat list, while keeping the cleaner view when in grouped mode.
---
 .../src/components/Dashboard/Dashboard.tsx         | 14 +++++++++-----
 .../src/components/Dashboard/GuestRow.tsx          | 11 ++++++-----
 rebuild.sh                                         | 13 +++++++++++++
 3 files changed, 28 insertions(+), 10 deletions(-)
 create mode 100755 rebuild.sh

diff --git a/frontend-modern/src/components/Dashboard/Dashboard.tsx b/frontend-modern/src/components/Dashboard/Dashboard.tsx
index b67fe351d..8cf0f5809 100644
--- a/frontend-modern/src/components/Dashboard/Dashboard.tsx
+++ b/frontend-modern/src/components/Dashboard/Dashboard.tsx
@@ -63,10 +63,6 @@ export function Dashboard(props: DashboardProps) {
     (storedGroupingMode === 'grouped' || storedGroupingMode === 'flat') ? storedGroupingMode : 'grouped'
   );
   
-  // Debug logging
-  createEffect(() => {
-    console.log('[Dashboard] Grouping mode:', groupingMode());
-  });
   
   const [showFilters, setShowFilters] = createSignal(
     localStorage.getItem('dashboardShowFilters') !== null 
@@ -699,6 +695,14 @@ export function Dashboard(props: DashboardProps) {
                 >
                   VMID {sortKey() === 'vmid' && (sortDirection() === 'asc' ? '▲' : '▼')}
                 </th>
+                <Show when={groupingMode() === 'flat'}>
+                  <th 
+                    class="px-2 py-1.5 text-left text-[11px] sm:text-xs font-medium uppercase tracking-wider w-[80px] cursor-pointer hover:bg-gray-200 dark:hover:bg-gray-600"
+                    onClick={() => handleSort('node')}
+                  >
+                    Node {sortKey() === 'node' && (sortDirection() === 'asc' ? '▲' : '▼')}
+                  </th>
+                </Show>
                 <th 
                   class="px-2 py-1.5 text-left text-[11px] sm:text-xs font-medium uppercase tracking-wider w-[100px] cursor-pointer hover:bg-gray-200 dark:hover:bg-gray-600"
                   onClick={() => handleSort('uptime')}
@@ -777,7 +781,7 @@ export function Dashboard(props: DashboardProps) {
                             return (
                               <GuestRow 
                                 guest={guest} 
-                                showNode={false} 
+                                showNode={groupingMode() === 'flat'} 
                                 alertStyles={getAlertStyles(guestId, activeAlerts)}
                                 onTagClick={handleTagClick}
                                 activeSearch={search()}
diff --git a/frontend-modern/src/components/Dashboard/GuestRow.tsx b/frontend-modern/src/components/Dashboard/GuestRow.tsx
index 5ca4b2c02..f8ca6332c 100644
--- a/frontend-modern/src/components/Dashboard/GuestRow.tsx
+++ b/frontend-modern/src/components/Dashboard/GuestRow.tsx
@@ -33,11 +33,6 @@ interface GuestRowProps {
 export function GuestRow(props: GuestRowProps) {
   const [customUrl, setCustomUrl] = createSignal<string | undefined>(props.customUrl);
   
-  // Debug logging
-  createEffect(() => {
-    console.log('[GuestRow] showNode:', props.showNode, 'node:', props.guest.node, 'name:', props.guest.name);
-  });
-  
   // Create guest ID for metadata
   const guestId = createMemo(() => {
     return props.guest.id || `${props.guest.node}-${props.guest.vmid}`;
@@ -160,6 +155,12 @@ export function GuestRow(props: GuestRowProps) {
         {props.guest.vmid}
       </td>
 
+      {/* Node (only in list view) */}
+      <Show when={props.showNode}>
+        <td class="p-1 px-2 whitespace-nowrap text-sm text-gray-600 dark:text-gray-400">
+          {props.guest.node}
+        </td>
+      </Show>
 
       {/* Uptime */}
       <td class={`p-1 px-2 text-sm whitespace-nowrap ${
diff --git a/rebuild.sh b/rebuild.sh
new file mode 100755
index 000000000..96f4a52be
--- /dev/null
+++ b/rebuild.sh
@@ -0,0 +1,13 @@
+#!/bin/bash
+# Rebuild script for Pulse development
+
+echo "Building frontend..."
+cd /opt/pulse/frontend-modern && npm run build
+
+echo "Building Go binary..."
+cd /opt/pulse && go build -o pulse ./cmd/pulse
+
+echo "Restarting service..."
+sudo systemctl restart pulse-backend
+
+echo "Done!"
\ No newline at end of file