From 7b3c2ede58315de3bbd4474667b389bbca08eb04 Mon Sep 17 00:00:00 2001
From: rcourtman <courtmanr@gmail.com>
Date: Sat, 9 May 2026 14:12:10 +0100
Subject: [PATCH] Tighten Manage dialog action-bar copy and cluster subtitle
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Three small frictions on the Manage existing-connection dialog:

- Save button read 'Update Node' (technical, paired with 'Add Node'
  when adding). Switch to 'Save changes' / 'Add node' so the editing
  case uses standard form-save vocabulary.

- 'Test Connection' was Title Case while sibling buttons in the same
  bar were sentence case ('Pause connection', 'Delete connection').
  Normalize to 'Test connection' / 'Testing…'.

- Cluster Manage dialog subtitle read 'Proxmox VE cluster · Editing
  via contact node delly (https://delly:8006) · API + Pulse Agent'.
  The 'Editing via' clause was awkward and didn't add information the
  user couldn't infer from the dialog body. Drop it: now reads
  'Proxmox VE cluster · delly (https://delly:8006) · API + Pulse
  Agent'.
---
 .../src/components/Settings/InfrastructureWorkspace.tsx      | 5 ++++-
 .../src/components/Settings/NodeModalStatusFooter.tsx        | 4 ++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/frontend-modern/src/components/Settings/InfrastructureWorkspace.tsx b/frontend-modern/src/components/Settings/InfrastructureWorkspace.tsx
index b8b831b887..745e05fb2a 100644
--- a/frontend-modern/src/components/Settings/InfrastructureWorkspace.tsx
+++ b/frontend-modern/src/components/Settings/InfrastructureWorkspace.tsx
@@ -877,7 +877,10 @@ const InfrastructureWorkspaceContent: Component<InfrastructureWorkspaceProps> =
     const row = editingRow();
     if (row?.isCluster) {
       const contact = connection.name || connection.address || 'contact node';
-      return `${label} cluster · Editing via contact node ${contact}${connection.address ? ` (${connection.address})` : ''}${methods}`;
+      // Drop the 'Editing via' phrasing that read awkwardly; just identify
+      // the contact node and address. The dialog body and the row the user
+      // came from already make the editing context clear.
+      return `${label} cluster · ${contact}${connection.address ? ` (${connection.address})` : ''}${methods}`;
     }
     return `${label}${connection.address ? ` · ${connection.address}` : ''}${methods}`;
   });
diff --git a/frontend-modern/src/components/Settings/NodeModalStatusFooter.tsx b/frontend-modern/src/components/Settings/NodeModalStatusFooter.tsx
index 1ecaf6e04f..04d39b3b14 100644
--- a/frontend-modern/src/components/Settings/NodeModalStatusFooter.tsx
+++ b/frontend-modern/src/components/Settings/NodeModalStatusFooter.tsx
@@ -154,7 +154,7 @@ export const NodeModalStatusFooter: Component<NodeModalStatusFooterProps> = (pro
               disabled={state.isTesting() || props.togglePending || props.deletePending}
               class="px-4 py-2 text-sm border border-border text-base-content rounded-md hover:bg-surface-hover transition-colors disabled:opacity-50 disabled:cursor-not-allowed"
             >
-              {state.isTesting() ? 'Testing...' : 'Test Connection'}
+              {state.isTesting() ? 'Testing…' : 'Test connection'}
             </button>
           </Show>
         </div>
@@ -213,7 +213,7 @@ export const NodeModalStatusFooter: Component<NodeModalStatusFooterProps> = (pro
               disabled={props.togglePending || props.deletePending}
               class="px-4 py-2 text-sm bg-blue-600 text-white rounded-md hover:bg-blue-700 transition-colors disabled:opacity-50 disabled:cursor-not-allowed"
             >
-              {state.isEditingExistingNode() ? 'Update' : 'Add'} Node
+              {state.isEditingExistingNode() ? 'Save changes' : 'Add node'}
             </button>
           </Show>
         </div>