From 64e920ac1659c141bc976eefac46201a9c03861b Mon Sep 17 00:00:00 2001 From: Pulse Monitor Date: Fri, 29 Aug 2025 06:56:16 +0000 Subject: [PATCH] fix: use SolidJS Show component for proper conditional rendering addresses #370 - switched from JSX conditional expressions to SolidJS Show component for table column conditional rendering to ensure proper DOM updates --- frontend-modern/src/components/Dashboard/Dashboard.tsx | 4 ++-- frontend-modern/src/components/Dashboard/GuestRow.tsx | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/frontend-modern/src/components/Dashboard/Dashboard.tsx b/frontend-modern/src/components/Dashboard/Dashboard.tsx index 4d4fd357b..3a3919c13 100644 --- a/frontend-modern/src/components/Dashboard/Dashboard.tsx +++ b/frontend-modern/src/components/Dashboard/Dashboard.tsx @@ -694,14 +694,14 @@ export function Dashboard(props: DashboardProps) { > VMID {sortKey() === 'vmid' && (sortDirection() === 'asc' ? '▲' : '▼')} - {groupingMode() === 'flat' && ( + handleSort('node')} > Node {sortKey() === 'node' && (sortDirection() === 'asc' ? '▲' : '▼')} - )} + handleSort('uptime')} diff --git a/frontend-modern/src/components/Dashboard/GuestRow.tsx b/frontend-modern/src/components/Dashboard/GuestRow.tsx index 9d8592eed..2d92565fa 100644 --- a/frontend-modern/src/components/Dashboard/GuestRow.tsx +++ b/frontend-modern/src/components/Dashboard/GuestRow.tsx @@ -156,11 +156,11 @@ export function GuestRow(props: GuestRowProps) { {/* Node (optional) */} - {props.showNode && ( + {props.guest.node} - )} + {/* Uptime */}