From 63b24757d6b9e52729488a6c5a8f4fffcdb5f23f Mon Sep 17 00:00:00 2001 From: "pulse-triage[bot]" <249995291+pulse-triage[bot]@users.noreply.github.com> Date: Sat, 3 Oct 2026 02:37:27 +0100 Subject: [PATCH] Accept readable wrapped help tables as well as local scrolling Phone tables can fit through wrapping. Check their container bound, or actual local scroll movement for wide tables, rather than requiring overflow. Change-source: pulse-maintainer --- frontend-modern/browser-tests/navigation-help.cjs | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/frontend-modern/browser-tests/navigation-help.cjs b/frontend-modern/browser-tests/navigation-help.cjs index 2cd5994658..8acc827772 100644 --- a/frontend-modern/browser-tests/navigation-help.cjs +++ b/frontend-modern/browser-tests/navigation-help.cjs @@ -85,7 +85,15 @@ const { chromium, webkit } = require('playwright'); })); assert.ok(geometry.localScroll); assert.ok(geometry.outer <= geometry.viewport + 1); - if (width === 390) assert.ok(geometry.table > geometry.wrapper); + if (width === 390 && geometry.table > geometry.wrapper + 1) { + const movement = await inventory.evaluate((table) => { + table.parentElement.scrollLeft = 180; + return table.parentElement.scrollLeft; + }); + assert.ok(movement > 0, 'wide tables must remain locally scrollable'); + } else { + assert.ok(geometry.table <= geometry.wrapper + 1, 'wrapped table must fit its container'); + } await page.screenshot({ path: path.join(artifacts, `${engine}-truenas.png`) }); await page.getByRole('link', { name: '← All documentation' }).click();