diff --git a/docs/FAQ.md b/docs/FAQ.md index 7b3754e3f..14366730a 100644 --- a/docs/FAQ.md +++ b/docs/FAQ.md @@ -99,9 +99,8 @@ This is usually one of these issues: **Proxmox 8**: Check that: 1. QEMU Guest Agent is installed and running in the VM 2. Your API token has `VM.Monitor` permission -3. Token has privilege separation disabled (`privsep=0`) - - Check with: `pveum user token list pulse-monitor@pam | grep pulse-token` - - If privsep=1, recreate: `pveum user token add pulse-monitor@pam pulse-token --privsep 0` + - If you added this node before Pulse v4.7, you need to re-run the setup script + - Or manually add: `pveum role add PulseMonitor -privs VM.Monitor && pveum aclmod / -user pulse-monitor@pam -role PulseMonitor` **All versions**: - Guest agent must be installed: `apt install qemu-guest-agent` (Linux) or virtio-win tools (Windows) diff --git a/internal/api/config_handlers.go b/internal/api/config_handlers.go index b932a967d..e7432cd1b 100644 --- a/internal/api/config_handlers.go +++ b/internal/api/config_handlers.go @@ -2141,16 +2141,12 @@ if [ "$HAS_VM_MONITOR" = true ]; then echo "" echo "ℹ️ Note for Proxmox 8 VM Disk Monitoring:" echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━" - echo "If VM disk usage shows 0%, check that:" - echo " 1. qemu-guest-agent is installed and running in the VM" - echo " 2. Your token has privilege separation disabled (privsep=0)" + echo "VM disk monitoring requires:" + echo " 1. qemu-guest-agent installed and running in the VM" + echo " 2. VM.Monitor permission (just added above)" echo "" - echo "To check token privsep status:" - echo " pveum user token list pulse-monitor@pam | grep %s" - echo "" - echo "If privsep=1, recreate the token:" - echo " pveum user token remove pulse-monitor@pam %s" - echo " pveum user token add pulse-monitor@pam %s --privsep 0" + echo "If you previously added this node before Pulse v4.7," + echo "you needed to re-run this script to add VM.Monitor permission." echo "" else # PVE 9+ - VM.Monitor was removed diff --git a/internal/monitoring/monitor.go b/internal/monitoring/monitor.go index a16e0b0ef..3aaa48725 100644 --- a/internal/monitoring/monitor.go +++ b/internal/monitoring/monitor.go @@ -982,7 +982,7 @@ func (m *Monitor) pollVMsAndContainersEfficient(ctx context.Context, instanceNam log.Info(). Str("instance", instanceName). Str("vm", res.Name). - Msg("• Proxmox 8: Ensure token has VM.Monitor permission and privsep=0") + Msg("• Proxmox 8: If you added this node before v4.7, re-run the setup script to add VM.Monitor permission") log.Info(). Str("instance", instanceName). Str("vm", res.Name). @@ -1358,7 +1358,7 @@ func (m *Monitor) pollVMsWithNodes(ctx context.Context, instanceName string, cli log.Info(). Str("instance", instanceName). Str("vm", vm.Name). - Msg("• Proxmox 8: Ensure token has VM.Monitor permission and privsep=0") + Msg("• Proxmox 8: If you added this node before v4.7, re-run the setup script to add VM.Monitor permission") log.Info(). Str("instance", instanceName). Str("vm", vm.Name).