gsadmin/pulse
1
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-10-24 04:33:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reconcile batch-start upstream governance cleanup

Browse Source 
Preserve reviewed local integrations and the upstream removal of unused subsystem default proof lists.

Change-source: pulse-maintainer
This commit is contained in:
pulse-triage[bot]
2026-10-05 14:22:58 +01:00
parent 5b560521e2 914fabfc1f
commit 5a11eadd41
5 changed files with 110 additions and 197 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/release_control/canonical_completion_guard_test.py
+1 -4
View File
@@ -254,10 +254,7 @@ class CanonicalCompletionGuardTest(unittest.TestCase):
self.assertTrue(
monitoring["verification"]["require_explicit_path_policy_coverage"]
)
self.assertEqual(
monitoring["verification"]["exact_files"],
["internal/unifiedresources/code_standards_test.go"],
)
self.assertEqual(monitoring["verification"]["exact_files"], [])
policy_ids = [policy["id"] for policy in monitoring["verification"]["path_policies"]]
self.assertEqual(
policy_ids,
scripts/release_control/registry_audit.py
+22 -47
View File
@@ -27,16 +27,24 @@ REGISTRY_PATH = DEFAULT_CONTROL_PLANE["registry_path"]
REGISTRY_SCHEMA_PATH = DEFAULT_CONTROL_PLANE["registry_schema_path"]
LANE_RE = re.compile(r"^L[0-9]+$")
# Every subsystem requires explicit path-policy coverage, so the default
# policy is never consulted and a path policy's own proof routes are the whole
# requirement. allow_same_subsystem_tests would widen a policy to every test
# the subsystem owns (any internal/ai test for ai-runtime's mutation-registry
# policy), and its reach would grow with ownership rather than with the
# policy. The commit guards ignored the flag from the v6 import until it was
# retired here, so false is the behaviour every commit has been held to.
# verification policy is never consulted and a path policy's own proof routes
# are the whole requirement. Proofs listed on the default count for nothing,
# though authors kept adding them there as if they did; nearly all were
# already on a path policy. allow_same_subsystem_tests would widen a policy to
# every test the subsystem owns (any internal/ai test for ai-runtime's
# mutation-registry policy), and its reach would grow with ownership rather
# than with the policy. The commit guards ignored the flag from the v6 import
# until it was retired here, so false is the behaviour every commit has been
# held to.
SAME_SUBSYSTEM_TESTS_RETIRED = (
"it would accept any test the subsystem owns as proof for this policy; "
"list the accepted proofs in test_prefixes or exact_files instead"
)
DEFAULT_PROOFS_RETIRED = (
"explicit path-policy coverage never consults the subsystem default, so "
"proofs listed here count for nothing; list them on the path policy whose "
"runtime files they prove"
)
def load_registry_payload(*, staged: bool = False) -> dict[str, Any]:
@@ -363,47 +371,14 @@ def audit_registry_payload(
elif verification.get("require_explicit_path_policy_coverage") is not True:
errors.append(f"{context}.verification.require_explicit_path_policy_coverage must be true")
test_prefixes = verification.get("test_prefixes")
if not isinstance(test_prefixes, list):
errors.append(f"{context}.verification.test_prefixes must be a list")
test_prefixes = []
else:
if len(test_prefixes) != len(set(test_prefixes)):
errors.append(f"{context}.verification.test_prefixes must not contain duplicates")
if test_prefixes != sorted_casefold(test_prefixes):
errors.append(f"{context}.verification.test_prefixes must be sorted lexicographically")
for prefix_index, prefix in enumerate(test_prefixes):
if not isinstance(prefix, str) or not prefix.strip():
errors.append(f"{context}.verification.test_prefixes[{prefix_index}] must be a non-empty string")
continue
validate_prefix(
prefix,
context=f"{context}.verification.test_prefixes[{prefix_index}]",
errors=errors,
tracked_files=tracked_files,
**path_validation_scope,
)
exact_files = verification.get("exact_files")
if not isinstance(exact_files, list):
errors.append(f"{context}.verification.exact_files must be a list")
exact_files = []
else:
if len(exact_files) != len(set(exact_files)):
errors.append(f"{context}.verification.exact_files must not contain duplicates")
if exact_files != sorted_casefold(exact_files):
errors.append(f"{context}.verification.exact_files must be sorted lexicographically")
for file_index, path in enumerate(exact_files):
if not isinstance(path, str) or not path.strip():
errors.append(f"{context}.verification.exact_files[{file_index}] must be a non-empty string")
continue
validate_path_reference(
path,
context=f"{context}.verification.exact_files[{file_index}]",
errors=errors,
tracked_files=tracked_files,
**path_validation_scope,
)
for field in ("test_prefixes", "exact_files"):
default_proofs = verification.get(field)
if not isinstance(default_proofs, list):
errors.append(f"{context}.verification.{field} must be a list")
elif default_proofs:
errors.append(
f"{context}.verification.{field} must be empty: " + DEFAULT_PROOFS_RETIRED
)
path_policies = verification.get("path_policies")
if not isinstance(path_policies, list):
scripts/release_control/registry_audit_test.py
+65 -21
View File
@@ -573,7 +573,7 @@ class RegistryAuditTest(unittest.TestCase):
"verification": {
"allow_same_subsystem_tests": False,
"test_prefixes": [],
"exact_files": ["internal/monitoring/canonical_guardrails_test.go"],
"exact_files": [],
"require_explicit_path_policy_coverage": True,
"path_policies": [
{
@@ -617,9 +617,7 @@ class RegistryAuditTest(unittest.TestCase):
"verification": {
"allow_same_subsystem_tests": False,
"test_prefixes": [],
"exact_files": [
"pulse-mobile:src/relay/__tests__/client.test.ts",
],
"exact_files": [],
"require_explicit_path_policy_coverage": True,
"path_policies": [
{
@@ -663,7 +661,7 @@ class RegistryAuditTest(unittest.TestCase):
"verification": {
"allow_same_subsystem_tests": False,
"test_prefixes": [],
"exact_files": ["pulse-mobile:src/relay/__tests__/client.test.ts"],
"exact_files": [],
"require_explicit_path_policy_coverage": True,
"path_policies": [
{
@@ -745,7 +743,7 @@ class RegistryAuditTest(unittest.TestCase):
"verification": {
"allow_same_subsystem_tests": False,
"test_prefixes": [],
"exact_files": ["pkg/licensing/cloud_paid_guardrails_test.go"],
"exact_files": [],
"require_explicit_path_policy_coverage": True,
"path_policies": [
{
@@ -788,7 +786,7 @@ class RegistryAuditTest(unittest.TestCase):
"verification": {
"allow_same_subsystem_tests": False,
"test_prefixes": [],
"exact_files": ["internal/api/contract_test.go"],
"exact_files": [],
"require_explicit_path_policy_coverage": False,
"path_policies": [
{
@@ -835,7 +833,7 @@ class RegistryAuditTest(unittest.TestCase):
"verification": {
"allow_same_subsystem_tests": True,
"test_prefixes": [],
"exact_files": ["internal/monitoring/canonical_guardrails_test.go"],
"exact_files": [],
"require_explicit_path_policy_coverage": True,
"path_policies": [
{
@@ -872,6 +870,57 @@ class RegistryAuditTest(unittest.TestCase):
)
self.assertIn("test_prefixes or exact_files", same_subsystem_errors[0])
def test_audit_registry_payload_rejects_default_verification_proofs(self) -> None:
# The default policy is never consulted under explicit path-policy
# coverage, so a proof listed there would look accepted and count for
# nothing.
payload = {
"version": 13,
"shared_ownerships": [],
"subsystems": [
{
"id": "monitoring",
"lane": "L6",
"contract": "docs/release-control/v6/internal/subsystems/monitoring.md",
"owned_prefixes": ["internal/monitoring/"],
"owned_files": [],
"verification": {
"allow_same_subsystem_tests": False,
"test_prefixes": ["internal/monitoring/"],
"exact_files": ["internal/monitoring/canonical_guardrails_test.go"],
"require_explicit_path_policy_coverage": True,
"path_policies": [
{
"id": "monitoring-runtime",
"label": "monitoring runtime proof",
"match_prefixes": ["internal/monitoring/"],
"match_files": [],
"allow_same_subsystem_tests": False,
"test_prefixes": [],
"exact_files": ["internal/monitoring/canonical_guardrails_test.go"],
}
],
},
}
],
}
tracked_files = {
"docs/release-control/v6/internal/subsystems/monitoring.md",
"internal/monitoring/monitor.go",
"internal/monitoring/canonical_guardrails_test.go",
}
report = audit_registry_payload(payload, tracked_files=tracked_files, status_lane_ids={"L6"})
self.assertEqual(
[error.split(":", 1)[0] for error in report["errors"]],
[
"subsystems[0].verification.test_prefixes must be empty",
"subsystems[0].verification.exact_files must be empty",
],
)
self.assertIn("list them on the path policy", report["errors"][0])
def test_audit_registry_payload_rejects_uncanonical_ordering(self) -> None:
payload = {
"version": 13,
@@ -885,11 +934,8 @@ class RegistryAuditTest(unittest.TestCase):
"owned_files": ["internal/monitoring/b.go", "internal/monitoring/a.go"],
"verification": {
"allow_same_subsystem_tests": False,
"test_prefixes": ["internal/monitoring/tests/", "frontend/tests/"],
"exact_files": [
"internal/monitoring/z_test.go",
"internal/monitoring/a_test.go",
],
"test_prefixes": [],
"exact_files": [],
"require_explicit_path_policy_coverage": True,
"path_policies": [
{
@@ -916,7 +962,7 @@ class RegistryAuditTest(unittest.TestCase):
"verification": {
"allow_same_subsystem_tests": False,
"test_prefixes": [],
"exact_files": ["internal/alerts/guardrails_test.go"],
"exact_files": [],
"require_explicit_path_policy_coverage": True,
"path_policies": [
{
@@ -953,8 +999,6 @@ class RegistryAuditTest(unittest.TestCase):
self.assertIn("registry.json subsystems must be sorted by subsystem id", joined)
self.assertIn("subsystems[0].owned_prefixes must be sorted lexicographically", joined)
self.assertIn("subsystems[0].owned_files must be sorted lexicographically", joined)
self.assertIn("subsystems[0].verification.test_prefixes must be sorted lexicographically", joined)
self.assertIn("subsystems[0].verification.exact_files must be sorted lexicographically", joined)
self.assertIn(
"subsystems[0].verification.path_policies[0].match_prefixes must be sorted lexicographically",
joined,
@@ -986,7 +1030,7 @@ class RegistryAuditTest(unittest.TestCase):
"verification": {
"allow_same_subsystem_tests": False,
"test_prefixes": [],
"exact_files": ["internal/monitoring/guardrails_test.go"],
"exact_files": [],
"require_explicit_path_policy_coverage": True,
"path_policies": [
{
@@ -1039,7 +1083,7 @@ class RegistryAuditTest(unittest.TestCase):
"verification": {
"allow_same_subsystem_tests": False,
"test_prefixes": [],
"exact_files": ["internal/api/contract_test.go"],
"exact_files": [],
"require_explicit_path_policy_coverage": True,
"path_policies": [
{
@@ -1063,7 +1107,7 @@ class RegistryAuditTest(unittest.TestCase):
"verification": {
"allow_same_subsystem_tests": False,
"test_prefixes": [],
"exact_files": ["internal/unifiedresources/code_standards_test.go"],
"exact_files": [],
"require_explicit_path_policy_coverage": True,
"path_policies": [
{
@@ -1120,7 +1164,7 @@ class RegistryAuditTest(unittest.TestCase):
"verification": {
"allow_same_subsystem_tests": False,
"test_prefixes": [],
"exact_files": ["internal/api/contract_test.go"],
"exact_files": [],
"require_explicit_path_policy_coverage": True,
"path_policies": [
{
@@ -1144,7 +1188,7 @@ class RegistryAuditTest(unittest.TestCase):
"verification": {
"allow_same_subsystem_tests": False,
"test_prefixes": [],
"exact_files": ["internal/unifiedresources/code_standards_test.go"],
"exact_files": [],
"require_explicit_path_policy_coverage": True,
"path_policies": [
{