From 2ef4492972cc4bb400da8e69468204c28f3c045d Mon Sep 17 00:00:00 2001
From: "pulse-triage[bot]"
 <249995291+pulse-triage[bot]@users.noreply.github.com>
Date: Wed, 2 Sep 2026 10:51:19 +0100
Subject: [PATCH] Qualify TrueNAS 26 JSON-RPC snapshot transport

TrueNAS 26 removes the REST API, making Pulse's authenticated JSON-RPC path the compatibility boundary for snapshot collection. Pin the full transport contract to the published 26-BETA.3 version so any fallback to removed REST endpoints is caught before release.

Change-source: pulse-maintainer
---
 internal/truenas/transport_test.go | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/internal/truenas/transport_test.go b/internal/truenas/transport_test.go
index 8972b4cb5..c421e1358 100644
--- a/internal/truenas/transport_test.go
+++ b/internal/truenas/transport_test.go
@@ -670,7 +670,7 @@ func TestJSONRPCQueryReturnsCompleteUnpaginatedInventory(t *testing.T) {
 	}
 }
 
-func TestJSONRPCFetchSnapshotKeepsAllModernInventoryOnOneTransport(t *testing.T) {
+func TestJSONRPCFetchSnapshotUsesPublishedTrueNAS26MethodsWithoutREST(t *testing.T) {
 	methodCalls := make(map[string]int)
 	var methodCallsMu sync.Mutex
 	fixture := newProtocolFixture(t, func(_ int, request trueNASRPCRequest) protocolFixtureReply {
@@ -684,7 +684,7 @@ func TestJSONRPCFetchSnapshotKeepsAllModernInventoryOnOneTransport(t *testing.T)
 		case "system.info":
 			return protocolFixtureReply{result: map[string]any{
 				"hostname":       "inventory-nas",
-				"version":        "TrueNAS-SCALE-25.10.4",
+				"version":        "TrueNAS-SCALE-26.0.0-BETA.3",
 				"system_serial":  "INVENTORY-1",
 				"uptime_seconds": 60,
 				"physical_cores": 4,
@@ -745,7 +745,9 @@ func TestJSONRPCFetchSnapshotKeepsAllModernInventoryOnOneTransport(t *testing.T)
 	if err != nil {
 		t.Fatalf("FetchSnapshot() error = %v", err)
 	}
-	if snapshot.System.Hostname != "inventory-nas" || snapshot.System.CPUPercent != 12 {
+	if snapshot.System.Hostname != "inventory-nas" ||
+		snapshot.System.Version != "TrueNAS-SCALE-26.0.0-BETA.3" ||
+		snapshot.System.CPUPercent != 12 {
 		t.Fatalf("unexpected snapshot system: %+v", snapshot.System)
 	}