From 2b587229068dcbd8474dff24d3ded9834873ca93 Mon Sep 17 00:00:00 2001
From: rcourtman <courtmanr@gmail.com>
Date: Thu, 25 Dec 2025 05:08:34 +0000
Subject: [PATCH] fix: Node disk column respects Trends view mode. Related to
 #904

The disk column for Proxmox nodes was always showing bars even when
Trends (sparklines) view mode was selected. Memory column was correctly
checking viewMode() but disk was not.

Added the same Show when={viewMode() === 'sparklines'} conditional
to the disk column rendering in NodeSummaryTable.
---
 .../components/shared/NodeSummaryTable.tsx    | 29 ++++++++++++++-----
 1 file changed, 21 insertions(+), 8 deletions(-)

diff --git a/frontend-modern/src/components/shared/NodeSummaryTable.tsx b/frontend-modern/src/components/shared/NodeSummaryTable.tsx
index b290d525e..ce6a99031 100644
--- a/frontend-modern/src/components/shared/NodeSummaryTable.tsx
+++ b/frontend-modern/src/components/shared/NodeSummaryTable.tsx
@@ -653,14 +653,27 @@ export const NodeSummaryTable: Component<NodeSummaryTableProps> = (props) => {
                             showMobile={false}
                           />
                         }>
-                          <StackedDiskBar
-                            aggregateDisk={{
-                              total: node!.disk?.total || 0,
-                              used: node!.disk?.used || 0,
-                              free: (node!.disk?.total || 0) - (node!.disk?.used || 0),
-                              usage: node!.disk?.total ? (node!.disk.used / node!.disk.total) : 0
-                            }}
-                          />
+                          <Show
+                            when={viewMode() === 'sparklines'}
+                            fallback={
+                              <StackedDiskBar
+                                aggregateDisk={{
+                                  total: node!.disk?.total || 0,
+                                  used: node!.disk?.used || 0,
+                                  free: (node!.disk?.total || 0) - (node!.disk?.used || 0),
+                                  usage: node!.disk?.total ? (node!.disk.used / node!.disk.total) : 0
+                                }}
+                              />
+                            }
+                          >
+                            <ResponsiveMetricCell
+                              value={diskPercentValue}
+                              type="disk"
+                              resourceId={metricsKey}
+                              isRunning={online}
+                              showMobile={false}
+                            />
+                          </Show>
                         </Show>
                       </div>
                     </td>