From 1ccd973050f3a5236777f86e48aab76db9c45166 Mon Sep 17 00:00:00 2001 From: "pulse-triage[bot]" <249995291+pulse-triage[bot]@users.noreply.github.com> Date: Thu, 27 Aug 2026 20:34:14 +0100 Subject: [PATCH] Fix legacy webhook normalization migration proof Change-source: pulse-maintainer --- tests/migration/v5_to_v6_test.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/migration/v5_to_v6_test.go b/tests/migration/v5_to_v6_test.go index bfee9418a..2638a24c4 100644 --- a/tests/migration/v5_to_v6_test.go +++ b/tests/migration/v5_to_v6_test.go @@ -287,14 +287,18 @@ func TestV5GotifyWebhookSurvivesV6LoadAndRestart(t *testing.T) { loaded, err := v6Persistence.LoadWebhooks() require.NoError(t, err) require.Len(t, loaded, 1) - assert.Equal(t, v5Webhooks[0], loaded[0]) + // The legacy empty value and the v6 canonical "all" value have identical + // delivery semantics; persistence normalizes the former at its read boundary. + want := v5Webhooks[0] + want.MinimumSeverity = "all" + assert.Equal(t, want, loaded[0]) // A fresh persistence instance models the post-upgrade process restart. restarted := config.NewConfigPersistence(dataDir) loadedAfterRestart, err := restarted.LoadWebhooks() require.NoError(t, err) require.Len(t, loadedAfterRestart, 1) - assert.Equal(t, v5Webhooks[0], loadedAfterRestart[0]) + assert.Equal(t, want, loadedAfterRestart[0]) stored, err := os.ReadFile(filepath.Join(dataDir, "webhooks.enc")) require.NoError(t, err)