From 08088bbe64f20ffb6162af198543d76b4d5d2313 Mon Sep 17 00:00:00 2001
From: "courtmanr@gmail.com" <courtmanr@gmail.com>
Date: Thu, 5 Jun 2025 12:43:47 +0100
Subject: [PATCH] remove: redundant Global Alert Settings from main settings
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Remove duplicate Global Alert Settings section from settings.js
- All alert management functionality now centralized in Alert Management modal
- Global thresholds available in System Alerts tab
- Email configuration enhanced in Notification Settings tab
- Eliminates redundancy and consolidates user experience
- Prevents confusion from having same settings in multiple places

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
---
 src/public/js/ui/settings.js | 61 ------------------------------------
 1 file changed, 61 deletions(-)

diff --git a/src/public/js/ui/settings.js b/src/public/js/ui/settings.js
index 770d3585a..47628d53e 100644
--- a/src/public/js/ui/settings.js
+++ b/src/public/js/ui/settings.js
@@ -450,67 +450,6 @@ PulseApp.ui.settings = (() => {
         const smtp = config.advanced?.smtp || {};
         return `
             <div class="space-y-6">
-                <!-- Global Alert Settings -->
-                <div class="bg-gray-50 dark:bg-gray-900 rounded-lg p-4">
-                    <h3 class="text-lg font-semibold text-gray-800 dark:text-gray-200 mb-4">Global Alert Settings</h3>
-                    <p class="text-sm text-gray-600 dark:text-gray-400 mb-4">These settings apply to all VMs and LXCs unless overridden by custom thresholds below.</p>
-                    
-                    <div class="grid grid-cols-1 md:grid-cols-2 lg:grid-cols-4 gap-4 mb-4">
-                        <label class="flex items-center">
-                            <input type="checkbox" name="ALERT_CPU_ENABLED" ${alerts.cpu?.enabled !== false ? 'checked' : ''}
-                                   class="mr-2 h-4 w-4 text-blue-600 focus:ring-blue-500 border-gray-300 rounded">
-                            <span class="text-sm text-gray-700 dark:text-gray-300">CPU Alerts</span>
-                        </label>
-                        <label class="flex items-center">
-                            <input type="checkbox" name="ALERT_MEMORY_ENABLED" ${alerts.memory?.enabled !== false ? 'checked' : ''}
-                                   class="mr-2 h-4 w-4 text-blue-600 focus:ring-blue-500 border-gray-300 rounded">
-                            <span class="text-sm text-gray-700 dark:text-gray-300">Memory Alerts</span>
-                        </label>
-                        <label class="flex items-center">
-                            <input type="checkbox" name="ALERT_DISK_ENABLED" ${alerts.disk?.enabled !== false ? 'checked' : ''}
-                                   class="mr-2 h-4 w-4 text-blue-600 focus:ring-blue-500 border-gray-300 rounded">
-                            <span class="text-sm text-gray-700 dark:text-gray-300">Disk Alerts</span>
-                        </label>
-                        <label class="flex items-center">
-                            <input type="checkbox" name="ALERT_DOWN_ENABLED" ${alerts.down?.enabled !== false ? 'checked' : ''}
-                                   class="mr-2 h-4 w-4 text-blue-600 focus:ring-blue-500 border-gray-300 rounded">
-                            <span class="text-sm text-gray-700 dark:text-gray-300">Down Alerts</span>
-                        </label>
-                    </div>
-
-                    <div class="grid grid-cols-1 md:grid-cols-3 gap-4">
-                        <div>
-                            <label class="block text-sm font-medium text-gray-700 dark:text-gray-300 mb-1">
-                                CPU Threshold (%)
-                            </label>
-                            <input type="number" name="ALERT_CPU_THRESHOLD"
-                                   value="${alerts.cpu?.threshold || ''}"
-                                   placeholder="85 (default)"
-                                   min="50" max="100"
-                                   class="w-full px-3 py-2 text-sm border border-gray-300 dark:border-gray-600 rounded-md bg-white dark:bg-gray-700 text-gray-900 dark:text-gray-100 focus:ring-2 focus:ring-blue-500 focus:border-blue-500">
-                        </div>
-                        <div>
-                            <label class="block text-sm font-medium text-gray-700 dark:text-gray-300 mb-1">
-                                Memory Threshold (%)
-                            </label>
-                            <input type="number" name="ALERT_MEMORY_THRESHOLD"
-                                   value="${alerts.memory?.threshold || ''}"
-                                   placeholder="90 (default)"
-                                   min="50" max="100"
-                                   class="w-full px-3 py-2 text-sm border border-gray-300 dark:border-gray-600 rounded-md bg-white dark:bg-gray-700 text-gray-900 dark:text-gray-100 focus:ring-2 focus:ring-blue-500 focus:border-blue-500">
-                        </div>
-                        <div>
-                            <label class="block text-sm font-medium text-gray-700 dark:text-gray-300 mb-1">
-                                Disk Threshold (%)
-                            </label>
-                            <input type="number" name="ALERT_DISK_THRESHOLD"
-                                   value="${alerts.disk?.threshold || ''}"
-                                   placeholder="95 (default)"
-                                   min="50" max="100"
-                                   class="w-full px-3 py-2 text-sm border border-gray-300 dark:border-gray-600 rounded-md bg-white dark:bg-gray-700 text-gray-900 dark:text-gray-100 focus:ring-2 focus:ring-blue-500 focus:border-blue-500">
-                        </div>
-                    </div>
-                </div>
 
                 <!-- Email Notification Settings -->
                 <div class="bg-gray-50 dark:bg-gray-900 rounded-lg p-4">